From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] gnu: Add Aircrack-ng.
Date: Fri, 12 Aug 2016 14:01:37 -0400
Message-ID: <20160812180137.GB10275@jasmine>
References: <20160811125817.17636-1-ericbavier@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34218)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bYGmK-0007bI-Sw
	for guix-devel@gnu.org; Fri, 12 Aug 2016 14:01:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bYGmE-0002yY-Rb
	for guix-devel@gnu.org; Fri, 12 Aug 2016 14:01:55 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:57354)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bYGmC-0002xg-IU
	for guix-devel@gnu.org; Fri, 12 Aug 2016 14:01:50 -0400
Content-Disposition: inline
In-Reply-To: <20160811125817.17636-1-ericbavier@openmailbox.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: ericbavier@openmailbox.org
Cc: guix-devel@gnu.org, Eric Bavier <bavier@member.fsf.org>

On Thu, Aug 11, 2016 at 07:58:17AM -0500, ericbavier@openmailbox.org wrote:
> * gnu/packages/networking.scm (aircrack-ng): New variable.

> +    (inputs
> +     `(("libgcrypt" ,libgcrypt)
> +       ("libnl" ,libnl)
> +       ("ethtool" ,ethtool)
> +       ("pcre" ,pcre)
> +       ("sqlite" ,sqlite)
> +       ("zlib" ,zlib)))

The output does not refer to ethtool:
$ guix gc --references $(./pre-inst-env guix build aircrack-ng)
/gnu/store/5992iq1v7arqa14ym3di58n4la0893nv-zlib-1.2.8
/gnu/store/9nifwk709wajpyfwa0jzaa3p6mf10vxs-gcc-4.9.3-lib
/gnu/store/m9vxvhdj691bq1f85lpflvnhcvrdilih-glibc-2.23
/gnu/store/mpm281yzwcxzfc9n86krr61yhs2ja6gd-libgcrypt-1.7.0
/gnu/store/xiskld167yl4nqy57glqmcl3yp3bknh0-sqlite-3.12.2
/gnu/store/ykzwykkvr2c80rw4l1qh3mvfdkl7jibi-bash-4.3.42
/gnu/store/yydfpvk513c16ixgq8kdvi3g4l6clw2w-libnl-3.2.25
/gnu/store/zwc6ck9j0wv80kz5snw5acwb39ws88m1-pcre-8.38

Do you think that's a problem?

> +    (arguments
> +     `(#:make-flags `("sqlite=true"
> +                      "gcrypt=true"
> +                      "libnl=true"
> +                      "pcre=true"
> +                      "experimental=true"

I think this flag deserves an explanatory comment.