all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Tomáš Čech" <sleep_walker@gnu.org>
To: guix-devel@gnu.org
Subject: Re: [PATCHv2 2/2] gnu: bash-completion: Update to 2.3. Update the patch.
Date: Tue, 9 Aug 2016 11:05:36 +0200	[thread overview]
Message-ID: <20160809072653.qlyefumll3y3wowb@venom> (raw)
In-Reply-To: <20160808211441.GC22268@jasmine>

[-- Attachment #1: Type: text/plain, Size: 423 bytes --]

On Mon, Aug 08, 2016 at 05:14:41PM -0400, Leo Famulari wrote:
>On Sun, Aug 07, 2016 at 12:07:15PM +0200, Tomáš Čech wrote:
>> * gnu/packages/bash.scm(bash-completion): Update to 2.3.
>
>Same nit-pick about leaving a space before the variable name :)
>
>> * gnu/packages/patches/bash-completion-directories.patch: New version of
>>   the patch for the same purpose.
>
>LGTM

Thanks for review, pushed.

S_W

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2016-08-09  9:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-03  8:53 [PATCH] gnu: bash-completion: Update to 2.3 Tomáš Čech
2016-08-05 18:53 ` Andreas Enge
2016-08-07  3:06   ` Leo Famulari
2016-08-07  8:06     ` Tomáš Čech
2016-08-07 10:07       ` [PATCHv2 1/2] gnu: bash-completion: Modify to modify-phases Tomáš Čech
2016-08-07 10:07         ` [PATCHv2 2/2] gnu: bash-completion: Update to 2.3. Update the patch Tomáš Čech
2016-08-08 21:14           ` Leo Famulari
2016-08-09  9:05             ` Tomáš Čech [this message]
2016-08-08 21:10         ` [PATCHv2 1/2] gnu: bash-completion: Modify to modify-phases Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160809072653.qlyefumll3y3wowb@venom \
    --to=sleep_walker@gnu.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.