From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH v5 04/17] gnu: Add perl-net-dns-resolver-programmable.
Date: Mon, 8 Aug 2016 15:41:15 -0400
Message-ID: <20160808194115.GA18650@jasmine>
References: <20160728213833.22057-1-dannym@scratchpost.org>
	<20160728213833.22057-5-dannym@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48130)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bWqQT-000353-9E
	for guix-devel@gnu.org; Mon, 08 Aug 2016 15:41:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bWqQQ-0004D7-74
	for guix-devel@gnu.org; Mon, 08 Aug 2016 15:41:29 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:44315)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bWqQO-0004Af-TO
	for guix-devel@gnu.org; Mon, 08 Aug 2016 15:41:26 -0400
Content-Disposition: inline
In-Reply-To: <20160728213833.22057-5-dannym@scratchpost.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org

On Thu, Jul 28, 2016 at 11:38:20PM +0200, Danny Milosavljevic wrote:
> 
> gnu: Add perl-net-dns-resolver-programmable.
> 
> * gnu/packages/networking.scm (perl-net-dns-resolver-programmable): New variable.

I'm going through v5 of this patch series. This is the first patch I
have a question about.

> +(define-public perl-net-dns-resolver-programmable
> + (package
> +  (name "perl-net-dns-resolver-programmable")
> +  (version "v0.003")
> +  (source
> +    (origin
> +      (method url-fetch)
> +      (uri (string-append
> +             "mirror://cpan/authors/id/J/JM/JMEHNLE/net-dns-resolver-programmable/"
> +             "Net-DNS-Resolver-Programmable-" version ".tar.gz"))
> +      (sha256
> +        (base32
> +          "1v3nl2kaj4fs55n1617n53q8sa3mir06898vpy1rq98zjih24h4d"))
> +      (patches
> +       (list (origin
> +               (method url-fetch)
> +               (uri "https://rt.cpan.org/Public/Ticket/Attachment/1575108/841078/patch.txt")
> +               (sha256
> +                 (base32
> +                   "027fzq1dryqwhkprz4r32vj78qfdnx1mhjx6piag7p62p5npmdic")))))))

Can you send a comment explaining why we have to apply this patch? Its
URL does not enable me to "go back" to the relevant discussion and learn
the context or identity of the author.

Assuming we keep the upstream patch, I will download it and add it to
'gnu/packages/patches', and apply it using the method seen in the cpio
package definition. I can do that on my own, or you can submit a v6 of
this patch.