[PATCH] Add python-pythondialog

[PATCH] Add python-pythondialog

[ng0]

From 7439588d56d9c6935a4f88b46bc3b77a9f57565e Mon Sep 17 00:00:00 2001
From: ng0 <ng0@we.make.ritual.n0.is>
Date: Mon, 4 Jul 2016 16:53:06 +0000
Subject: [PATCH] gnu: Add python-pythondialog.

* gnu/packages/python.scm (python-pythondialog): New variable.
---
 gnu/packages/python.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index a85817d..bd4ce04 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -6699,6 +6699,41 @@ provide an easy to use, pythonic and comprehensive Python interface to dialog.
 This allows one to make simple text-mode user interfaces on Unix-like systems")
     (license lgpl2.1)))
 
+(define-public python-pythondialog
+  (package
+    (name "python-pythondialog")
+    (version "3.4.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "pythondialog" version))
+       (sha256
+        (base32
+         "1728ghsran47jczn9bhlnkvk5bvqmmbihabgif5h705b84r1272c"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'patch-path
+           (lambda* (#:key inputs #:allow-other-keys)
+             (let* ((dialog (assoc-ref inputs "dialog")))
+               ;; Since this library really wants to grovel the search path, we
+               ;; must hardcode dialog's store path into it.
+               (substitute* "dialog.py"
+                 (("os.getenv\\(\"PATH\", \":/bin:/usr/bin\"\\)")
+                  (string-append "os.getenv(\"PATH\")  + \":" dialog "/bin\"")))
+               #t))))
+       #:tests? #f)) ; no test suite
+    (propagated-inputs
+     `(("dialog" ,dialog)))
+    (home-page
+     "http://pythondialog.sourceforge.net/")
+    (synopsis
+     "A Python interface to the UNIX dialog utility and mostly-compatible programs")
+    (description
+     "A Python interface to the UNIX dialog utility and mostly-compatible programs")
+    (license lgpl2.1)))
+
 (define-public python-pyrfc3339
   (package
     (name "python-pyrfc3339")
-- 
2.9.0


-- 
♥Ⓐ  ng0
For non-prism friendly talk find me on http://www.psyced.org
SecuShare – http://secushare.org

Re: [PATCH] Add python-pythondialog

[Leo Famulari]

On Mon, Jul 04, 2016 at 05:05:07PM +0000, ng0 wrote:
> * gnu/packages/python.scm (python-pythondialog): New variable.

For those reading along, python2-pythondialog and python-pythondialog
are separate implementations with different source tarballs.  They are
maintained by the same group.

But, the package definitions are basically the same. The only
differences are the name, the source and Python version.

Should one of them inherit from the other, or should we maintain two
independent package definitions?

Re: [PATCH] Add python-pythondialog

[ng0]

Leo Famulari writes:

> On Mon, Jul 04, 2016 at 05:05:07PM +0000, ng0 wrote:
>> * gnu/packages/python.scm (python-pythondialog): New variable.
>
> For those reading along, python2-pythondialog and python-pythondialog
> are separate implementations with different source tarballs.  They are
> maintained by the same group.
>
> But, the package definitions are basically the same. The only
> differences are the name, the source and Python version.
>
> Should one of them inherit from the other, or should we maintain two
> independent package definitions?

If we inherit, we should let python2- inherit from python3.

I was not sure about the right way to process with this, so it
ended up in 2 packages.
-- 
♥Ⓐ  ng0
For non-prism friendly talk find me on http://www.psyced.org
SecuShare – http://secushare.org

Re: [PATCH] Add python-pythondialog

[ng0]

Hi,

ng0 <ng0@we.make.ritual.n0.is> writes:

> Leo Famulari writes:
>
>> On Mon, Jul 04, 2016 at 05:05:07PM +0000, ng0 wrote:
>>> * gnu/packages/python.scm (python-pythondialog): New variable.
>>
>> For those reading along, python2-pythondialog and python-pythondialog
>> are separate implementations with different source tarballs.  They are
>> maintained by the same group.
>>
>> But, the package definitions are basically the same. The only
>> differences are the name, the source and Python version.
>>
>> Should one of them inherit from the other, or should we maintain two
>> independent package definitions?
>
> If we inherit, we should let python2- inherit from python3.
>
> I was not sure about the right way to process with this, so it
> ended up in 2 packages.

There has been no update on this for 3 weeks.
Could someone look into this and reply?


Thanks.
-- 
♥Ⓐ  ng0
Current Keys: https://we.make.ritual.n0.is/ng0.txt
For non-prism friendly talk find me on http://www.psyced.org

Re: [PATCH] Add python-pythondialog

[Ben Woodcroft]

Hi there,

On 27/07/16 21:37, ng0 wrote:
> Hi,
>
> ng0 <ng0@we.make.ritual.n0.is> writes:
>
>> Leo Famulari writes:
>>
>>> On Mon, Jul 04, 2016 at 05:05:07PM +0000, ng0 wrote:
>>>> * gnu/packages/python.scm (python-pythondialog): New variable.
>>> For those reading along, python2-pythondialog and python-pythondialog
>>> are separate implementations with different source tarballs.  They are
>>> maintained by the same group.
>>>
>>> But, the package definitions are basically the same. The only
>>> differences are the name, the source and Python version.
>>>
>>> Should one of them inherit from the other, or should we maintain two
>>> independent package definitions?
>> If we inherit, we should let python2- inherit from python3.
>>
>> I was not sure about the right way to process with this, so it
>> ended up in 2 packages.
> There has been no update on this for 3 weeks.
> Could someone look into this and reply?

IMHO python2-pythondialog should inherit from python-dialog as you suggest.

Apologies for the slow review. Would you mind preparing another patch 
please?
Thanks,
ben

Re: [PATCH] Add python-pythondialog

[Vincent Legoll]

[-- Attachment #1: Type: text/plain, Size: 355 bytes --]

>> If we inherit, we should let python2- inherit from python3.
>>
>> I was not sure about the right way to process with this, so it
>> ended up in 2 packages.
>
> There has been no update on this for 3 weeks.
> Could someone look into this and reply?

Is that what you want ?
This is still untested though, but I'll try the 2 packages

-- 
Vincent Legoll

[-- Attachment #2: 0001-Add-python-pythondialog.patch --]
[-- Type: text/x-patch, Size: 2329 bytes --]

From 8b6becfd95235e1559cdb4a3760c5928d707e6cf Mon Sep 17 00:00:00 2001
From: Vincent Legoll <vincent.legoll@idgrilles.fr>
Date: Wed, 27 Jul 2016 14:28:06 +0200
Subject: [PATCH] Add python-pythondialog

Signed-off-by: Vincent Legoll <vincent.legoll@idgrilles.fr>
---
 gnu/packages/python.scm | 21 ++++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 80ff81f..533d731 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -6654,17 +6654,17 @@ facilities for defining, registering and looking up components.")
 (define-public python2-zope-component
   (package-with-python2 python-zope-component))
 
-(define-public python2-pythondialog
+(define-public python-pythondialog
   (package
-    (name "python2-pythondialog")
+    (name "python-pythondialog")
     (version "3.4.0")
     (source
      (origin
        (method url-fetch)
-       (uri (pypi-uri "python2-pythondialog" version))
+       (uri (pypi-uri "pythondialog" version))
        (sha256
         (base32
-         "0d8k7lxk50imdyx85lv8j98i4c93a71iwpapnl1506rpkbm9qvd9"))))
+         "1728ghsran47jczn9bhlnkvk5bvqmmbihabgif5h705b84r1272c"))))
     (build-system python-build-system)
     (arguments
      `(#:phases
@@ -6678,7 +6678,6 @@ facilities for defining, registering and looking up components.")
                  (("os.getenv\\(\"PATH\", \":/bin:/usr/bin\"\\)")
                   (string-append "os.getenv(\"PATH\")  + \":" dialog "/bin\"")))
                #t))))
-       #:python ,python-2
        #:tests? #f)) ; no test suite
     (propagated-inputs
      `(("dialog" ,dialog)))
@@ -6689,6 +6688,18 @@ provide an easy to use, pythonic and comprehensive Python interface to dialog.
 This allows one to make simple text-mode user interfaces on Unix-like systems")
     (license lgpl2.1)))
 
+(define-public python2-pythondialog
+  (package-with-python2
+    (package (inherit python-pythondialog)
+      (name "python2-pythondialog")
+      (source
+       (origin
+         (method url-fetch)
+         (uri (pypi-uri "python2-pythondialog" version))
+         (sha256
+          (base32
+           "0d8k7lxk50imdyx85lv8j98i4c93a71iwpapnl1506rpkbm9qvd9"))))))
+
 (define-public python-pyrfc3339
   (package
     (name "python-pyrfc3339")
-- 
1.9.1

Re: [PATCH] Add python-pythondialog

[ng0]

Hi,

thanks for working on this.

Vincent Legoll <vincent.legoll@gmail.com> writes:

>>> If we inherit, we should let python2- inherit from python3.
>>>
>>> I was not sure about the right way to process with this, so it
>>> ended up in 2 packages.
>>
>> There has been no update on this for 3 weeks.
>> Could someone look into this and reply?
>
> Is that what you want ?
> This is still untested though, but I'll try the 2 packages

I don't understand. Is this completely untested or have you tested this
before sending the patch?

> -- 
> Vincent Legoll
> From 8b6becfd95235e1559cdb4a3760c5928d707e6cf Mon Sep 17 00:00:00 2001
> From: Vincent Legoll <vincent.legoll@idgrilles.fr>
> Date: Wed, 27 Jul 2016 14:28:06 +0200
> Subject: [PATCH] Add python-pythondialog
>
> Signed-off-by: Vincent Legoll <vincent.legoll@idgrilles.fr>
> ---
>  gnu/packages/python.scm | 21 ++++++++++++++++-----
>  1 file changed, 16 insertions(+), 5 deletions(-)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 80ff81f..533d731 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -6654,17 +6654,17 @@ facilities for defining, registering and looking up components.")
>  (define-public python2-zope-component
>    (package-with-python2 python-zope-component))
>  
> -(define-public python2-pythondialog
> +(define-public python-pythondialog
>    (package
> -    (name "python2-pythondialog")
> +    (name "python-pythondialog")
>      (version "3.4.0")
>      (source
>       (origin
>         (method url-fetch)
> -       (uri (pypi-uri "python2-pythondialog" version))
> +       (uri (pypi-uri "pythondialog" version))
>         (sha256
>          (base32
> -         "0d8k7lxk50imdyx85lv8j98i4c93a71iwpapnl1506rpkbm9qvd9"))))
> +         "1728ghsran47jczn9bhlnkvk5bvqmmbihabgif5h705b84r1272c"))))
>      (build-system python-build-system)
>      (arguments
>       `(#:phases
> @@ -6678,7 +6678,6 @@ facilities for defining, registering and looking up components.")
>                   (("os.getenv\\(\"PATH\", \":/bin:/usr/bin\"\\)")
>                    (string-append "os.getenv(\"PATH\")  + \":" dialog "/bin\"")))
>                 #t))))
> -       #:python ,python-2
>         #:tests? #f)) ; no test suite
>      (propagated-inputs
>       `(("dialog" ,dialog)))
> @@ -6689,6 +6688,18 @@ provide an easy to use, pythonic and comprehensive Python interface to dialog.
>  This allows one to make simple text-mode user interfaces on Unix-like systems")
>      (license lgpl2.1)))
>  
> +(define-public python2-pythondialog
> +  (package-with-python2
> +    (package (inherit python-pythondialog)
> +      (name "python2-pythondialog")
> +      (source
> +       (origin
> +         (method url-fetch)
> +         (uri (pypi-uri "python2-pythondialog" version))
> +         (sha256
> +          (base32
> +           "0d8k7lxk50imdyx85lv8j98i4c93a71iwpapnl1506rpkbm9qvd9"))))))
> +
>  (define-public python-pyrfc3339
>    (package
>      (name "python-pyrfc3339")
> -- 
> 1.9.1
>

-- 
♥Ⓐ  ng0
Current Keys: https://we.make.ritual.n0.is/ng0.txt
For non-prism friendly talk find me on http://www.psyced.org

Re: [PATCH] Add python-pythondialog

[Vincent Legoll]

>> Is that what you want ?
>> This is still untested though, but I'll try the 2 packages
>
> I don't understand. Is this completely untested or have you tested this
> before sending the patch?

This patch is untested. I didn't manage to test it (see the other thread:
"guix package modif testing").

-- 
Vincent Legoll

Re: [PATCH] Add python-pythondialog

[Vincent Legoll]

And actually the patch is wrong, I think it's missing a closing paren
for python2-pythondialog...

-- 
Vincent Legoll

Re: [PATCH] Add python-pythondialog

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 702 bytes --]

On Thu, Jul 28, 2016 at 12:53:15PM +0200, Vincent Legoll wrote:
> And actually the patch is wrong, I think it's missing a closing paren
> for python2-pythondialog...

I re-wrote it using the 'python2-variant' system, as attached. Does it
work for you?

I'm not sure if that's the right approach, but the resulting package for
python2-pythondialog has the same result as before. What I mean is that
I was able to download a substitute from Hydra for it, even with this
new package definition.

Also, I noticed that the Python 3 and Python 2 versions of this software
tend to be released concurrently, so I made the Python 2 package take
the version of the Python 3 package. Do you think that will work?

[-- Attachment #2: 0001-gnu-Add-python-pythondialog.patch --]
[-- Type: text/x-diff, Size: 2756 bytes --]

From 50412a737f4e11f0c191fac3f755bab798da2846 Mon Sep 17 00:00:00 2001
From: Leo Famulari <leo@famulari.name>
Date: Tue, 2 Aug 2016 16:16:45 -0400
Subject: [PATCH] gnu: Add python-pythondialog.

* gnu/packages/python.scm (python-pythondialog): New variable.
(python2-pythondialog): Inherit from PYTHON-PYTHONDIALOG.

Co-authored-by: Vincent Legoll <vincent.legoll@idgrilles.fr>
---
 gnu/packages/python.scm | 24 ++++++++++++++++++------
 1 file changed, 18 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 5ba92b2..f1aa5b4 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -6680,17 +6680,17 @@ facilities for defining, registering and looking up components.")
 (define-public python2-zope-component
   (package-with-python2 python-zope-component))
 
-(define-public python2-pythondialog
+(define-public python-pythondialog
   (package
-    (name "python2-pythondialog")
+    (name "python-pythondialog")
     (version "3.4.0")
     (source
      (origin
        (method url-fetch)
-       (uri (pypi-uri "python2-pythondialog" version))
+       (uri (pypi-uri "pythondialog" version))
        (sha256
         (base32
-         "0d8k7lxk50imdyx85lv8j98i4c93a71iwpapnl1506rpkbm9qvd9"))))
+         "1728ghsran47jczn9bhlnkvk5bvqmmbihabgif5h705b84r1272c"))))
     (build-system python-build-system)
     (arguments
      `(#:phases
@@ -6704,7 +6704,6 @@ facilities for defining, registering and looking up components.")
                  (("os.getenv\\(\"PATH\", \":/bin:/usr/bin\"\\)")
                   (string-append "os.getenv(\"PATH\")  + \":" dialog "/bin\"")))
                #t))))
-       #:python ,python-2
        #:tests? #f)) ; no test suite
     (propagated-inputs
      `(("dialog" ,dialog)))
@@ -6713,7 +6712,20 @@ facilities for defining, registering and looking up components.")
     (description "A Python wrapper for the dialog utility.  Its purpose is to
 provide an easy to use, pythonic and comprehensive Python interface to dialog.
 This allows one to make simple text-mode user interfaces on Unix-like systems")
-    (license lgpl2.1)))
+    (license lgpl2.1)
+    (properties `((python2-variant . ,(delay python2-pythondialog))))))
+
+(define-public python2-pythondialog
+  (let ((base (package-with-python2 (strip-python2-variant python-pythondialog))))
+    (package
+      (inherit base)
+      (version (package-version python-pythondialog))
+      (source (origin
+                (method url-fetch)
+                (uri (pypi-uri "python2-pythondialog" version))
+                (sha256
+                 (base32
+                  "0d8k7lxk50imdyx85lv8j98i4c93a71iwpapnl1506rpkbm9qvd9")))))))
 
 (define-public python-pyrfc3339
   (package
-- 
2.9.2

Re: [PATCH] Add python-pythondialog

[ng0]

Leo Famulari <leo@famulari.name> writes:

> On Thu, Jul 28, 2016 at 12:53:15PM +0200, Vincent Legoll wrote:
>> And actually the patch is wrong, I think it's missing a closing paren
>> for python2-pythondialog...
>
> I re-wrote it using the 'python2-variant' system, as attached. Does it
> work for you?
>
> I'm not sure if that's the right approach, but the resulting package for
> python2-pythondialog has the same result as before. What I mean is that
> I was able to download a substitute from Hydra for it, even with this
> new package definition.
>
> Also, I noticed that the Python 3 and Python 2 versions of this software
> tend to be released concurrently, so I made the Python 2 package take
> the version of the Python 3 package. Do you think that will work?

Maybe.. I have no reference why I needed this in the first
place. PyBitmessage dependeny? I would say it works for me, but I don't
know exactly what the problem was outside of this thread.

> From 50412a737f4e11f0c191fac3f755bab798da2846 Mon Sep 17 00:00:00 2001
> From: Leo Famulari <leo@famulari.name>
> Date: Tue, 2 Aug 2016 16:16:45 -0400
> Subject: [PATCH] gnu: Add python-pythondialog.
>
> * gnu/packages/python.scm (python-pythondialog): New variable.
> (python2-pythondialog): Inherit from PYTHON-PYTHONDIALOG.
>
> Co-authored-by: Vincent Legoll <vincent.legoll@idgrilles.fr>
> ---
>  gnu/packages/python.scm | 24 ++++++++++++++++++------
>  1 file changed, 18 insertions(+), 6 deletions(-)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 5ba92b2..f1aa5b4 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -6680,17 +6680,17 @@ facilities for defining, registering and looking up components.")
>  (define-public python2-zope-component
>    (package-with-python2 python-zope-component))
>  
> -(define-public python2-pythondialog
> +(define-public python-pythondialog
>    (package
> -    (name "python2-pythondialog")
> +    (name "python-pythondialog")
>      (version "3.4.0")
>      (source
>       (origin
>         (method url-fetch)
> -       (uri (pypi-uri "python2-pythondialog" version))
> +       (uri (pypi-uri "pythondialog" version))
>         (sha256
>          (base32
> -         "0d8k7lxk50imdyx85lv8j98i4c93a71iwpapnl1506rpkbm9qvd9"))))
> +         "1728ghsran47jczn9bhlnkvk5bvqmmbihabgif5h705b84r1272c"))))
>      (build-system python-build-system)
>      (arguments
>       `(#:phases
> @@ -6704,7 +6704,6 @@ facilities for defining, registering and looking up components.")
>                   (("os.getenv\\(\"PATH\", \":/bin:/usr/bin\"\\)")
>                    (string-append "os.getenv(\"PATH\")  + \":" dialog "/bin\"")))
>                 #t))))
> -       #:python ,python-2
>         #:tests? #f)) ; no test suite
>      (propagated-inputs
>       `(("dialog" ,dialog)))
> @@ -6713,7 +6712,20 @@ facilities for defining, registering and looking up components.")
>      (description "A Python wrapper for the dialog utility.  Its purpose is to
>  provide an easy to use, pythonic and comprehensive Python interface to dialog.
>  This allows one to make simple text-mode user interfaces on Unix-like systems")
> -    (license lgpl2.1)))
> +    (license lgpl2.1)
> +    (properties `((python2-variant . ,(delay python2-pythondialog))))))
> +
> +(define-public python2-pythondialog
> +  (let ((base (package-with-python2 (strip-python2-variant python-pythondialog))))
> +    (package
> +      (inherit base)
> +      (version (package-version python-pythondialog))
> +      (source (origin
> +                (method url-fetch)
> +                (uri (pypi-uri "python2-pythondialog" version))
> +                (sha256
> +                 (base32
> +                  "0d8k7lxk50imdyx85lv8j98i4c93a71iwpapnl1506rpkbm9qvd9")))))))
>  
>  (define-public python-pyrfc3339
>    (package
> -- 
> 2.9.2
>

-- 
♥Ⓐ  ng0
Current Keys: https://we.make.ritual.n0.is/ng0.txt
For non-prism friendly talk find me on http://www.psyced.org

Re: [PATCH] Add python-pythondialog

[Leo Famulari]

On Thu, Aug 04, 2016 at 08:16:42AM +0000, ng0 wrote:
> Leo Famulari <leo@famulari.name> writes:
> 
> > On Thu, Jul 28, 2016 at 12:53:15PM +0200, Vincent Legoll wrote:
> >> And actually the patch is wrong, I think it's missing a closing paren
> >> for python2-pythondialog...
> >
> > I re-wrote it using the 'python2-variant' system, as attached. Does it
> > work for you?
> >
> > I'm not sure if that's the right approach, but the resulting package for
> > python2-pythondialog has the same result as before. What I mean is that
> > I was able to download a substitute from Hydra for it, even with this
> > new package definition.
> >
> > Also, I noticed that the Python 3 and Python 2 versions of this software
> > tend to be released concurrently, so I made the Python 2 package take
> > the version of the Python 3 package. Do you think that will work?
> 
> Maybe.. I have no reference why I needed this in the first
> place. PyBitmessage dependeny? I would say it works for me, but I don't
> know exactly what the problem was outside of this thread.

Okay, well I just pushed it as 1ae44b802 :) So we have it if we need it.