[PATCH] gnu: Add stress-make.

[PATCH] gnu: Add stress-make.

[Eric Bavier]

[-- Attachment #1: Type: text/plain, Size: 137 bytes --]

Hello Guix,

I'm mostly looking for a second-opinion on the license of this package.  
Other comments welcome too, of course.

-- 
`~Eric

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-stress-make.patch --]
[-- Type: text/x-diff; name=0001-gnu-Add-stress-make.patch, Size: 3861 bytes --]

From c9ead7f89f63c2d5b238f7bf9db46138bfeb304e Mon Sep 17 00:00:00 2001
From: Eric Bavier <bavier@member.fsf.org>
Date: Tue, 2 Aug 2016 11:49:24 -0500
Subject: [PATCH] gnu: Add stress-make.

* gnu/packages/debug.scm (stress-make): New variable.
---
 gnu/packages/debug.scm | 59 ++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 59 insertions(+)

diff --git a/gnu/packages/debug.scm b/gnu/packages/debug.scm
index 556a105..1179063 100644
--- a/gnu/packages/debug.scm
+++ b/gnu/packages/debug.scm
@@ -20,10 +20,14 @@
   #:use-module (guix packages)
   #:use-module (guix licenses)
   #:use-module (guix download)
+  #:use-module (guix git-download)
   #:use-module (guix utils)
   #:use-module (guix build-system gnu)
+  #:use-module (gnu packages autotools)
+  #:use-module (gnu packages base)
   #:use-module (gnu packages bash)
   #:use-module (gnu packages flex)
+  #:use-module (gnu packages golang)
   #:use-module (gnu packages indent)
   #:use-module (gnu packages llvm)
   #:use-module (gnu packages perl)
@@ -256,3 +260,58 @@ fuzzed code.  The compact synthesized corpora produced by the tool are also
 useful for seeding other, more labor- or resource-intensive testing regimes
 down the road.")
       (license asl2.0))))
+
+(define-public stress-make
+  (let ((commit "506e6cfd98d165f22bee91c408b7c20117a682c4")
+        (revision "0"))                 ;No official source distribution
+    (package
+      (name "stress-make")
+      (version (string-append "1.0-" revision "." (string-take commit 7)))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "git://github.com/losalamos/stress-make.git")
+               (commit commit)))
+         (file-name (string-append name "-" version "-checkout"))
+         (sha256
+          (base32
+           "1j330yqhc7plwin04qxbh8afpg5nfnw1xvnmh8rk6mmqg9w6ik70"))))
+      (build-system gnu-build-system)
+      (native-inputs
+       `(("autoconf" ,autoconf)
+         ("automake" ,automake)
+         ("go" ,go)))
+      (inputs
+       `(("make-src" ,(package-source gnu-make))))
+      (arguments
+       ;; stress-make's configure script insists on having a tarball and does
+       ;; not accept a directory name instead.  To let the gnu-build-system's
+       ;; patch-* phases work properly, we unpack the source first, then
+       ;; repack before the configure phase.
+       `(#:configure-flags '("--with-make-tar=./make.tar.xz")
+         #:phases
+         (modify-phases %standard-phases
+           (add-after 'unpack 'unpack-make
+             (lambda* (#:key inputs #:allow-other-keys)
+               (zero? (system* "tar" "xf" (assoc-ref inputs "make-src")))))
+           (add-before 'configure 'repack-make
+             (lambda _
+               (zero? (system* "tar" "cJf" "./make.tar.xz"
+                               (string-append "make-"
+                                              ,(package-version gnu-make))))))
+           (add-before 'configure 'bootstrap
+             (lambda _
+               (zero? (system* "autoreconf" "-vfi")))))))
+      (home-page "https://github.com/losalamos/stress-make")
+      (synopsis "Expose race conditions in Makefiles")
+      (description
+       "Stress Make is a customized GNU Make that explicitely managess the
+order in which concurrent jobs are run in order to provoke erroneous behavior
+into becoming manifest.  It can run jobs in the order they're launched, in
+backwards order, or in random order.  The thought is that if code builds
+correctly with Stress Make then it is likely that the @code{Makefile} contains
+no race conditions.")
+      ;; stress-make wrapper is under BSD-3-modifications-must-be-indicated,
+      ;; and patched GNU Make is under its own license.
+      (license (list bsd-3 (package-license gnu-make))))))
-- 
2.9.2

Re: [PATCH] gnu: Add stress-make.

[Leo Famulari]

On Tue, Aug 02, 2016 at 11:53:33AM -0500, Eric Bavier wrote:
> Hello Guix,
> 
> I'm mostly looking for a second-opinion on the license of this package.
> Other comments welcome too, of course.
> 
> * gnu/packages/debug.scm (stress-make): New variable.

> +      (version (string-append "1.0-" revision "." (string-take commit 7)))

It appears they never made a release, so I think we should use "0.0.0"
instead of "1.0".

> +         (uri (git-reference
> +               (url "git://github.com/losalamos/stress-make.git")

I think it's better to use the HTTPS protocol instead of the Git
protocol, unless there is some reason not to. What do you think?

https://git-scm.com/book/en/v2/Git-on-the-Server-The-Protocols#The-Git-Protocol

> +      (inputs
> +       `(("make-src" ,(package-source gnu-make))))

How about "make-source", since we seem to shun abbreviations?

> +      (arguments
> +       ;; stress-make's configure script insists on having a tarball and does
> +       ;; not accept a directory name instead.  To let the gnu-build-system's
> +       ;; patch-* phases work properly, we unpack the source first, then
> +       ;; repack before the configure phase.

o_O

> +      ;; stress-make wrapper is under BSD-3-modifications-must-be-indicated,
> +      ;; and patched GNU Make is under its own license.
> +      (license (list bsd-3 (package-license gnu-make))))))

Perhaps we should call it non-copyleft instead of bsd-3?

Re: [PATCH] gnu: Add stress-make.

[Eric Bavier]

On Sat, 6 Aug 2016 21:59:16 -0400
Leo Famulari <leo@famulari.name> wrote:

> On Tue, Aug 02, 2016 at 11:53:33AM -0500, Eric Bavier wrote:
> > Hello Guix,
> > 
> > I'm mostly looking for a second-opinion on the license of this package.
> > Other comments welcome too, of course.
> > 
> > * gnu/packages/debug.scm (stress-make): New variable.  
> 
> > +      (version (string-append "1.0-" revision "." (string-take commit 7)))  
> 
> It appears they never made a release, so I think we should use "0.0.0"
> instead of "1.0".

I used "1.0" because that's the version number in configure.ac.

> 
> > +         (uri (git-reference
> > +               (url "git://github.com/losalamos/stress-make.git")  
> 
> I think it's better to use the HTTPS protocol instead of the Git
> protocol, unless there is some reason not to. What do you think?
> 
> https://git-scm.com/book/en/v2/Git-on-the-Server-The-Protocols#The-Git-Protocol

OK, sounds good.

> 
> > +      (inputs
> > +       `(("make-src" ,(package-source gnu-make))))  
> 
> How about "make-source", since we seem to shun abbreviations?

Right.

> 
> > +      (arguments
> > +       ;; stress-make's configure script insists on having a tarball and does
> > +       ;; not accept a directory name instead.  To let the gnu-build-system's
> > +       ;; patch-* phases work properly, we unpack the source first, then
> > +       ;; repack before the configure phase.  
> 
> o_O

Yeah, it's a bit weird.

> 
> > +      ;; stress-make wrapper is under BSD-3-modifications-must-be-indicated,
> > +      ;; and patched GNU Make is under its own license.
> > +      (license (list bsd-3 (package-license gnu-make))))))  
> 
> Perhaps we should call it non-copyleft instead of bsd-3?

That seems more appropriate, yes.

Thanks for the review,
`~Eric