From: Leo Famulari <leo@famulari.name>
To: Andreas Enge <andreas@enge.fr>
Cc: guix-devel@gnu.org
Subject: Re: isnan, isinf in ldc; Was: Re: Release imminent
Date: Wed, 3 Aug 2016 13:03:41 -0400 [thread overview]
Message-ID: <20160803170341.GA5010@jasmine> (raw)
In-Reply-To: <20160803091234.GA3172@solar>
On Wed, Aug 03, 2016 at 11:12:34AM +0200, Andreas Enge wrote:
> Hi Danny,
>
> On Wed, Aug 03, 2016 at 09:51:10AM +0200, Danny Milosavljevic wrote:
> > ldc fails because they do
> > ::isnan
> > which is a bad idea if isnan is a C macro (which it usually isn't - but hey O_o). I've substituted
> > isnan
> > for it and this part then compiles fine.
> > This fix is not safe in general because if there's a method called isnan in scope, it will use that. In the ldc case, they've named the method "isNan" - so it's fine.
>
> did you forget to add a patch?
>
> Anyway, they made a release 1.0.0. Maybe it would be preferable to try
> an update of the package first, in case the problem is already solved
> on their side?
I prefer this approach. Always try to take upstream's solution :)
next prev parent reply other threads:[~2016-08-03 17:04 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-22 20:59 core-updates, next release, and all that Ludovic Courtès
2016-07-22 21:46 ` Leo Famulari
2016-07-22 21:59 ` Leo Famulari
2016-07-23 10:39 ` Ludovic Courtès
2016-07-23 11:22 ` Andreas Enge
2016-07-24 16:04 ` Andreas Enge
2016-07-24 16:48 ` Andreas Enge
2016-07-25 7:51 ` Andreas Enge
2016-07-25 16:30 ` Leo Famulari
2016-07-25 18:40 ` Andreas Enge
2016-07-25 20:03 ` Andreas Enge
2016-07-25 8:07 ` Ludovic Courtès
2016-07-24 16:59 ` Leo Famulari
2016-07-24 17:44 ` Andreas Enge
2016-07-25 22:46 ` Ludovic Courtès
2016-07-26 21:36 ` Andreas Enge
2016-07-27 10:44 ` Andreas Enge
2016-07-27 16:27 ` Andreas Enge
2016-07-27 18:28 ` Andreas Enge
2016-07-27 22:08 ` Ludovic Courtès
2016-07-27 23:10 ` Ludovic Courtès
2016-07-28 8:20 ` Andreas Enge
2016-07-28 8:24 ` Andreas Enge
2016-07-28 8:27 ` Andreas Enge
2016-07-28 9:31 ` Andreas Enge
2016-07-28 10:21 ` Ben Woodcroft
2016-07-28 10:34 ` Andreas Enge
2016-07-28 11:42 ` Ben Woodcroft
2016-08-31 19:33 ` Ricardo Wurmus
2016-09-01 4:41 ` Ben Woodcroft
2016-07-22 22:03 ` Leo Famulari
2016-07-22 22:06 ` Andreas Enge
2016-07-22 22:29 ` Leo Famulari
2016-07-22 22:46 ` ng0
2016-07-22 22:49 ` Leo Famulari
2016-07-22 23:00 ` Leo Famulari
2016-07-22 23:25 ` Andreas Enge
2016-07-23 0:16 ` ng0
2016-08-01 21:52 ` Release imminent Ludovic Courtès
2016-08-02 8:46 ` Andreas Enge
2016-08-03 7:51 ` isnan, isinf in ldc; Was: " Danny Milosavljevic
2016-08-03 9:12 ` Andreas Enge
2016-08-03 17:03 ` Leo Famulari [this message]
2016-08-03 17:14 ` Roel Janssen
2016-08-03 20:11 ` Pjotr Prins
2016-08-03 20:42 ` Andreas Enge
2016-08-03 9:20 ` [PATCH 0/3] Fix ldc Danny Milosavljevic
2016-08-03 9:20 ` [PATCH 1/3] gnu: ldc: make isnan and isinf work Danny Milosavljevic
2016-08-03 9:20 ` [PATCH 2/3] gnu: Add python-lit, python2-lit Danny Milosavljevic
2016-08-03 9:20 ` [PATCH 3/3] gnu: ldc: Update to 0.17.1 Danny Milosavljevic
2016-08-08 17:06 ` [PATCH 0/3] Fix ldc Danny Milosavljevic
2016-08-08 20:21 ` Roel Janssen
2016-08-29 15:39 ` Ludovic Courtès
2016-08-30 6:07 ` [PATCH v2 " Danny Milosavljevic
2016-08-30 6:07 ` [PATCH v2 1/3] gnu: ldc: make isnan and isinf work Danny Milosavljevic
2016-08-30 6:07 ` [PATCH v2 2/3] gnu: Add python-lit, python2-lit Danny Milosavljevic
2016-08-30 6:07 ` [PATCH v2 3/3] gnu: update ldc to 0.17.1 Danny Milosavljevic
2016-08-30 16:51 ` [PATCH v3 0/3] Fix ldc Danny Milosavljevic
2016-08-30 16:51 ` [PATCH v3 1/3] gnu: ldc: make isnan and isinf work Danny Milosavljevic
2016-08-30 16:51 ` [PATCH v3 2/3] gnu: Add python-lit, python2-lit Danny Milosavljevic
2016-08-31 18:09 ` Leo Famulari
2016-09-13 10:04 ` Danny Milosavljevic
2016-08-30 16:52 ` [PATCH v3 3/3] gnu: update ldc to 0.17.1 Danny Milosavljevic
2016-08-31 18:11 ` Leo Famulari
2016-09-06 10:41 ` [PATCH v3 0/3] Fix ldc Roel Janssen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160803170341.GA5010@jasmine \
--to=leo@famulari.name \
--cc=andreas@enge.fr \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.