From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andreas Enge <andreas@enge.fr>
Subject: Re: [PATCH] gnu: Add ircii.
Date: Tue, 2 Aug 2016 09:58:34 +0200
Message-ID: <20160802075834.GB1957@solar>
References: <87fuqoe10m.fsf@we.make.ritual.n0.is>
	<20160802005413.GB15847@jasmine>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53499)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1bUUb5-0006eB-BF
	for guix-devel@gnu.org; Tue, 02 Aug 2016 03:58:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1bUUb0-0003dL-FC
	for guix-devel@gnu.org; Tue, 02 Aug 2016 03:58:42 -0400
Received: from mailrelay6.public.one.com ([91.198.169.200]:51701)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1bUUb0-0003co-3X
	for guix-devel@gnu.org; Tue, 02 Aug 2016 03:58:38 -0400
Content-Disposition: inline
In-Reply-To: <20160802005413.GB15847@jasmine>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org

On Mon, Aug 01, 2016 at 08:54:13PM -0400, Leo Famulari wrote:
> > +             (snippet
> > +              '(begin
> > +                 (substitute* "bsdinstall"
> > +                   (("/bin/strip") "strip")
> > +                   (("/bin/cp") "cp")
> > +                   (("/bin/chmod") "chmod")
> > +                   (("/etc/chown") "chown")
> > +                   (("/bin/chgrp") "chgrp")
> > +                   (("/bin/mkdir") "mkdir")
> > +                   (("/bin/rm") "rm")
> > +                   (("/bin/mv") "mv"))))))
> Does anyone else think we should put this origin snippet in a build phase
> instead? Or, should we leave it in the origin, where it will be applied
> to the source code provided by `guix build --source ircii`?

I think it would be more in line with our usual practices to have it in
a build phase, indeed. Snippets are rather used to remove non-free code
or bundled software.

Andreas