From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Enge Subject: Re: [PATCH 1/8] gnu: qt: Update to 5.6.1-1. Date: Sat, 30 Jul 2016 10:57:41 +0200 Message-ID: <20160730085741.GC23346@solar> References: <20160729082357.17501-1-david@craven.ch> <87lh0kxncf.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bTQ5f-00065V-4a for guix-devel@gnu.org; Sat, 30 Jul 2016 04:57:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bTQ5b-00040L-1l for guix-devel@gnu.org; Sat, 30 Jul 2016 04:57:50 -0400 Received: from mailrelay1.public.one.com ([91.198.169.124]:52860) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bTQ5a-00040C-LI for guix-devel@gnu.org; Sat, 30 Jul 2016 04:57:46 -0400 Content-Disposition: inline In-Reply-To: <87lh0kxncf.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?iso-8859-15?Q?Court=E8s?= Cc: guix-devel@gnu.org, David Craven On Fri, Jul 29, 2016 at 09:20:48PM +0200, Ludovic Courtès wrote: > > + (modify-phases %standard-phases > > + (add-after 'configure 'patch-bin-sh > > + (lambda _ > > + (substitute* '("qtbase/config.status" > > + "qtbase/configure" > > + "qtbase/mkspecs/features/qt_functions.prf" > > + "qtbase/qmake/library/qmakebuiltins.cpp") > > + (("/bin/sh") (which "sh"))) > ^ > This should be aligned with the ‘u’ of ‘substitute*’. I need indentation help again! I thought we either indented like this: (function 1 2 3) with the first argument following the procedure name; or like this: (function 1 2 3) with the first argument on the next line. So I misunderstood, and it is actually (function 1 2 3) in the first case? Andreas