From: Leo Famulari <leo@famulari.name>
To: Ben Woodcroft <donttrustben@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 22/22] gnu: Add roary.
Date: Fri, 29 Jul 2016 17:07:46 -0400 [thread overview]
Message-ID: <20160729210746.GA16455@jasmine> (raw)
In-Reply-To: <f751ce95188737aa9050e3fbaa4355ba586a19e5.1469622379.git.donttrustben@gmail.com>
On Wed, Jul 27, 2016 at 10:54:23PM +1000, Ben Woodcroft wrote:
> * gnu/packages/bioinformatics.scm (roary): New variable.
Wow, this is a complicated package! Thanks for doing the work!
> + `(#:phases
> + (modify-phases %standard-phases
> + (add-after 'unpack 'delete-bundled-binaries
> + (lambda _
> + (delete-file-recursively "binaries")
> + #t))
The only thing I would suggest you change is to delete these binaries in
an origin snippet. The effect would be that the binaries would not be
provided by `guix build --source roary`.
If the binaries aren't provided with their source code, then I think
this change is required.
next prev parent reply other threads:[~2016-07-29 21:08 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-27 12:54 PATCH [0/22]: Add roary Ben Woodcroft
2016-07-27 12:54 ` [PATCH 01/22] gnu: parallel: Use full paths for executables Ben Woodcroft
2016-07-27 12:54 ` [PATCH 02/22] gnu: Add perl-xml-writer Ben Woodcroft
2016-07-27 12:54 ` [PATCH 03/22] gnu: Add perl-parse-yapp Ben Woodcroft
2016-07-27 12:54 ` [PATCH 04/22] gnu: Add perl-graph Ben Woodcroft
2016-07-27 12:54 ` [PATCH 05/22] gnu: Add perl-graph-readwrite Ben Woodcroft
2016-07-27 12:54 ` [PATCH 06/22] gnu: Add perl-log-log4perl Ben Woodcroft
2016-07-27 12:54 ` [PATCH 07/22] gnu: Add perl-file-slurper Ben Woodcroft
2016-07-27 12:54 ` [PATCH 08/22] gnu: Add perl-file-path Ben Woodcroft
2016-07-27 12:54 ` [PATCH 09/22] gnu: Add perl-file-grep Ben Woodcroft
2016-07-27 12:54 ` [PATCH 10/22] gnu: Add perl-array-utils Ben Woodcroft
2016-07-27 12:54 ` [PATCH 11/22] gnu: Add perl-test-files Ben Woodcroft
2016-07-27 12:54 ` [PATCH 12/22] gnu: Add perl-env-path Ben Woodcroft
2016-07-27 12:54 ` [PATCH 13/22] gnu: Add mcl Ben Woodcroft
2016-07-28 22:20 ` Leo Famulari
2016-07-27 12:54 ` [PATCH 14/22] gnu: Add bpp-core Ben Woodcroft
2016-07-27 12:54 ` [PATCH 15/22] gnu: Add bpp-seq Ben Woodcroft
2016-07-27 12:54 ` [PATCH 16/22] gnu: Add bpp-phyl Ben Woodcroft
2016-07-27 12:54 ` [PATCH 17/22] gnu: Add bpp-popgen Ben Woodcroft
2016-07-27 12:54 ` [PATCH 18/22] gnu: Add bppsuite Ben Woodcroft
2016-07-27 12:54 ` [PATCH 19/22] gnu: Add exonerate Ben Woodcroft
2016-07-28 22:22 ` Leo Famulari
2016-07-27 12:54 ` [PATCH 20/22] gnu: Add prank Ben Woodcroft
2016-07-27 12:54 ` [PATCH 21/22] gnu: Add raxml Ben Woodcroft
2016-07-27 12:54 ` [PATCH 22/22] gnu: Add roary Ben Woodcroft
2016-07-29 21:07 ` Leo Famulari [this message]
2016-07-28 22:31 ` [PATCH 01/22] gnu: parallel: Use full paths for executables Leo Famulari
2016-07-31 11:26 ` PATCH [0/22]: Add roary Ludovic Courtès
2016-08-08 12:16 ` Ben Woodcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160729210746.GA16455@jasmine \
--to=leo@famulari.name \
--cc=donttrustben@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.