From mboxrd@z Thu Jan 1 00:00:00 1970 From: Danny Milosavljevic Subject: Re: guix bootloader selection - wip patch Date: Fri, 29 Jul 2016 10:21:55 +0200 Message-ID: <20160729102155.26d0083d@scratchpost.org> References: <20160721223501.3a989d55@scratchpost.org> <877fc815wg.fsf@gnu.org> <20160727113248.2ee9087c@scratchpost.org> <20160727222924.07209026@scratchpost.org> <874m7aj601.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54700) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bT33U-0004m7-Ta for guix-devel@gnu.org; Fri, 29 Jul 2016 04:22:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bT33Q-0001kL-Kq for guix-devel@gnu.org; Fri, 29 Jul 2016 04:22:03 -0400 In-Reply-To: <874m7aj601.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?UTF-8?B?Q291cnTDqHM=?= Cc: guix-devel > Really, installing U-Boot is as simple as this? If it is, that=E2=80=99s > perfect. :-) Nope, it's just a placeholder :) But ideally U-Boot would provide something like that. I'm looking into writing u-boot-install.c and maybe contributing it to U-Bo= ot - let's see how bad it is. Right now checking whether libparted allows you to reduce the size of the G= PT to max. 56 entries... > I would write it as: >=20 > (match bootloader-configuration > ((? grub-configuration? config) > (grub-configuration-device config)) > ((? u-boot-configuration? config) > (u-boot-configuration-device config))) > which does the same thing but allows us to avoid exporting > and (better to keep them > private so that external code doesn=E2=80=99t rely on the structure layou= t.) Yeah, I changed it to that now and removed the exports. > I see three separate things here: >=20 > 1. Replacing =E2=80=9Cgrub=E2=80=9D by =E2=80=9Cbootloader=E2=80=9D in = the API (cosmetic change); >=20 > 2. Adding the build-side code to install U-Boot; >=20 > 3. Adding the host-side code to handle and do > the right thing. >=20 > To facilitate review, could you separate these three things? As far as they are in different files, yes. Which part is the build-side, w= hich part is the host-side? > Also, not critical, but could you send patches as =E2=80=98text/x-patch= =E2=80=99 MIME > attachments so that my email client can perform color highlighting? :-) Okay.