From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH 01/22] gnu: parallel: Use full paths for executables. Date: Thu, 28 Jul 2016 18:31:14 -0400 Message-ID: <20160728223114.GC15649@jasmine> References: <20160727125423.7768-1-donttrustben@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48168) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bStpw-0001i2-K6 for guix-devel@gnu.org; Thu, 28 Jul 2016 18:31:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bStpt-0001Di-JK for guix-devel@gnu.org; Thu, 28 Jul 2016 18:31:28 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:53462) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bStps-0001Ba-Ci for guix-devel@gnu.org; Thu, 28 Jul 2016 18:31:25 -0400 Content-Disposition: inline In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ben Woodcroft Cc: guix-devel@gnu.org On Wed, Jul 27, 2016 at 10:54:02PM +1000, Ben Woodcroft wrote: > * gnu/packages/parallel.scm (parallel)[inputs]: Add procps. > [arguments]: New field. > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'patch-bin-sh > + (lambda _ > + (for-each > + (lambda (file) > + (substitute* file > + ;; Patch hard coded '/bin/sh' in the lin ending in: > + ;; $Global::shell = $ENV{'PARALLEL_SHELL'} || > + ;; parent_shell($$) || $ENV{'SHELL'} || "/bin/sh"; > + (("/bin/sh\\\";\n$") (string-append (which "sh") "\";\n")) > + ;; Patch call to 'ps' and 'perl' commands. > + ((" ps ") (string-append " " (which "ps") " ")) > + ((" perl -") (string-append " " (which "perl") " -")))) > + (list "src/parallel" "src/sem")))) > + (add-after 'install 'post-install-test > + (lambda* (#:key outputs #:allow-other-keys) > + (zero? (system* (string-append > + (assoc-ref outputs "out") "/bin/parallel") > + "echo" > + ":::" "1" "2" "3"))))))) Do we need the 'post-install-test' phase, or was it left in by accident after debugging?