From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?VG9tw6HFoSDEjGVjaA==?= Subject: Re: [WIP PATCH] linux-initrd: Allow own set of kernel modules. Date: Thu, 28 Jul 2016 15:35:03 +0200 Message-ID: <20160728133503.cseag7mg5f6wk7i4@crashnator.suse.cz> References: <20160728104224.10523-1-sleep_walker@gnu.org> <8737mtj4kh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nbq6l23a3tvyzqzo" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52461) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSlSz-0006AZ-1X for guix-devel@gnu.org; Thu, 28 Jul 2016 09:35:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bSlSu-0001Md-16 for guix-devel@gnu.org; Thu, 28 Jul 2016 09:35:11 -0400 Received: from mx2.suse.de ([195.135.220.15]:39765) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSlSt-0001J4-Os for guix-devel@gnu.org; Thu, 28 Jul 2016 09:35:07 -0400 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id A267BABA6 for ; Thu, 28 Jul 2016 13:35:04 +0000 (UTC) Content-Disposition: inline In-Reply-To: <8737mtj4kh.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org --nbq6l23a3tvyzqzo Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 28, 2016 at 03:05:34PM +0200, Ludovic Court=C3=A8s wrote: >Tom=C3=A1=C5=A1 =C4=8Cech skribis: > >> * gnu/system/linux-initrd.scm(base-initrd): Add `linux-modules' >> parameter. Rename former `linux-modules' to >> `default-linux-modules'. Introduce used-linux-modules to make the code >> more readable. >> --- >> gnu/system/linux-initrd.scm | 12 +++++++++--- >> 1 file changed, 9 insertions(+), 3 deletions(-) >> >> diff --git a/gnu/system/linux-initrd.scm b/gnu/system/linux-initrd.scm >> index bbaa5c0..4934c92 100644 >> --- a/gnu/system/linux-initrd.scm >> +++ b/gnu/system/linux-initrd.scm >> @@ -138,6 +138,7 @@ MODULES and taken from LINUX." >> qemu-networking? >> (virtio? #t) >> volatile-root? >> + (linux-modules #f) >> (extra-modules '())) >> "Return a monadic derivation that builds a generic initrd, with kernel >> modules taken from LINUX. FILE-SYSTEMS is a list of file-systems to be > >It seems to serve the same purpose as #:extra-modules, no? > > https://www.gnu.org/software/guix/manual/html_node/Initial-RAM-Disk.html It gives me full control over the modules and not just appending to default= set. #f --> default-kernel-modules (as it is now) '(some extraordinary special modules for other purpose) --> it will use t= his set '() --> it will use no module at all (my typical usecase) But yes, it makes `extra-modules' useless. I'd like to find a way, how to make default-kernel-modules available as some lazy evaluated list (because what will go there is decided when base-initrd is evaluated). This is one of the steps for user defined kernel (besides specifying kernel configuration) and I'm using it already. If you're not against such change, it also would need to adjust documentation (will do in next round). S_W --nbq6l23a3tvyzqzo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXmgn6AAoJEEoj40+gM0NtfXwP/0feaYieQWrPitnkfRAPL0rE shcxMtk59xnTMQ1tFkNpk57mucE2T75qKUYaKPG2zvqm0cJvyS7h5od+nirCxHtX ws7amX409xVbc7sHyDQfZcUBUAcBj6JVwKRYnXgsJDm43ZbdzGgLlh4ejWopCnTi JJQEnAnbJSlzmamDZD30QMWRbR8whAU4hBax0cI5/4bjtbANxgt09k0XmZ5huiCC tGHMo+bMEpdxph1SYDbiE9t+FDLvCR668xnUlhWWMEUhivIrrgCwZoQ2+323HCpt kiLLmeE4TUdfA5TJLxdaKDAJZjhX2mVsA1dwQA2aQjmt9vjpMtzfzqSzKr04MvkP bqDxa5lQqeEF9k52x8G9iDCCobuwsVnXKe1NBX/mcUE5wFe34z7rzVA3pC004Eq+ LFR8NGKWejxveP/z8ZOeEJSKcUFOphUpsK+5HFfGxqKAOrWq+IkG4C2io5mS5aaS vqDJ0/DGx75dM6W8YIKZU6XIV1DB9OnUM7t7IcnWmcZrne0ATncCGy3bGVML1TaW ANQKNrODKU98dDLiYL5UY9t/jribNl0Rl6uqalDpeohBUj2rGgnOZaqjepLtPTjg N5X8Rzar5b3TLPIbp9ecIKe7MIKdeaFRveWHQCz473MgZxnbH8Ny/ecbqasTV1V7 DF5TkJM4kgfqw314/5yQ =TgML -----END PGP SIGNATURE----- --nbq6l23a3tvyzqzo--