From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] gnu: Add perceptualdiff. Date: Sun, 24 Jul 2016 17:44:38 -0400 Message-ID: <20160724214438.GA2122@jasmine> References: <20160724034325.16952-1-me@tobias.gr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54539) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bRRCh-0006EA-Ah for guix-devel@gnu.org; Sun, 24 Jul 2016 17:44:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bRRCb-0004Zo-B2 for guix-devel@gnu.org; Sun, 24 Jul 2016 17:44:54 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:47186) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bRRCZ-0004Xu-T3 for guix-devel@gnu.org; Sun, 24 Jul 2016 17:44:49 -0400 Content-Disposition: inline In-Reply-To: <20160724034325.16952-1-me@tobias.gr> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Tobias Geerinckx-Rice Cc: guix-devel@gnu.org On Sun, Jul 24, 2016 at 05:43:25AM +0200, Tobias Geerinckx-Rice wrote: > * gnu/packages/image.scm (perceptualdiff): New variable. LGTM > + (arguments > + '(#:phases (modify-phases %standard-phases > + (add-after 'unpack 'fix-tests > + ;; cmake-build-system uses a build/ directory outside > + ;; of the source tree, one level higher than expected > + (lambda _ > + (substitute* "test/run_tests.bash" > + (("../build") "../../build"))))))) Do you think this is a bug that should be reported?