From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 6/7] gnu: Add spice-vdagent.
Date: Sat, 23 Jul 2016 18:40:24 -0400
Message-ID: <20160723224024.GA23753@jasmine>
References: <20160723131859.13525-1-david@craven.ch>
	<20160723131859.13525-6-david@craven.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60115)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bR5b4-0005YF-Lv
	for guix-devel@gnu.org; Sat, 23 Jul 2016 18:40:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bR5az-0008QN-Ji
	for guix-devel@gnu.org; Sat, 23 Jul 2016 18:40:38 -0400
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:47562)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bR5az-0008NA-9k
	for guix-devel@gnu.org; Sat, 23 Jul 2016 18:40:33 -0400
Content-Disposition: inline
In-Reply-To: <20160723131859.13525-6-david@craven.ch>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org

On Sat, Jul 23, 2016 at 03:18:58PM +0200, David Craven wrote:
> * gnu/packages/spice.scm: Add it.
> * gnu/packages/patches/spice-vdagent-localstatedir.patch: Add it.

I will move this patch into a build phase, with a substitution, if you
don't mind. That way, it will not affect `guix build --source
spice-vdagent`, and will be right there in the package definition for
future readers.

> +(define-public spice-vdagent

> +    (inputs
> +      `(("alsa-lib" ,alsa-lib)
> +        ("dbus" ,dbus)
> +        ("glib" ,glib)
> +        ("libpciaccess" ,libpciaccess)
> +        ("libx11" ,libx11)
> +        ("libxext" ,libxext)
> +        ("libxfixes" ,libxfixes)
> +        ("libxinerama" ,libxinerama)
> +        ("libxrandr" ,libxrandr)
> +        ("spice-protocol" ,spice-protocol)))

The built output lacks a reference to spice-protocol. Do you think it's
a problem if spice-vdagent can't find spice-protocol at run-time?

> +    (license license:gpl2)))

This package appears to be gpl3+.