From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] gnu: Add mono. Date: Fri, 22 Jul 2016 11:55:56 -0400 Message-ID: <20160722155556.GB13704@jasmine> References: <87zipidely.fsf@gnu.org> <87vb06deej.fsf@gnu.org> <87r3aud7dw.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44467) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQcoE-0004CV-C7 for guix-devel@gnu.org; Fri, 22 Jul 2016 11:56:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQcoA-0001RB-T3 for guix-devel@gnu.org; Fri, 22 Jul 2016 11:56:18 -0400 Content-Disposition: inline In-Reply-To: <87r3aud7dw.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Jan Nieuwenhuizen Cc: guix-devel@gnu.org On Fri, Jul 15, 2016 at 09:32:43PM +0200, Jan Nieuwenhuizen wrote: > Subject: [PATCH] gnu: Add mono. > > * gnu/packages/mono.scm: New file. > * gnu/packages/local.mk (GNU_SYSTEM_MODULES): Add it. Thank you! I assume this mono is working for you? I'm wondering if the problems requiring skipped tests hide a larger problem or if it's benign. Do you know if mono is supposed to work on all of our architectures? Or, should we disable it on some of them? > + (snippet Did you try doing these substitutions in a build phase? The origin snippet affects what you get from `guix build --source mono`, so we tend to reserve it for removing non-free components, so that we don't distribute things that we don't have a right to distribute. > + ;; tests fail, trying to access $HOME > + (substitute* "mcs/class/Makefile" > + (("^include ../build/rules.make" all) > + (string-append > + all > + "\nrun-test-recursive:\n\t@echo skipping tests\n"))) After moving this into a build phase, there could be a prior phase 'set-env' that just sets $HOME to '/tmp'. Can you check if that works? > + (build-system gnu-build-system) > + (native-inputs > + `(("gettext" ,gnu-gettext) > + ("glib" ,glib) I notice many uses of glib:bin rather than the full glib output. But, to be honest, I don't understand the distinction ;) > + ;; these 3 tests fail > + `(#:make-flags > + `(,(string-append "PLATFORM_DISABLED_TESTS=" > + " appdomain-unload.exe" > + " delegate2.exe" > + " finally_guard.exe" > + " remoting4.exe")) 4 tests? > + #:parallel-tests? #f)) Parallel testing is not supported? Let's add a comment. > + (home-page "http://mono-project.org/") s/org/com/