From: Leo Famulari <leo@famulari.name>
To: Eric Bavier <ericbavier@openmailbox.org>
Cc: 24026-done@debbugs.gnu.org
Subject: bug#24026: librecad and dealii depend on relocated muparser source code repo
Date: Thu, 21 Jul 2016 18:26:16 -0400 [thread overview]
Message-ID: <20160721222616.GA9741@jasmine> (raw)
In-Reply-To: <20160720235200.2359d8dc@openmailbox.org>
On Wed, Jul 20, 2016 at 11:52:00PM -0500, Eric Bavier wrote:
> On Wed, 20 Jul 2016 12:39:45 -0400
> Leo Famulari <leo@famulari.name> wrote:
>
> > On Wed, Jul 20, 2016 at 07:07:25AM -0400, Mark H Weaver wrote:
> > > Hmm. It would be good to see the diff between the two "versions" of
> > > 2.2.5. If there's anything substantive in there, then we might want to
> > > bump the version on our behalf. Otherwise it probably doesn't matter.
> >
> > The difference seem trivial to me. There are fixed typos in comments,
> > and code changes in 'example1.cpp'. I assume that 'example1.cpp' is
> > unimportant, but I don't know.
> >
> > What do you think about the attached patch?
>
> LGTM.
Thanks for the review!
Pushed as d7cff656d.
prev parent reply other threads:[~2016-07-21 22:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 16:42 bug#24026: librecad and dealii depend on relocated muparser source code repo Mark H Weaver
2016-07-20 6:26 ` Leo Famulari
2016-07-20 11:07 ` Mark H Weaver
2016-07-20 16:39 ` Leo Famulari
2016-07-21 4:52 ` Eric Bavier
2016-07-21 22:26 ` Leo Famulari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160721222616.GA9741@jasmine \
--to=leo@famulari.name \
--cc=24026-done@debbugs.gnu.org \
--cc=ericbavier@openmailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.