From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Bavier Subject: Re: [PATCH] gnu: Add lrzip. Date: Thu, 21 Jul 2016 00:24:36 -0500 Message-ID: <20160721002436.13651c1f@openmailbox.org> References: <20160720225413.2903-1-me@tobias.gr> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58417) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQ6Td-0008Bz-TI for guix-devel@gnu.org; Thu, 21 Jul 2016 01:24:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQ6TZ-0004PV-Mw for guix-devel@gnu.org; Thu, 21 Jul 2016 01:24:52 -0400 Received: from mail.openmailbox.org ([62.4.1.34]:43147) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQ6TZ-0004PF-Cb for guix-devel@gnu.org; Thu, 21 Jul 2016 01:24:49 -0400 In-Reply-To: <20160720225413.2903-1-me@tobias.gr> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Tobias Geerinckx-Rice Cc: guix-devel@gnu.org Hello Tobias, Thanks for the patch. A few comments: On Thu, 21 Jul 2016 00:54:13 +0200 Tobias Geerinckx-Rice wrote: > * gnu/packages/compression.scm (lrzip): New variable. > --- > gnu/packages/compression.scm | 32 ++++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm > index 6a17003..26467a4 100644 > --- a/gnu/packages/compression.scm > +++ b/gnu/packages/compression.scm > @@ -36,6 +36,7 @@ > #:use-module (guix build-system gnu) > #:use-module (guix build-system perl) > #:use-module (gnu packages) > + #:use-module (gnu packages assembly) > #:use-module (gnu packages autotools) > #:use-module (gnu packages backup) > #:use-module (gnu packages base) > @@ -833,3 +834,34 @@ also be used to apply such patches. xdelta is similar to @command{diff} and > @command{patch}, but is not limited to plain text and does not generate > human-readable output.") > (license license:asl2.0))) > + > +(define-public lrzip > + (package > + (name "lrzip") > + (version "0.630") > + (source > + (origin > + (method url-fetch) > + (uri (string-append > + "http://ck.kolivas.org/apps/lrzip/lrzip-" version ".tar.bz2")) > + (sha256 > + (base32 > + "01ykxliqw4cavx9f2gawxfa9wf52cjy1qx28cnkrh6i3lfzzcq94")))) > + (build-system gnu-build-system) > + (native-inputs > + `(("nasm" ,nasm) ASM support seems to be supported only on x86/32-bit systems. Could you make this input conditional on the system type? An example would be the "lame" package in gnu/packages/mp3.scm. > + ("perl" ,perl))) > + (inputs > + `(("bzip2" ,bzip2) Configure checks for libbz2 and the build instruction mention it as a requirement, but there are no references retained in the output and I don't see any references to libbz2 in the Makefile's. Any ideas? > + ("lzo" ,lzo) > + ("zlib" ,zlib))) > + (home-page "http://ck.kolivas.org/apps/lrzip/") > + (synopsis "Large file compressor with a very high compression ratio") > + (description "lrzip is a compression utility that uses long-range > +redundancy reduction to improve the subsequent compression ratio of > +larger files. It can then further compress the result with the ZPAQ or > +LZMA algorithms for maximum compression, or LZO for maximum speed. This > +choice between size or speed allows for either better compression than > +even LZMA can provide, or a higher speed than gzip while compressing as > +well as bzip2.") > + (license license:gpl2+))) The license should probably be "(list license:gpl3+ license:public-domain)" since there is at least one file, md5.c, that is borrowed from glibc and is under a gpl3+ license; and several of the files in the "lzma" directory have been released into the public domain. Could you send an updated patch? `~Eric