all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [PATCH] WIP: Output linters
@ 2016-07-13  4:34 ericbavier
  2016-07-13  4:34 ` [PATCH] gnu: lint: Check package outputs ericbavier
  2016-07-13 10:32 ` [PATCH] WIP: Output linters Ludovic Courtès
  0 siblings, 2 replies; 5+ messages in thread
From: ericbavier @ 2016-07-13  4:34 UTC (permalink / raw)
  To: guix-devel; +Cc: Eric Bavier

From: Eric Bavier <bavier@member.fsf.org>

I very much appreciate all that 'guix lint' can do, and thought that we could
get some benefit from extending its coverage to package outputs.  I wanted to
share this WIP patch to get some feedback on the idea.

The current patch just adds a simple check for the presence of build directory
strings in the output, which may affect build reproducibility across machines.
Other checks that might be useful might include checks:

* for "recent" timestamps, which might indicate use of __DATE__ or `date`,

* for presence of '.DIR' or other empty directories,

* for proper placement of documentation,

* for documentation that might best be moved to a "doc" output, or

* for self-contained pkg-config files, etc.

Any such checks obviously rely on the package outputs being in the store.  On
the one hand both local builds and substitutes are expensive.  But on the
other hand we'd like 'guix lint' to be run before someone submits a patch or
pushes their commits.  Being a good submitter, they hopefully went through the
trouble to test that the package builds, so the package outputs are mostly
likely in the store anyhow, and 'guix lint' wouldn't have any extra work to
do.

I'd like to hear from others whether they think this WIP has enough merit to
include in 'guix lint', and if so what other checks might be worth including.

Eric Bavier (1):
  gnu: lint: Check package outputs.

 guix/scripts/lint.scm | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 53 insertions(+)

-- 
2.9.0

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-07-15 14:19 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-13  4:34 [PATCH] WIP: Output linters ericbavier
2016-07-13  4:34 ` [PATCH] gnu: lint: Check package outputs ericbavier
2016-07-13 10:32 ` [PATCH] WIP: Output linters Ludovic Courtès
2016-07-14 18:27   ` Eric Bavier
2016-07-15 14:19     ` Ludovic Courtès

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.