[PATCH 00/17] Emacs packages!

[PATCH 00/17] Emacs packages!

[Ricardo Wurmus]

Hi Guix,

here are almost all of the remaining Emacs packages that I previously
installed via package.el.  I hope you find them useful!

~~ Ricardo

Ricardo Wurmus (17):
  gnu: Add emacs-el-mock.
  gnu: Add emacs-espuds.
  gnu: Add emacs-expand-region.
  gnu: Add emacs-fill-column-indicator.
  gnu: Add emacs-znc.
  gnu: Add emacs-paren-face.
  gnu: Add emacs-page-break-lines.
  gnu: Add emacs-simple-httpd.
  gnu: Add emacs-skewer-mode.
  gnu: Add emacs-rich-minority.
  gnu: Add emacs-smart-mode-line.
  gnu: Add emacs-shut-up.
  gnu: Add emacs-undercover.
  gnu: Add emacs-shell-switcher.
  gnu: Add emacs-tagedit.
  gnu: Add emacs-perspective.
  gnu: Add emacs-solarized-theme.

 gnu/packages/emacs.scm | 399 +++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 399 insertions(+)

-- 
2.8.4

[PATCH 01/17] gnu: Add emacs-el-mock.

[Ricardo Wurmus]

* gnu/packages/emacs.scm (emacs-el-mock): New variable.
---
 gnu/packages/emacs.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 3e6a2b5..95c8d9b 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1283,6 +1283,28 @@ strings.")
 files and directories.")
     (license license:gpl3+)))
 
+(define-public emacs-el-mock
+  (package
+    (name "emacs-el-mock")
+    (version "1.25.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/rejeep/el-mock.el/"
+                           "archive/v" version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "16xw94n58xxn3zvgyj72bmzs0k5lkvswjmzs79ws9n7rzdivb38b"))))
+    (build-system emacs-build-system)
+    (home-page "http://github.com/rejeep/el-mock.el")
+    (synopsis "Tiny mock and stub framework in Emacs Lisp")
+    (description
+     "Emacs Lisp Mock is a library for mocking and stubbing using readable
+syntax.  Most commonly Emacs Lisp Mock is used in conjunction with Emacs Lisp
+Expectations, but it can be used in other contexts.")
+    (license license:gpl3+)))
+
 (define-public emacs-ob-ipython
   (package
     (name "emacs-ob-ipython")
-- 
2.8.4

[PATCH 02/17] gnu: Add emacs-espuds.

[Ricardo Wurmus]

* gnu/packages/emacs.scm (emacs-espuds): New variable.
---
 gnu/packages/emacs.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 95c8d9b..cd87c79 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1305,6 +1305,31 @@ syntax.  Most commonly Emacs Lisp Mock is used in conjunction with Emacs Lisp
 Expectations, but it can be used in other contexts.")
     (license license:gpl3+)))
 
+(define-public emacs-espuds
+  (package
+    (name "emacs-espuds")
+    (version "0.3.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/ecukes/espuds/"
+                           "archive/v" version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "0xv551376pbmh735a3zjwc9z4qdx6ngj1vpq3xqjpn0a1rwjyn4k"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-el-mock" ,emacs-el-mock)
+       ("emacs-s" ,emacs-s)
+       ("emacs-dash" ,emacs-dash)
+       ("emacs-f" ,emacs-f)))
+    (home-page "http://github.com/ecukes/espuds")
+    (synopsis "Common step definitions for Ecukes")
+    (description "Espuds is a collection of the most commonly used step
+definitions for testing with the Ecukes framework.")
+    (license license:gpl3+)))
+
 (define-public emacs-ob-ipython
   (package
     (name "emacs-ob-ipython")
-- 
2.8.4

Re: [PATCH 02/17] gnu: Add emacs-espuds.

[Alex Kost]

Ricardo Wurmus (2016-07-13 00:04 +0300) wrote:

> * gnu/packages/emacs.scm (emacs-espuds): New variable.
> ---
>  gnu/packages/emacs.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 95c8d9b..cd87c79 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -1305,6 +1305,31 @@ syntax.  Most commonly Emacs Lisp Mock is used in conjunction with Emacs Lisp
>  Expectations, but it can be used in other contexts.")
>      (license license:gpl3+)))
>  
> +(define-public emacs-espuds
> +  (package
> +    (name "emacs-espuds")
> +    (version "0.3.3")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://github.com/ecukes/espuds/"
> +                           "archive/v" version ".tar.gz"))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0xv551376pbmh735a3zjwc9z4qdx6ngj1vpq3xqjpn0a1rwjyn4k"))))
> +    (build-system emacs-build-system)
> +    (propagated-inputs
> +     `(("emacs-el-mock" ,emacs-el-mock)

This is needed only for files from "test" subdir but the tests are not
run anyway.  I would just remove it.  Even if the tests will be checked
during the build process, "emacs-el-mock" shouldn't be propagated as it
is not a dependency of the "espuds.el".  Or do I miss anything?

> +       ("emacs-s" ,emacs-s)
> +       ("emacs-dash" ,emacs-dash)
> +       ("emacs-f" ,emacs-f)))
> +    (home-page "http://github.com/ecukes/espuds")
> +    (synopsis "Common step definitions for Ecukes")
> +    (description "Espuds is a collection of the most commonly used step
> +definitions for testing with the Ecukes framework.")
> +    (license license:gpl3+)))
> +
>  (define-public emacs-ob-ipython
>    (package
>      (name "emacs-ob-ipython")

-- 
Alex

[PATCH 03/17] gnu: Add emacs-expand-region.

[Ricardo Wurmus]

* gnu/packages/emacs.scm (emacs-expand-region): New variable.
---
 gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index cd87c79..169df4c 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1330,6 +1330,30 @@ Expectations, but it can be used in other contexts.")
 definitions for testing with the Ecukes framework.")
     (license license:gpl3+)))
 
+(define-public emacs-expand-region
+  (package
+    (name "emacs-expand-region")
+    (version "0.10.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/magnars/expand-region.el"
+                           "/archive/" version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "1zfiaqyb3zqiyqjkpqsjw660j09805nqsg25q6ars2h8gs0rnvxb"))))
+    (build-system emacs-build-system)
+    (native-inputs
+     `(("emacs-espuds" ,emacs-espuds)))
+    (home-page "https://github.com/magnars/expand-region.el")
+    (synopsis "Increase selected region by semantic units")
+    (description
+     "Expand region increases the selected region by semantic units.  Just
+keep pressing the key until it selects what you want.  There's also
+@code{er/contract-region} if you expand too far.")
+    (license license:gpl3+)))
+
 (define-public emacs-ob-ipython
   (package
     (name "emacs-ob-ipython")
-- 
2.8.4

Re: [PATCH 03/17] gnu: Add emacs-expand-region.

[Alex Kost]

Ricardo Wurmus (2016-07-13 00:05 +0300) wrote:

> * gnu/packages/emacs.scm (emacs-expand-region): New variable.
> ---
>  gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index cd87c79..169df4c 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -1330,6 +1330,30 @@ Expectations, but it can be used in other contexts.")
>  definitions for testing with the Ecukes framework.")
>      (license license:gpl3+)))
>  
> +(define-public emacs-expand-region
> +  (package
> +    (name "emacs-expand-region")
> +    (version "0.10.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://github.com/magnars/expand-region.el"
> +                           "/archive/" version ".tar.gz"))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "1zfiaqyb3zqiyqjkpqsjw660j09805nqsg25q6ars2h8gs0rnvxb"))))
> +    (build-system emacs-build-system)
> +    (native-inputs
> +     `(("emacs-espuds" ,emacs-espuds)))

Is it really needed?  AFAIU this is needed only for some development
things in "feature" subdir (Cask maybe, dunno).  If you add it to
compile "features/support/env.el", then it wasn't compiled anyway.

My understanding for emacs packages is that we try to prepare a user
package (what (M)ELPA does), and we don't care about various additional
cask, maintainer, development stuff.  WDYT?

> +    (home-page "https://github.com/magnars/expand-region.el")
> +    (synopsis "Increase selected region by semantic units")
> +    (description
> +     "Expand region increases the selected region by semantic units.  Just
> +keep pressing the key until it selects what you want.  There's also
> +@code{er/contract-region} if you expand too far.")
> +    (license license:gpl3+)))
> +
>  (define-public emacs-ob-ipython
>    (package
>      (name "emacs-ob-ipython")

-- 
Alex

[PATCH 04/17] gnu: Add emacs-fill-column-indicator.

[Ricardo Wurmus]

* gnu/packages/emacs.scm (emacs-fill-column-indicator): New variable.
---
 gnu/packages/emacs.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 169df4c..2b0ffbd 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1354,6 +1354,27 @@ keep pressing the key until it selects what you want.  There's also
 @code{er/contract-region} if you expand too far.")
     (license license:gpl3+)))
 
+(define-public emacs-fill-column-indicator
+  (package
+    (name "emacs-fill-column-indicator")
+    (version "1.81")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/alpaker/Fill-Column-Indicator"
+                           "/archive/v" version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "1xwyqbjbbicmvhlb85vg4j5snwy1vd7rfk89ws4viws5ljkhhyg8"))))
+    (build-system emacs-build-system)
+    (home-page "https://www.emacswiki.org/emacs/FillColumnIndicator")
+    (synopsis "Graphically indicate the fill column")
+    (description
+     "Fill-column-indicator graphically indicates the location of the fill
+column by drawing a thin line down the length of the editing window.")
+    (license license:gpl3+)))
+
 (define-public emacs-ob-ipython
   (package
     (name "emacs-ob-ipython")
-- 
2.8.4

[PATCH 05/17] gnu: Add emacs-znc.

[Ricardo Wurmus]

* gnu/packages/emacs.scm (emacs-znc): New variable.
---
 gnu/packages/emacs.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 2b0ffbd..7f6fe2d 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1375,6 +1375,26 @@ keep pressing the key until it selects what you want.  There's also
 column by drawing a thin line down the length of the editing window.")
     (license license:gpl3+)))
 
+(define-public emacs-znc
+  (package
+    (name "emacs-znc")
+    (version "0.0.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://marmalade-repo.org/packages/znc-"
+                           version ".el"))
+       (sha256
+        (base32
+         "1d8lqvybgyazin5z0g1c4l3rg1vzrrvf0saqs53jr1zcdg0lianh"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/sshirokov/ZNC.el")
+    (synopsis "Make ERC and ZNC get along better")
+    (description
+     "This is a thin wrapper around @code{erc} that enables one to use the ZNC
+IRC bouncer with ERC.")
+    (license license:expat)))
+
 (define-public emacs-ob-ipython
   (package
     (name "emacs-ob-ipython")
-- 
2.8.4

[PATCH 06/17] gnu: Add emacs-paren-face.

[Ricardo Wurmus]

* gnu/packages/emacs.scm (emacs-paren-face): New variable.
---
 gnu/packages/emacs.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 7f6fe2d..57c7c36 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1395,6 +1395,31 @@ column by drawing a thin line down the length of the editing window.")
 IRC bouncer with ERC.")
     (license license:expat)))
 
+(define-public emacs-paren-face
+  (package
+    (name "emacs-paren-face")
+    (version "1.0.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/tarsius/paren-face/archive/"
+                           version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "0y4qrhxa9332vsvr999jg7qj1ymnfgwpf591yi4a4jgg90pm7qnn"))))
+    (build-system emacs-build-system)
+    (home-page "http://github.com/tarsius/paren-face")
+    (synopsis "Face for parentheses in lisp modes")
+    (description
+     "This library defines a face named @code{parenthesis} used just for
+parentheses.  The intended purpose of this face is to make parentheses less
+visible in Lisp code by dimming them.  Lispers probably don't need to be
+constantly made aware of the existence of the parentheses.  Dimming them might
+be even more useful for people new to lisp who have not yet learned to
+subconsciously blend out the parentheses.")
+    (license license:gpl3+)))
+
 (define-public emacs-ob-ipython
   (package
     (name "emacs-ob-ipython")
-- 
2.8.4

[PATCH 07/17] gnu: Add emacs-page-break-lines.

[Ricardo Wurmus]

* gnu/packages/emacs.scm (emacs-page-break-lines): New variable.
---
 gnu/packages/emacs.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 57c7c36..00fe3de 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1420,6 +1420,27 @@ be even more useful for people new to lisp who have not yet learned to
 subconsciously blend out the parentheses.")
     (license license:gpl3+)))
 
+(define-public emacs-page-break-lines
+  (package
+    (name "emacs-page-break-lines")
+    (version "0.11")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/purcell/page-break-lines/"
+                           "archive/" version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "1zzhziq5kbrm9rxk30kx2glz455fp1blqxg8cpcf6l8xl3w8z4pg"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/purcell/page-break-lines")
+    (synopsis "Display page breaks as tidy horizontal lines")
+    (description
+     "This library provides a global mode which displays form feed characters
+as horizontal rules.")
+    (license license:gpl3+)))
+
 (define-public emacs-ob-ipython
   (package
     (name "emacs-ob-ipython")
-- 
2.8.4

[PATCH 08/17] gnu: Add emacs-simple-httpd.

[Ricardo Wurmus]

* gnu/packages/emacs.scm (emacs-simple-httpd): New variable.
---
 gnu/packages/emacs.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 00fe3de..20212c4 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1441,6 +1441,27 @@ subconsciously blend out the parentheses.")
 as horizontal rules.")
     (license license:gpl3+)))
 
+(define-public emacs-simple-httpd
+  (package
+    (name "emacs-simple-httpd")
+    (version "1.4.6")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/skeeto/emacs-web-server/"
+                           "archive/" version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "01r7h3imnj4qx1m53a2wjafvbylcyz5f9r2rg2cs7ky3chlg220r"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/skeeto/emacs-http-server")
+    (synopsis "HTTP server in pure Emacs Lisp")
+    (description
+     "This package provides a simple HTTP server written in Emacs Lisp to
+serve files and directory listings.")
+    (license license:unlicense)))
+
 (define-public emacs-ob-ipython
   (package
     (name "emacs-ob-ipython")
-- 
2.8.4

[PATCH 09/17] gnu: Add emacs-skewer-mode.

[Ricardo Wurmus]

* gnu/packages/emacs.scm (emacs-skewer-mode): New variable.
---
 gnu/packages/emacs.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 20212c4..d4b5291 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1462,6 +1462,32 @@ as horizontal rules.")
 serve files and directory listings.")
     (license license:unlicense)))
 
+(define-public emacs-skewer-mode
+  (package
+    (name "emacs-skewer-mode")
+    (version "1.6.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/skeeto/skewer-mode/archive/"
+                           version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "07jpz374j0j964szy3zznrkyja2kpdl3xa87wh7349mzxivqxdx0"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-simple-httpd" ,emacs-simple-httpd)
+       ("emacs-js2-mode" ,emacs-js2-mode)))
+    (home-page "https://github.com/skeeto/skewer-mode")
+    (synopsis "Live web development in Emacs")
+    (description
+     "Skewer-mode provides live interaction with JavaScript, CSS, and HTML in
+a web browser.  Expressions are sent on-the-fly from an editing buffer to be
+evaluated in the browser, just like Emacs does with an inferior Lisp process
+in Lisp modes.")
+    (license license:unlicense)))
+
 (define-public emacs-ob-ipython
   (package
     (name "emacs-ob-ipython")
-- 
2.8.4

[PATCH 10/17] gnu: Add emacs-rich-minority.

[Ricardo Wurmus]

* gnu/packages/emacs.scm (emacs-rich-minority): New variable.
---
 gnu/packages/emacs.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index d4b5291..edd65e9 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1488,6 +1488,27 @@ evaluated in the browser, just like Emacs does with an inferior Lisp process
 in Lisp modes.")
     (license license:unlicense)))
 
+(define-public emacs-rich-minority
+  (package
+    (name "emacs-rich-minority")
+    (version "1.0.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/Malabarba/rich-minority/"
+                           "archive/" version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "1l0cb0q7kyi88nwfqd542psnkgwnjklpzc5rx32gzd3lkwkrbr8v"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/Malabarba/rich-minority")
+    (synopsis "Clean-up and beautify the list of minor modes")
+    (description
+     "This Emacs package hides and/or highlights minor modes in the
+mode-line.")
+    (license license:gpl2+)))
+
 (define-public emacs-ob-ipython
   (package
     (name "emacs-ob-ipython")
-- 
2.8.4

[PATCH 11/17] gnu: Add emacs-smart-mode-line.

[Ricardo Wurmus]

* gnu/packages/emacs.scm (emacs-smart-mode-line): New variable.
---
 gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index edd65e9..2dd886f 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1509,6 +1509,30 @@ in Lisp modes.")
 mode-line.")
     (license license:gpl2+)))
 
+(define-public emacs-smart-mode-line
+  (package
+    (name "emacs-smart-mode-line")
+    (version "2.10.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/Malabarba/smart-mode-line/"
+                           "archive/" version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "0i9wajabrrsjzwd842q0m2611kf0q31p9hg1pdj81177gynkw8l8"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-rich-minority" ,emacs-rich-minority)))
+    (home-page "http://github.com/Malabarba/smart-mode-line")
+    (synopsis "Color-coded smart mode-line.")
+    (description
+     "Smart Mode Line is a mode-line theme for Emacs.  It aims to be easy to
+read from small to large monitors by using colors, a prefix feature, and smart
+truncation.")
+    (license license:gpl2+)))
+
 (define-public emacs-ob-ipython
   (package
     (name "emacs-ob-ipython")
-- 
2.8.4

[PATCH 12/17] gnu: Add emacs-shut-up.

[Ricardo Wurmus]

* gnu/packages/emacs.scm (emacs-shut-up): New variable.
---
 gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 2dd886f..ed3a1e3 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1395,6 +1395,29 @@ column by drawing a thin line down the length of the editing window.")
 IRC bouncer with ERC.")
     (license license:expat)))
 
+(define-public emacs-shut-up
+  (package
+    (name "emacs-shut-up")
+    (version "0.3.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/cask/shut-up/"
+                           "archive/v" version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "09kzrjdkb569iviyg7ydwq44yh84m3f9hkl7jizfrlk0w4gz67d1"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-f" ,emacs-f)
+       ("emacs-s" ,emacs-s)))
+    (home-page "https://github.com/cask/shut-up")
+    (synopsis "Silence Emacs")
+    (description "This package silences most output of Emacs when running an
+Emacs shell script.")
+    (license license:expat)))
+
 (define-public emacs-paren-face
   (package
     (name "emacs-paren-face")
-- 
2.8.4

Re: [PATCH 12/17] gnu: Add emacs-shut-up.

[Alex Kost]

Ricardo Wurmus (2016-07-13 00:05 +0300) wrote:

> * gnu/packages/emacs.scm (emacs-shut-up): New variable.
> ---
>  gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 2dd886f..ed3a1e3 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -1395,6 +1395,29 @@ column by drawing a thin line down the length of the editing window.")
>  IRC bouncer with ERC.")
>      (license license:expat)))
>  
> +(define-public emacs-shut-up
> +  (package
> +    (name "emacs-shut-up")
> +    (version "0.3.2")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://github.com/cask/shut-up/"
> +                           "archive/v" version ".tar.gz"))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "09kzrjdkb569iviyg7ydwq44yh84m3f9hkl7jizfrlk0w4gz67d1"))))
> +    (build-system emacs-build-system)
> +    (propagated-inputs
> +     `(("emacs-f" ,emacs-f)
> +       ("emacs-s" ,emacs-s)))

"f" and "s" are only for "test" subdir and they have no effect on the
package itself ("shut-up.el" file).  The only benefit is that
"test/test-helper.el" file is compiled, but it doesn't give anything to
the end user.  So I would remove them (at least they shouldn't be
propagated).

> +    (home-page "https://github.com/cask/shut-up")
> +    (synopsis "Silence Emacs")
> +    (description "This package silences most output of Emacs when running an
> +Emacs shell script.")
> +    (license license:expat)))
> +
>  (define-public emacs-paren-face
>    (package
>      (name "emacs-paren-face")

-- 
Alex

[PATCH 13/17] gnu: Add emacs-undercover.

[Ricardo Wurmus]

* gnu/packages/emacs.scm (emacs-undercover): New variable.
---
 gnu/packages/emacs.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index ed3a1e3..f544721 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1418,6 +1418,31 @@ IRC bouncer with ERC.")
 Emacs shell script.")
     (license license:expat)))
 
+(define-public emacs-undercover
+  (package
+    (name "emacs-undercover")
+    (version "0.6.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/sviridov/undercover.el/"
+                           "archive/v" version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "0f48fi0xnbsqs382rgh85m9mq1wdnr0yib7as9xhwzvq0hsr5m0a"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-dash" ,emacs-dash)
+       ("emacs-s" ,emacs-s)
+       ("emacs-shut-up" ,emacs-shut-up)))
+    (home-page "https://github.com/sviridov/undercover.el")
+    (synopsis "Test coverage library for Emacs Lisp")
+    (description
+     "Undercover is a test coverage library for software written in Emacs
+Lisp.")
+    (license license:expat)))
+
 (define-public emacs-paren-face
   (package
     (name "emacs-paren-face")
-- 
2.8.4

Re: [PATCH 13/17] gnu: Add emacs-undercover.

[Alex Kost]

Ricardo Wurmus (2016-07-13 00:05 +0300) wrote:

> * gnu/packages/emacs.scm (emacs-undercover): New variable.
> ---
>  gnu/packages/emacs.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index ed3a1e3..f544721 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -1418,6 +1418,31 @@ IRC bouncer with ERC.")
>  Emacs shell script.")
>      (license license:expat)))
>  
> +(define-public emacs-undercover
> +  (package
> +    (name "emacs-undercover")
> +    (version "0.6.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://github.com/sviridov/undercover.el/"
> +                           "archive/v" version ".tar.gz"))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0f48fi0xnbsqs382rgh85m9mq1wdnr0yib7as9xhwzvq0hsr5m0a"))))
> +    (build-system emacs-build-system)
> +    (propagated-inputs
> +     `(("emacs-dash" ,emacs-dash)
> +       ("emacs-s" ,emacs-s)

The same comment: "emacs-s" is not needed for the end user, the package
will work without it.

> +       ("emacs-shut-up" ,emacs-shut-up)))
> +    (home-page "https://github.com/sviridov/undercover.el")
> +    (synopsis "Test coverage library for Emacs Lisp")
> +    (description
> +     "Undercover is a test coverage library for software written in Emacs
> +Lisp.")
> +    (license license:expat)))
> +
>  (define-public emacs-paren-face
>    (package
>      (name "emacs-paren-face")

-- 
Alex

[PATCH 14/17] gnu: Add emacs-shell-switcher.

[Ricardo Wurmus]

* gnu/packages/emacs.scm (emacs-shell-switcher): New variable.
---
 gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index f544721..64192cc 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1581,6 +1581,30 @@ read from small to large monitors by using colors, a prefix feature, and smart
 truncation.")
     (license license:gpl2+)))
 
+(define-public emacs-shell-switcher
+  (package
+    (name "emacs-shell-switcher")
+    (version "1.0.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/DamienCassou/shell-switcher"
+                           "/archive/v" version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "1c23mfkdqz2g9rixd9smm323vzlvhzz3ng34ambcqjfq309qb2nz"))))
+    (build-system emacs-build-system)
+    (native-inputs
+     `(("emacs-espuds" ,emacs-espuds)
+       ("emacs-undercover" ,emacs-undercover)
+       ("emacs-f" ,emacs-f)))
+    (home-page "https://github.com/DamienCassou/shell-switcher")
+    (synopsis "Provide fast switching between shell buffers")
+    (description
+     "This package provides commands to quickly switch between shell buffers.")
+    (license license:gpl3+)))
+
 (define-public emacs-ob-ipython
   (package
     (name "emacs-ob-ipython")
-- 
2.8.4

Re: [PATCH 14/17] gnu: Add emacs-shell-switcher.

[Alex Kost]

Ricardo Wurmus (2016-07-13 00:05 +0300) wrote:

> * gnu/packages/emacs.scm (emacs-shell-switcher): New variable.
> ---
>  gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index f544721..64192cc 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -1581,6 +1581,30 @@ read from small to large monitors by using colors, a prefix feature, and smart
>  truncation.")
>      (license license:gpl2+)))
>  
> +(define-public emacs-shell-switcher
> +  (package
> +    (name "emacs-shell-switcher")
> +    (version "1.0.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://github.com/DamienCassou/shell-switcher"
> +                           "/archive/v" version ".tar.gz"))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "1c23mfkdqz2g9rixd9smm323vzlvhzz3ng34ambcqjfq309qb2nz"))))
> +    (build-system emacs-build-system)
> +    (native-inputs
> +     `(("emacs-espuds" ,emacs-espuds)
> +       ("emacs-undercover" ,emacs-undercover)
> +       ("emacs-f" ,emacs-f)))

The same comment: all three are not needed IMO, they do nothing useful.

> +    (home-page "https://github.com/DamienCassou/shell-switcher")
> +    (synopsis "Provide fast switching between shell buffers")
> +    (description
> +     "This package provides commands to quickly switch between shell buffers.")
> +    (license license:gpl3+)))
> +
>  (define-public emacs-ob-ipython
>    (package
>      (name "emacs-ob-ipython")

-- 
Alex

[PATCH 15/17] gnu: Add emacs-tagedit.

[Ricardo Wurmus]

* gnu/packages/emacs.scm (emacs-tagedit): New variable.
---
 gnu/packages/emacs.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 64192cc..283ed56 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1862,6 +1862,32 @@ identifiers in the MIT-Scheme documentation.")
 constants and units into an Emacs buffer.")
     (license license:gpl2+)))
 
+(define-public emacs-tagedit
+  (package
+    (name "emacs-tagedit")
+    (version "1.4.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/magnars/tagedit/"
+                           "archive/" version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "1apfnann4qklfdsmdi7icjsj18x7gwx8d83iqr4z25clszz95xfq"))))
+    (build-system emacs-build-system)
+    (native-inputs
+     `(("emacs-espuds" ,emacs-espuds)))
+    (propagated-inputs
+     `(("emacs-s" ,emacs-s)
+       ("emacs-dash" ,emacs-dash)))
+    (home-page "https://github.com/magnars/tagedit")
+    (synopsis "Some paredit-like features for html-mode")
+    (description
+     "This package provides a collection of paredit-like functions for editing
+in @code{html-mode}.")
+    (license license:gpl3+)))
+
 (define-public emacs-slime
   (package
     (name "emacs-slime")
-- 
2.8.4

Re: [PATCH 15/17] gnu: Add emacs-tagedit.

[Alex Kost]

Ricardo Wurmus (2016-07-13 00:05 +0300) wrote:

> * gnu/packages/emacs.scm (emacs-tagedit): New variable.
> ---
>  gnu/packages/emacs.scm | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 64192cc..283ed56 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -1862,6 +1862,32 @@ identifiers in the MIT-Scheme documentation.")
>  constants and units into an Emacs buffer.")
>      (license license:gpl2+)))
>  
> +(define-public emacs-tagedit
> +  (package
> +    (name "emacs-tagedit")
> +    (version "1.4.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://github.com/magnars/tagedit/"
> +                           "archive/" version ".tar.gz"))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "1apfnann4qklfdsmdi7icjsj18x7gwx8d83iqr4z25clszz95xfq"))))
> +    (build-system emacs-build-system)
> +    (native-inputs
> +     `(("emacs-espuds" ,emacs-espuds)))

The same comment: I think it is not needed.  Or do you think it should
be added?  Why?

> +    (propagated-inputs
> +     `(("emacs-s" ,emacs-s)
> +       ("emacs-dash" ,emacs-dash)))
> +    (home-page "https://github.com/magnars/tagedit")
> +    (synopsis "Some paredit-like features for html-mode")
> +    (description
> +     "This package provides a collection of paredit-like functions for editing
> +in @code{html-mode}.")
> +    (license license:gpl3+)))
> +
>  (define-public emacs-slime
>    (package
>      (name "emacs-slime")

-- 
Alex

[PATCH 16/17] gnu: Add emacs-perspective.

[Ricardo Wurmus]

* gnu/packages/emacs.scm (emacs-perspective): New variable.
---
 gnu/packages/emacs.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 283ed56..2c92756 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -2137,6 +2137,33 @@ moving to the next or previous keyword and to invoke @code{occur} with a
 regexp that matches all known keywords.")
     (license license:gpl3+)))
 
+(define-public emacs-perspective
+  (package
+    (name "emacs-perspective")
+    (version "1.12")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/nex3/perspective-el/"
+                           "archive/" version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "078ahh0kmhdylq5ib9c81c76kz1n02xwc83pm729d00i84ibviic"))))
+    (build-system emacs-build-system)
+    (home-page "http://github.com/nex3/perspective-el")
+    (synopsis "Switch between named \"perspectives\"")
+    (description
+     "This package provides tagged workspaces in Emacs, similar to workspaces in
+windows managers such as Awesome and XMonad.  @code{perspective.el} provides
+multiple workspaces (or \"perspectives\") for each Emacs frame.  Each
+perspective is composed of a window configuration and a set of buffers.
+Switching to a perspective activates its window configuration, and when in a
+perspective only its buffers are available by default.")
+    ;; This package is released under the same license as Emacs (GPLv3+) or
+    ;; the Expat license.
+    (license license:gpl3+)))
+
 (define-public emacs-hydra
   (package
     (name "emacs-hydra")
-- 
2.8.4

[PATCH 17/17] gnu: Add emacs-solarized-theme.

[Ricardo Wurmus]

* gnu/packages/emacs.scm (emacs-solarized-theme): New variable.
---
 gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 2c92756..4f2d5ca 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -2086,6 +2086,30 @@ number.")
 It is built on top of the custom theme support in Emacs 24 or later.")
     (license license:gpl3+)))
 
+(define-public emacs-solarized-theme
+  (package
+    (name "emacs-solarized-theme")
+    (version "1.2.2")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://github.com/bbatsov/solarized-emacs/"
+                                  "archive/v"  version ".tar.gz"))
+              (file-name (string-append name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "1ha3slc6d9wi9ilkhmwrzkvf308n6ph7b0k69pk369s9304awxzx"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-dash" ,emacs-dash)
+       ("emacs-f" ,emacs-f)
+       ("emacs-s" ,emacs-s)))
+    (home-page "http://github.com/bbatsov/solarized-emacs")
+    (synopsis "Port of the Solarized theme for Emacs")
+    (description
+     "Solarized for Emacs is a port of the Solarized theme for Vim.  This
+package provides a light and a dark variant.")
+    (license license:gpl3+)))
+
 (define-public emacs-smartparens
   (package
     (name "emacs-smartparens")
-- 
2.8.4

Re: [PATCH 17/17] gnu: Add emacs-solarized-theme.

[Roel Janssen]

Ricardo Wurmus writes:

> * gnu/packages/emacs.scm (emacs-solarized-theme): New variable.
> ---
>  gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 2c92756..4f2d5ca 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -2086,6 +2086,30 @@ number.")
>  It is built on top of the custom theme support in Emacs 24 or later.")
>      (license license:gpl3+)))
>  
> +(define-public emacs-solarized-theme
> +  (package
> +    (name "emacs-solarized-theme")
> +    (version "1.2.2")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://github.com/bbatsov/solarized-emacs/"
> +                                  "archive/v"  version ".tar.gz"))
> +              (file-name (string-append name "-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "1ha3slc6d9wi9ilkhmwrzkvf308n6ph7b0k69pk369s9304awxzx"))))
> +    (build-system emacs-build-system)
> +    (propagated-inputs
> +     `(("emacs-dash" ,emacs-dash)
> +       ("emacs-f" ,emacs-f)
> +       ("emacs-s" ,emacs-s)))
> +    (home-page "http://github.com/bbatsov/solarized-emacs")
> +    (synopsis "Port of the Solarized theme for Emacs")
> +    (description
> +     "Solarized for Emacs is a port of the Solarized theme for Vim.  This
> +package provides a light and a dark variant.")
> +    (license license:gpl3+)))
> +
>  (define-public emacs-smartparens
>    (package
>      (name "emacs-smartparens")

After installing this package I tried to `M-x load-theme solarized'.  That
resulted in the error: `Undefined Custom theme solarized'.

However, `solarized-dark' works fine.

Could you verify that `M-x load-theme solarized' works on your end?

Kind regards,
Roel Janssen

Re: [PATCH 17/17] gnu: Add emacs-solarized-theme.

[Ricardo Wurmus]

Roel Janssen <roel@gnu.org> writes:

> Ricardo Wurmus writes:
>
>> * gnu/packages/emacs.scm (emacs-solarized-theme): New variable.
>> ---
>>  gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
>>  1 file changed, 24 insertions(+)
>>
>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>> index 2c92756..4f2d5ca 100644
>> --- a/gnu/packages/emacs.scm
>> +++ b/gnu/packages/emacs.scm
>> @@ -2086,6 +2086,30 @@ number.")
>>  It is built on top of the custom theme support in Emacs 24 or later.")
>>      (license license:gpl3+)))
>>  
>> +(define-public emacs-solarized-theme
>> +  (package
>> +    (name "emacs-solarized-theme")
>> +    (version "1.2.2")
>> +    (source (origin
>> +              (method url-fetch)
>> +              (uri (string-append "https://github.com/bbatsov/solarized-emacs/"
>> +                                  "archive/v"  version ".tar.gz"))
>> +              (file-name (string-append name "-" version ".tar.gz"))
>> +              (sha256
>> +               (base32
>> +                "1ha3slc6d9wi9ilkhmwrzkvf308n6ph7b0k69pk369s9304awxzx"))))
>> +    (build-system emacs-build-system)
>> +    (propagated-inputs
>> +     `(("emacs-dash" ,emacs-dash)
>> +       ("emacs-f" ,emacs-f)
>> +       ("emacs-s" ,emacs-s)))
>> +    (home-page "http://github.com/bbatsov/solarized-emacs")
>> +    (synopsis "Port of the Solarized theme for Emacs")
>> +    (description
>> +     "Solarized for Emacs is a port of the Solarized theme for Vim.  This
>> +package provides a light and a dark variant.")
>> +    (license license:gpl3+)))
>> +
>>  (define-public emacs-smartparens
>>    (package
>>      (name "emacs-smartparens")
>
> After installing this package I tried to `M-x load-theme solarized'.  That
> resulted in the error: `Undefined Custom theme solarized'.
>
> However, `solarized-dark' works fine.
>
> Could you verify that `M-x load-theme solarized' works on your end?

I’m using “solarized-light” only.  Is “M-x load-theme solarized”
even supposed to work?

~~ Ricardo

Re: [PATCH 17/17] gnu: Add emacs-solarized-theme.

[Roel Janssen]

Ricardo Wurmus writes:

> Roel Janssen <roel@gnu.org> writes:
>
>> Ricardo Wurmus writes:
>>
>>> * gnu/packages/emacs.scm (emacs-solarized-theme): New variable.
>>> ---
>>>  gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
>>>  1 file changed, 24 insertions(+)
>>>
>>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>>> index 2c92756..4f2d5ca 100644
>>> --- a/gnu/packages/emacs.scm
>>> +++ b/gnu/packages/emacs.scm
>>> @@ -2086,6 +2086,30 @@ number.")
>>>  It is built on top of the custom theme support in Emacs 24 or later.")
>>>      (license license:gpl3+)))
>>>  
>>> +(define-public emacs-solarized-theme
>>> +  (package
>>> +    (name "emacs-solarized-theme")
>>> +    (version "1.2.2")
>>> +    (source (origin
>>> +              (method url-fetch)
>>> +              (uri (string-append "https://github.com/bbatsov/solarized-emacs/"
>>> +                                  "archive/v"  version ".tar.gz"))
>>> +              (file-name (string-append name "-" version ".tar.gz"))
>>> +              (sha256
>>> +               (base32
>>> +                "1ha3slc6d9wi9ilkhmwrzkvf308n6ph7b0k69pk369s9304awxzx"))))
>>> +    (build-system emacs-build-system)
>>> +    (propagated-inputs
>>> +     `(("emacs-dash" ,emacs-dash)
>>> +       ("emacs-f" ,emacs-f)
>>> +       ("emacs-s" ,emacs-s)))
>>> +    (home-page "http://github.com/bbatsov/solarized-emacs")
>>> +    (synopsis "Port of the Solarized theme for Emacs")
>>> +    (description
>>> +     "Solarized for Emacs is a port of the Solarized theme for Vim.  This
>>> +package provides a light and a dark variant.")
>>> +    (license license:gpl3+)))
>>> +
>>>  (define-public emacs-smartparens
>>>    (package
>>>      (name "emacs-smartparens")
>>
>> After installing this package I tried to `M-x load-theme solarized'.  That
>> resulted in the error: `Undefined Custom theme solarized'.
>>
>> However, `solarized-dark' works fine.
>>
>> Could you verify that `M-x load-theme solarized' works on your end?
>
> I’m using “solarized-light” only.  Is “M-x load-theme solarized”
> even supposed to work?

The auto-completion shows three themes: solarized, solarized-light, and
solarized-dark.  The description says this package provides two themes:
light and dark.

I guess it works as it is supposed to, because the description tells
there are two variants.

So, the patch is fine with me.

Kind regards,
Roel Janssen

Re: [PATCH 17/17] gnu: Add emacs-solarized-theme.

[Alex Kost]

Roel Janssen (2016-07-13 23:50 +0300) wrote:

> Ricardo Wurmus writes:
>
>> Roel Janssen <roel@gnu.org> writes:
[...]
>>> After installing this package I tried to `M-x load-theme solarized'.  That
>>> resulted in the error: `Undefined Custom theme solarized'.
>>>
>>> However, `solarized-dark' works fine.
>>>
>>> Could you verify that `M-x load-theme solarized' works on your end?
>>
>> I’m using “solarized-light” only.  Is “M-x load-theme solarized”
>> even supposed to work?
>
> The auto-completion shows three themes: solarized, solarized-light, and
> solarized-dark.  The description says this package provides two themes:
> light and dark.

The code also says there are only 2 themes (light and dark).

> I guess it works as it is supposed to, because the description tells
> there are two variants.

Right, "M-x load-theme solarized" is not supposed to work.  There is no
such theme.

As for the false completion you mentioned, it happens because of this
file:

  https://github.com/bbatsov/solarized-emacs/blob/master/solarized-theme.el

"M-x load-theme" uses 'custom-available-themes' function to define a
list of themes and since there is "solarized-theme.el" file, 'solarized'
symbol also appears in this list (but there is no "solarized" theme).

I would say this is a (tiny) solarized bug.  I don't see a purpose in
this "solarized-theme.el" file (probably historical reasons).

-- 
Alex

Re: [PATCH 17/17] gnu: Add emacs-solarized-theme.

[Alex Kost]

Ricardo Wurmus (2016-07-13 00:05 +0300) wrote:

> * gnu/packages/emacs.scm (emacs-solarized-theme): New variable.
> ---
>  gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 2c92756..4f2d5ca 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -2086,6 +2086,30 @@ number.")
>  It is built on top of the custom theme support in Emacs 24 or later.")
>      (license license:gpl3+)))
>  
> +(define-public emacs-solarized-theme
> +  (package
> +    (name "emacs-solarized-theme")
> +    (version "1.2.2")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://github.com/bbatsov/solarized-emacs/"
> +                                  "archive/v"  version ".tar.gz"))
> +              (file-name (string-append name "-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "1ha3slc6d9wi9ilkhmwrzkvf308n6ph7b0k69pk369s9304awxzx"))))
> +    (build-system emacs-build-system)
> +    (propagated-inputs
> +     `(("emacs-dash" ,emacs-dash)
> +       ("emacs-f" ,emacs-f)
> +       ("emacs-s" ,emacs-s)))

There is no need in "f" and "s", this package depends only on "dash"
library.  Otherwise LGTM.

> +    (home-page "http://github.com/bbatsov/solarized-emacs")
> +    (synopsis "Port of the Solarized theme for Emacs")
> +    (description
> +     "Solarized for Emacs is a port of the Solarized theme for Vim.  This
> +package provides a light and a dark variant.")
> +    (license license:gpl3+)))
> +
>  (define-public emacs-smartparens
>    (package
>      (name "emacs-smartparens")

-- 
Alex

Re: [PATCH 17/17] gnu: Add emacs-solarized-theme.

[Alex Kost]

Alex Kost (2016-07-15 16:57 +0300) wrote:

> Ricardo Wurmus (2016-07-13 00:05 +0300) wrote:
>
>> * gnu/packages/emacs.scm (emacs-solarized-theme): New variable.
>> ---
>>  gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
>>  1 file changed, 24 insertions(+)
>>
>>
>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>> index 2c92756..4f2d5ca 100644
>> --- a/gnu/packages/emacs.scm
>> +++ b/gnu/packages/emacs.scm
>> @@ -2086,6 +2086,30 @@ number.")
>>  It is built on top of the custom theme support in Emacs 24 or later.")
>>      (license license:gpl3+)))
>>  
>> +(define-public emacs-solarized-theme
>> +  (package
>> +    (name "emacs-solarized-theme")
>> +    (version "1.2.2")
>> +    (source (origin
>> +              (method url-fetch)
>> +              (uri (string-append "https://github.com/bbatsov/solarized-emacs/"
>> +                                  "archive/v"  version ".tar.gz"))
>> +              (file-name (string-append name "-" version ".tar.gz"))
>> +              (sha256
>> +               (base32
>> +                "1ha3slc6d9wi9ilkhmwrzkvf308n6ph7b0k69pk369s9304awxzx"))))
>> +    (build-system emacs-build-system)
>> +    (propagated-inputs
>> +     `(("emacs-dash" ,emacs-dash)
>> +       ("emacs-f" ,emacs-f)
>> +       ("emacs-s" ,emacs-s)))
>
> There is no need in "f" and "s", this package depends only on "dash"
> library.  Otherwise LGTM.

<cough> you seem to forget to remove "f" and "s" in commit 012c8b3 :-)

-- 
Alex

Re: [PATCH 17/17] gnu: Add emacs-solarized-theme.

[Ricardo Wurmus]

Alex Kost <alezost@gmail.com> writes:

> Alex Kost (2016-07-15 16:57 +0300) wrote:
>
>> Ricardo Wurmus (2016-07-13 00:05 +0300) wrote:
>>
>>> * gnu/packages/emacs.scm (emacs-solarized-theme): New variable.
>>> ---
>>>  gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
>>>  1 file changed, 24 insertions(+)
>>>
>>>
>>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>>> index 2c92756..4f2d5ca 100644
>>> --- a/gnu/packages/emacs.scm
>>> +++ b/gnu/packages/emacs.scm
>>> @@ -2086,6 +2086,30 @@ number.")
>>>  It is built on top of the custom theme support in Emacs 24 or later.")
>>>      (license license:gpl3+)))
>>>  
>>> +(define-public emacs-solarized-theme
>>> +  (package
>>> +    (name "emacs-solarized-theme")
>>> +    (version "1.2.2")
>>> +    (source (origin
>>> +              (method url-fetch)
>>> +              (uri (string-append "https://github.com/bbatsov/solarized-emacs/"
>>> +                                  "archive/v"  version ".tar.gz"))
>>> +              (file-name (string-append name "-" version ".tar.gz"))
>>> +              (sha256
>>> +               (base32
>>> +                "1ha3slc6d9wi9ilkhmwrzkvf308n6ph7b0k69pk369s9304awxzx"))))
>>> +    (build-system emacs-build-system)
>>> +    (propagated-inputs
>>> +     `(("emacs-dash" ,emacs-dash)
>>> +       ("emacs-f" ,emacs-f)
>>> +       ("emacs-s" ,emacs-s)))
>>
>> There is no need in "f" and "s", this package depends only on "dash"
>> library.  Otherwise LGTM.
>
> <cough> you seem to forget to remove "f" and "s" in commit 012c8b3 :-)

Argh, you are right!  I’m sorry :(

~~ Ricardo

Re: [PATCH 00/17] Emacs packages!

[Roel Janssen]

Ricardo Wurmus writes:

> Hi Guix,
>
> here are almost all of the remaining Emacs packages that I previously
> installed via package.el.  I hope you find them useful!
>
> ~~ Ricardo
>
> Ricardo Wurmus (17):
>   gnu: Add emacs-el-mock.
>   gnu: Add emacs-espuds.
>   gnu: Add emacs-expand-region.
>   gnu: Add emacs-fill-column-indicator.
>   gnu: Add emacs-znc.
>   gnu: Add emacs-paren-face.
>   gnu: Add emacs-page-break-lines.
>   gnu: Add emacs-simple-httpd.
>   gnu: Add emacs-skewer-mode.
>   gnu: Add emacs-rich-minority.
>   gnu: Add emacs-smart-mode-line.
>   gnu: Add emacs-shut-up.
>   gnu: Add emacs-undercover.
>   gnu: Add emacs-shell-switcher.
>   gnu: Add emacs-tagedit.
>   gnu: Add emacs-perspective.
>   gnu: Add emacs-solarized-theme.
>
>  gnu/packages/emacs.scm | 399 +++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 399 insertions(+)

These look good to me.  I noticed that you start the description string
on a new line on most of these packages.  Is that on purpose?

Kind regards,
Roel Janssen

Re: [PATCH 00/17] Emacs packages!

[Ricardo Wurmus]

Roel Janssen <roel@gnu.org> writes:

> Ricardo Wurmus writes:
>
>> Hi Guix,
>>
>> here are almost all of the remaining Emacs packages that I previously
>> installed via package.el.  I hope you find them useful!
>>
>> ~~ Ricardo
>>
>> Ricardo Wurmus (17):
>>   gnu: Add emacs-el-mock.
>>   gnu: Add emacs-espuds.
>>   gnu: Add emacs-expand-region.
>>   gnu: Add emacs-fill-column-indicator.
>>   gnu: Add emacs-znc.
>>   gnu: Add emacs-paren-face.
>>   gnu: Add emacs-page-break-lines.
>>   gnu: Add emacs-simple-httpd.
>>   gnu: Add emacs-skewer-mode.
>>   gnu: Add emacs-rich-minority.
>>   gnu: Add emacs-smart-mode-line.
>>   gnu: Add emacs-shut-up.
>>   gnu: Add emacs-undercover.
>>   gnu: Add emacs-shell-switcher.
>>   gnu: Add emacs-tagedit.
>>   gnu: Add emacs-perspective.
>>   gnu: Add emacs-solarized-theme.
>>
>>  gnu/packages/emacs.scm | 399 +++++++++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 399 insertions(+)
>
> These look good to me.

Thanks for checking!

> I noticed that you start the description string
> on a new line on most of these packages.  Is that on purpose?

It’s the way the importer formats the expression.  I don’t have a
preference either way.  Both ways are valid.

~~ Ricardo

Re: [PATCH 00/17] Emacs packages!

[Ludovic Courtès]

Roel Janssen <roel@gnu.org> skribis:

> Ricardo Wurmus writes:
>
>> Hi Guix,
>>
>> here are almost all of the remaining Emacs packages that I previously
>> installed via package.el.  I hope you find them useful!
>>
>> ~~ Ricardo
>>
>> Ricardo Wurmus (17):
>>   gnu: Add emacs-el-mock.
>>   gnu: Add emacs-espuds.
>>   gnu: Add emacs-expand-region.
>>   gnu: Add emacs-fill-column-indicator.
>>   gnu: Add emacs-znc.
>>   gnu: Add emacs-paren-face.
>>   gnu: Add emacs-page-break-lines.
>>   gnu: Add emacs-simple-httpd.
>>   gnu: Add emacs-skewer-mode.
>>   gnu: Add emacs-rich-minority.
>>   gnu: Add emacs-smart-mode-line.
>>   gnu: Add emacs-shut-up.
>>   gnu: Add emacs-undercover.
>>   gnu: Add emacs-shell-switcher.
>>   gnu: Add emacs-tagedit.
>>   gnu: Add emacs-perspective.
>>   gnu: Add emacs-solarized-theme.
>>
>>  gnu/packages/emacs.scm | 399 +++++++++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 399 insertions(+)
>
> These look good to me.

+1

Thanks for this nice addition!

Ludo’.

Re: [PATCH 00/17] Emacs packages!

[Alex Kost]

Ricardo Wurmus (2016-07-13 00:04 +0300) wrote:

> Hi Guix,
>
> here are almost all of the remaining Emacs packages that I previously
> installed via package.el.  I hope you find them useful!
>
> ~~ Ricardo
>
> Ricardo Wurmus (17):
>   gnu: Add emacs-el-mock.
>   gnu: Add emacs-espuds.
>   gnu: Add emacs-expand-region.
>   gnu: Add emacs-fill-column-indicator.
>   gnu: Add emacs-znc.
>   gnu: Add emacs-paren-face.
>   gnu: Add emacs-page-break-lines.
>   gnu: Add emacs-simple-httpd.
>   gnu: Add emacs-skewer-mode.
>   gnu: Add emacs-rich-minority.
>   gnu: Add emacs-smart-mode-line.
>   gnu: Add emacs-shut-up.
>   gnu: Add emacs-undercover.
>   gnu: Add emacs-shell-switcher.
>   gnu: Add emacs-tagedit.
>   gnu: Add emacs-perspective.
>   gnu: Add emacs-solarized-theme.

Overall, the packages look good to me, thanks!

My main question is about adding to inputs libraries that are not needed
for the packages themselves, as I wrote in the replies.

-- 
Alex, who will also add Emacs packages he uses... someday :-)

Re: [PATCH 00/17] Emacs packages!

[Ricardo Wurmus]

Alex Kost <alezost@gmail.com> writes:

> Ricardo Wurmus (2016-07-13 00:04 +0300) wrote:
>
>> Hi Guix,
>>
>> here are almost all of the remaining Emacs packages that I previously
>> installed via package.el.  I hope you find them useful!
>>
>> ~~ Ricardo
>>
>> Ricardo Wurmus (17):
>>   gnu: Add emacs-el-mock.
>>   gnu: Add emacs-espuds.
>>   gnu: Add emacs-expand-region.
>>   gnu: Add emacs-fill-column-indicator.
>>   gnu: Add emacs-znc.
>>   gnu: Add emacs-paren-face.
>>   gnu: Add emacs-page-break-lines.
>>   gnu: Add emacs-simple-httpd.
>>   gnu: Add emacs-skewer-mode.
>>   gnu: Add emacs-rich-minority.
>>   gnu: Add emacs-smart-mode-line.
>>   gnu: Add emacs-shut-up.
>>   gnu: Add emacs-undercover.
>>   gnu: Add emacs-shell-switcher.
>>   gnu: Add emacs-tagedit.
>>   gnu: Add emacs-perspective.
>>   gnu: Add emacs-solarized-theme.
>
> Overall, the packages look good to me, thanks!
>
> My main question is about adding to inputs libraries that are not needed
> for the packages themselves, as I wrote in the replies.

Thank you for the review.

I added inputs that are needed for the tests mostly because I didn’t
understand the error messages or warnings during the build phase.  I
wanted to avoid skipped files in the compilation process, so I added all
these development inputs like “espuds”.

It’s good to know I may leave them off.  Thanks for the helpful
comments.  I’ll update the patches and push them.

~~ Ricardo