Re: [PATCH] gnu: Add reptyr.

[Leo Famulari <leo@famulari.name>]

On Fri, Jul 08, 2016 at 02:38:36PM -0500, Alex Griffin wrote:
> This patch adds reptyr, a tool for reparenting a running program to a
> new terminal. I put it in screen.scm because it is usually used to move
> a process into a screen or tmux session.

Thank you, I will use this :)

> Also somewhat related, I think the file tmux.scm should merge with
> screen.scm.

If we are considering moving these packages around, I think that
screen.scm and tmux.scm should go into terminals.scm. But, I also think
that this patch should not be held up by that discussion.

> +    (arguments
> +     '(#:tests? #f

Why skip the tests? We prefer to run tests whenever possible. Otherwise,
please add a comment explaining why. For example "No test suite."

> +       #:phases (alist-delete 'configure %standard-phases)))

This is short and sweet, but we like to use modify-phases for
consistency.

> +    (description
> +     "reptyr is a utility for taking an existing running program and attaching
> +it to a new terminal.  Started a long-running process over ssh, but have to
> +leave and don't want to interrupt it?  Just start a screen, use reptyr to grab
> +it, and then kill the ssh session and head on home.")

We should capitalize the beginning of the description, and I would also
wrap 'ssh' and 'screen' in texinfo:

@code{ssh}
@code{screen}