From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] gnu: Add di. Date: Mon, 4 Jul 2016 15:04:46 -0400 Message-ID: <20160704190446.GB8480@jasmine> References: <87poqvam4v.fsf@hecubus.retroj.net> <20160703210212.GA22355@jasmine> <87eg7a9y7e.fsf@hecubus.retroj.net> <87y45i83pi.fsf@hecubus.retroj.net> <87eg79kims.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37654) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bK9Az-000419-Mh for guix-devel@gnu.org; Mon, 04 Jul 2016 15:05:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bK9Av-0001Gl-FF for guix-devel@gnu.org; Mon, 04 Jul 2016 15:05:00 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:48515) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bK9Au-0001GS-5Z for guix-devel@gnu.org; Mon, 04 Jul 2016 15:04:57 -0400 Content-Disposition: inline In-Reply-To: <87eg79kims.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Alex Kost Cc: guix-devel@gnu.org, John J Foerch On Mon, Jul 04, 2016 at 09:43:55AM +0300, Alex Kost wrote: > John J Foerch (2016-07-04 06:47 +0300) wrote: > > A test relating to an included perl module Filesys::di fails. I hadn't > > intended to include that module in the package, as all I'm interested in > > is the 'di' binary. Given that, I would suggest that we bypass the > > tests. > > As for me, I would also disable the tests. All these handmade Makefiles > in all sub-directories are a nightmare. I think trying to figure out > what is needed to run the tests doesn't worth it. I agree that hand-carved Makefiles are difficult to work with. The failing Perl-related test runs successfully if Perl is added to the environment. However, there is another failure later on: make[1]: Leaving directory '/tmp/guix-build-di-4.42.drv-0/di-4.42/C' make -e tests.done make[1]: Entering directory '/tmp/guix-build-di-4.42.drv-0/di-4.42' ## running tests CC=gcc DC="skip" \ ./mkconfig/runtests.sh ./tests.d mkconfig version 1.27 ## locating valid shells /gnu/store/b1yqjimbdh5bf9jnizd4h7yf110744j2-bash-4.3.42/bin/bash [bash4 4.3.42(1)-release] (ok) /gnu/store/b1yqjimbdh5bf9jnizd4h7yf110744j2-bash-4.3.42/bin/sh [sh-bash4 4.3.42(1)-release] (ok) buildsh ... build w/mkconfig.sh ... bash4 C* sh-bash4 C* ... failed ## stopping tests due to failures in ./tests.d/ pass 1 1 tests 1 failures Makefile:116: recipe for target 'tests.done' failed make[1]: *** [tests.done] Error 1 make[1]: Leaving directory '/tmp/guix-build-di-4.42.drv-0/di-4.42' Makefile:112: recipe for target 'test' failed make: *** [test] Error 2 phase `check' failed after 64.5 seconds I skimmed 'mkconfig/runtests.sh', but I don't understand it well enough to debug it. If the source code is still maintained, I bet the authors will be willing to help. They express interest in testing and portability on the web page. But if everyone else prefers to skip the tests, I won't object :)