From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH 1/2] gnu: testdisk: Add optional dependencies. Date: Sun, 3 Jul 2016 16:22:23 -0400 Message-ID: <20160703202223.GB26140@jasmine> References: <20160703162555.19342-1-rekado@elephly.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43761) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJnuY-0007d5-BG for guix-devel@gnu.org; Sun, 03 Jul 2016 16:22:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bJnuT-0007dn-Bp for guix-devel@gnu.org; Sun, 03 Jul 2016 16:22:38 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:34159) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJnuS-0007ci-59 for guix-devel@gnu.org; Sun, 03 Jul 2016 16:22:33 -0400 Content-Disposition: inline In-Reply-To: <20160703162555.19342-1-rekado@elephly.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: guix-devel@gnu.org On Sun, Jul 03, 2016 at 06:25:54PM +0200, Ricardo Wurmus wrote: > * gnu/packages/admin.scm (testdisk)[inputs]: Add ntfs-3g and libjpeg. > --- > gnu/packages/admin.scm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm > index 415a35a..2014ecb 100644 > --- a/gnu/packages/admin.scm > +++ b/gnu/packages/admin.scm > @@ -1149,9 +1149,11 @@ characters can be replaced as well, as can UTF-8 characters.") > "0v1jap83f5h99zv01v3qmqm160d36n4ysi0gyq7xzb3mqgmw75x5")))) > (build-system gnu-build-system) > (inputs > - `(;; ("ntfs" ,ntfs) > + `(("ntfs-3g" ,ntfs-3g) > ("util-linux" ,util-linux) > ("openssl" ,openssl) > + ;; FIXME: add reiserfs > + ("libjpeg" ,libjpeg) It already includes libjpeg ... > ("zlib" ,zlib) > ("e2fsprogs" ,e2fsprogs) > ("libjpeg" ,libjpeg) ... here ;) So it should add ntfs-3g and the comment about reiserfs, right?