From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] services: Add rngd service.
Date: Sat, 2 Jul 2016 21:42:31 -0400
Message-ID: <20160703014231.GA1178@jasmine>
References: <20160703001623.27550-1-david@craven.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48677)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bJWQq-0007sh-3u
	for guix-devel@gnu.org; Sat, 02 Jul 2016 21:42:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bJWQm-0007Mk-08
	for guix-devel@gnu.org; Sat, 02 Jul 2016 21:42:47 -0400
Received: from out3-smtp.messagingengine.com ([66.111.4.27]:35242)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bJWQj-0007MU-ND
	for guix-devel@gnu.org; Sat, 02 Jul 2016 21:42:43 -0400
Content-Disposition: inline
In-Reply-To: <20160703001623.27550-1-david@craven.ch>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org

On Sun, Jul 03, 2016 at 02:16:23AM +0200, David Craven wrote:
> * gnu/services/base.scm (rngd-service): New service.
> * gnu/packages/linux.scm (rng-tools): New package.

Thanks for taking this on!

Can you split this into 3 separate commits? One to alphabetize the
module imports in linux.scm, one to add rng-tools, and one to add
rngd-service?

Also, can you document the service in doc/guix.texi?

> +(define-public rng-tools

This package looks good to me, although I didn't try to build it yet.

> --- a/gnu/services/base.scm
> +++ b/gnu/services/base.scm
> @@ -31,7 +31,7 @@
>    #:use-module (gnu system mapped-devices)
>    #:use-module (gnu packages admin)
>    #:use-module ((gnu packages linux)
> -                #:select (eudev kbd e2fsprogs lvm2 fuse alsa-utils crda gpm))
> +                #:select (alsa-utils crda eudev e2fsprogs fuse gpm kbd lvm2 rng-tools))
>    #:use-module ((gnu packages base)
>                  #:select (canonical-package glibc))
>    #:use-module (gnu packages package-management)
> @@ -95,6 +95,7 @@
>              gpm-service
>  
>              urandom-seed-service
> +            rngd-service

I will let someone with more experience writing services review this
part.