all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] services: Add rngd service.
Date: Sat, 2 Jul 2016 21:42:31 -0400	[thread overview]
Message-ID: <20160703014231.GA1178@jasmine> (raw)
In-Reply-To: <20160703001623.27550-1-david@craven.ch>

On Sun, Jul 03, 2016 at 02:16:23AM +0200, David Craven wrote:
> * gnu/services/base.scm (rngd-service): New service.
> * gnu/packages/linux.scm (rng-tools): New package.

Thanks for taking this on!

Can you split this into 3 separate commits? One to alphabetize the
module imports in linux.scm, one to add rng-tools, and one to add
rngd-service?

Also, can you document the service in doc/guix.texi?

> +(define-public rng-tools

This package looks good to me, although I didn't try to build it yet.

> --- a/gnu/services/base.scm
> +++ b/gnu/services/base.scm
> @@ -31,7 +31,7 @@
>    #:use-module (gnu system mapped-devices)
>    #:use-module (gnu packages admin)
>    #:use-module ((gnu packages linux)
> -                #:select (eudev kbd e2fsprogs lvm2 fuse alsa-utils crda gpm))
> +                #:select (alsa-utils crda eudev e2fsprogs fuse gpm kbd lvm2 rng-tools))
>    #:use-module ((gnu packages base)
>                  #:select (canonical-package glibc))
>    #:use-module (gnu packages package-management)
> @@ -95,6 +95,7 @@
>              gpm-service
>  
>              urandom-seed-service
> +            rngd-service

I will let someone with more experience writing services review this
part.

  reply	other threads:[~2016-07-03  1:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-03  0:16 [PATCH] services: Add rngd service David Craven
2016-07-03  1:42 ` Leo Famulari [this message]
2016-07-03  2:05   ` [PATCH 1/3] gnu: Reorder imports alphabetically David Craven
2016-07-03 21:31     ` Leo Famulari
2016-07-03 21:50       ` David Craven
2016-07-03  2:21   ` [PATCH] services: Add rngd service David Craven
2016-07-03  2:26   ` [PATCH 2/3] gnu: Add rng-tools 5 David Craven
2016-07-03 21:31     ` Leo Famulari
2016-07-03  2:26   ` [PATCH 3/3] services: Add rngd-service David Craven
2016-07-03 18:25   ` [PATCH 3/4] " David Craven
2016-07-05  9:11     ` Ludovic Courtès
2016-07-03 18:25   ` [PATCH 4/4] build: Ignore texi2pdf temporary files David Craven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160703014231.GA1178@jasmine \
    --to=leo@famulari.name \
    --cc=david@craven.ch \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.