From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH v3] gnu: Add python-prompt-toolkit, python2-prompt-toolkit.
Date: Wed, 29 Jun 2016 22:23:32 -0400
Message-ID: <20160630022332.GA6667@jasmine>
References: <20160628101945.4225c7a5@scratchpost.org>
	<20160629094040.01b99f6a@scratchpost.org>
	<20160629113033.5297f1e0@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51768)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bIRe0-0003hF-0Q
	for guix-devel@gnu.org; Wed, 29 Jun 2016 22:23:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bIRdw-0004uR-GC
	for guix-devel@gnu.org; Wed, 29 Jun 2016 22:23:55 -0400
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:40178)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bIRdv-0004n0-3U
	for guix-devel@gnu.org; Wed, 29 Jun 2016 22:23:52 -0400
Content-Disposition: inline
In-Reply-To: <20160629113033.5297f1e0@scratchpost.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org

On Wed, Jun 29, 2016 at 11:30:33AM +0200, Danny Milosavljevic wrote:
> On Wed, 29 Jun 2016 09:40:40 +0200
> Danny Milosavljevic <dannym+a@scratchpost.org> wrote:
> 
> > +(define-public python2-prompt-toolkit
> > +  (let ((base (package-with-python2 (strip-python2-variant python-prompt-toolkit))))
> > +    (package
> > +      (inherit base)
> > +      (native-inputs
> > +       `(("python2-setuptools" ,python2-setuptools)
> > +         ,@(package-native-inputs base))))))
> 
> 
> Hmm. Now that I made it a native input instead of propagated input, the python2-wcwidth that is compiled alongside python2-prompt-toolkit doesn't find setuptools anymore. Why?

In python-wcwidth and python-prompt-toolkit, the 'properties' field that
makes the python2-variant system work is missing. I missed that in my
review of python-wcwidth.

I'll push a follow up to that commit, and then push this patch with the
properties field added as well.