From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] gnu: Add python-prompt-toolkit, python2-prompt-toolkit.
Date: Sat, 25 Jun 2016 14:17:32 -0400
Message-ID: <20160625181732.GA23844@jasmine>
References: <20160622150031.00fa9615@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50674)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bGs9Q-000353-HJ
	for guix-devel@gnu.org; Sat, 25 Jun 2016 14:17:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bGs9M-0007LG-9M
	for guix-devel@gnu.org; Sat, 25 Jun 2016 14:17:51 -0400
Received: from out3-smtp.messagingengine.com ([66.111.4.27]:53526)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bGs9K-0007KF-Vs
	for guix-devel@gnu.org; Sat, 25 Jun 2016 14:17:48 -0400
Content-Disposition: inline
In-Reply-To: <20160622150031.00fa9615@scratchpost.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Danny Milosavljevic <dannym+a@scratchpost.org>
Cc: guix-devel@gnu.org

On Wed, Jun 22, 2016 at 03:00:31PM +0200, Danny Milosavljevic wrote:
> * gnu/packages/python.scm (python-prompt-toolkit, python2-prompt-toolkit): New variables.

Thanks! Can you rebase the patch on the current master branch? There
have been changes in python.scm and the patch no longer applies.

> +(define-public python-prompt-toolkit
> + (package
> +  (name "python-prompt-toolkit")
> +  (version "1.0.0")

Why not use the latest release, 1.0.3?

> +  (inputs `(("python-six" ,python-six) ; for the tests

Dependencies used only for the test suite should be native-inputs.

> +  (synopsis
> +    "Library for building powerful interactive command lines in Python")

How about "Library for building command line interfaces in Python"? Or
did I misunderstand the meaning of "command lines"? Either way, we don't
need to describe them as "powerful".

> +  (description
> +    "Prompt-Toolkit is a library for building powerful interactive command lines in Python. 

Again, as above?

> +  (license bsd-2))) ; FIXME which BSD

Any progress on this?

> +
> +(define-public python2-prompt-toolkit
> +  (package
> +    (inherit (package-with-python2
> +              (strip-python2-variant python-prompt-toolkit)))
> +    (native-inputs `(("python2-setuptools" ,python2-setuptools)))))

If python-six becomes a native-input, we'll need to make sure we don't
clobber the inherited native-inputs here. Check python2-orator for an
example.