From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 08/10] gnu: Add python-email-validator and
	python2-email-validator.
Date: Sat, 25 Jun 2016 13:58:37 -0400
Message-ID: <20160625175837.GH22624@jasmine>
References: <20160623152004.24065-1-iyzsong@gmail.com>
	<20160623152004.24065-4-iyzsong@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46765)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bGrr1-0001Wz-WA
	for guix-devel@gnu.org; Sat, 25 Jun 2016 13:58:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bGrr1-0002DT-1s
	for guix-devel@gnu.org; Sat, 25 Jun 2016 13:58:51 -0400
Received: from out3-smtp.messagingengine.com ([66.111.4.27]:43886)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bGrr0-0002C8-Rc
	for guix-devel@gnu.org; Sat, 25 Jun 2016 13:58:50 -0400
Content-Disposition: inline
In-Reply-To: <20160623152004.24065-4-iyzsong@gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@gmail.com>
Cc: guix-devel@gnu.org

On Thu, Jun 23, 2016 at 11:20:02PM +0800, 宋文武 wrote:
> * gnu/packages/python.scm (python-email-validator)
> (python2-email-validator): New variables.
> ---
>  gnu/packages/python.scm | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
> 
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index ff3cb99..68123cc 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -9468,3 +9468,35 @@ It supports TSIG authenticated messages and EDNS0.")
>  (define-public python2-dnspython
>    (package-with-python2 python-dnspython))
>  
> +(define-public python-email-validator
> +  (package
> +    (name "python-email-validator")
> +    (version "1.0.1")
> +    (source
> +     (origin (method url-fetch)
> +             (uri (pypi-uri "email_validator" version))
> +             (sha256
> +              (base32
> +               "0mn8jg5h8ifl8w6a6m0hq8kbk0mzw9vm054qfamkn89b3npz52qw"))))

The indentation should be shifted to the right.

> +    (build-system python-build-system)
> +    (arguments
> +     '(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'build 'use-dnspython
> +           (lambda _
> +             (substitute* "setup.py"
> +               (("dnspython3") "dnspython"))
> +             #t)))))
> +    (native-inputs
> +     `(("python-dnspython" ,python-dnspython)
> +       ("python-idna" ,python-idna)

Do dnspython and idna need to be native-inputs? Are they only used to
build?