From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] gnu: python-flask: Update to 0.11.1.
Date: Wed, 22 Jun 2016 14:50:36 -0400
Message-ID: <20160622185036.GA13667@jasmine>
References: <87inx1t6l6.fsf@dustycloud.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38422)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bFnEk-0005d0-EC
	for guix-devel@gnu.org; Wed, 22 Jun 2016 14:50:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bFnEe-0005FC-RT
	for guix-devel@gnu.org; Wed, 22 Jun 2016 14:50:53 -0400
Received: from out3-smtp.messagingengine.com ([66.111.4.27]:44309)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bFnEd-0005ER-CY
	for guix-devel@gnu.org; Wed, 22 Jun 2016 14:50:48 -0400
Content-Disposition: inline
In-Reply-To: <87inx1t6l6.fsf@dustycloud.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Christopher Allan Webber <cwebber@dustycloud.org>
Cc: guix-devel <guix-devel@gnu.org>

On Wed, Jun 22, 2016 at 01:35:17PM -0500, Christopher Allan Webber wrote:
> Note that the old URL scheme no longer seemed to work.
> 
> I'm not thrilled by the new URL "scheme".  It seems like more work to
> update with each version bump.  I'm not sure what the solution is?

Please review Ben's 'pypi-origin' patch :)

http://lists.gnu.org/archive/html/guix-devel/2016-06/msg00724.html

>      (source (origin
>                (method url-fetch)
> -              (uri (pypi-uri "Flask" version))
> +              (uri
> +               (string-append
> +                "https://pypi.python.org/packages/55/8a/"
> +                "78e165d30f0c8bb5d57c429a30ee5749825ed461ad6c959688872643ffb3/"
> +                "Flask-0.11.1.tar.gz"))

In the meantime, I think it's best to keep the hash on its own line, to
reduce noise in the commit log if we do more updates in this format.

"55/8a/78e1..."

> -       ("python-werkzeug" ,python-werkzeug)))
> +       ("python-werkzeug" ,python-werkzeug)
> +       ("python-click" ,python-click)))

Remember to mention the new dependency in the commit message!