[PATCH] gnu: Add python2-jsonrpclib

[PATCH] gnu: Add python2-jsonrpclib

[Daniel Pimentel]

[-- Attachment #1: Type: text/plain, Size: 101 bytes --]

Hi guix,

Add python2-jsonrpclib package for Guix in attach.

Thanks,

-- 
Daniel Pimentel (aka d4n1)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-python-jsonrpclib.patch --]
[-- Type: text/x-diff; name=0001-gnu-Add-python-jsonrpclib.patch, Size: 1939 bytes --]

From 5e96d11f9569c111a9c07fa82432d5899a2e7bdc Mon Sep 17 00:00:00 2001
From: Daniel Pimentel <d4n1@member.fsf.org>
Date: Thu, 9 Jun 2016 21:08:23 -0300
Subject: [PATCH] gnu: Add python-jsonrpclib

---
 gnu/packages/python.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index dfbf2cc..0ee6ade 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -20,6 +20,7 @@
 ;;; Copyright © 2016 Danny Milosavljevic <dannym+a@scratchpost.org>
 ;;; Copyright © 2016 Lukas Gradl <lgradl@openmailbox.org>
 ;;; Copyright © 2016 Hartmut Goebel <h.goebel@crazy-compilers.com>
+;;; Copyright © 2016 Daniel Pimentel <d4n1@d4n1.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -9009,3 +9010,28 @@ focus on event-based network programming and multiprotocol integration.")
 
 (define-public python2-twisted
   (package-with-python2 python-twisted))
+
+(define-public python2-jsonrpclib
+  (package
+    (name "python2-jsonrpclib")
+    (version "0.1.7")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://pypi.python.org/packages/source/j/jsonrpclib/jsonrpclib-"
+                    version ".tar.gz"))
+              (sha256
+               (base32
+                "02vgirw2bcgvpcxhv5hf3yvvb4h5wzd1lpjx8na5psdmaffj6l3z"))))
+    (build-system python-build-system)
+    (inputs
+     `(("python-setuptools" ,python-setuptools)))
+    (arguments `(#:tests? #f))
+    (home-page "https://github.com/joshmarshall/jsonrpclib/")
+    (synopsis "Implementation of JSON-RPC specification for Python")
+    (description
+     "This library is an implementation of the JSON-RPC specification. 
+It supports both the original 1.0 specification, as well as the 
+new (proposed) 2.0 spec, which includes batch submission, keyword arguments,
+ etc.")
+    (license license:expat)))
-- 
2.7.4

Re: [PATCH] gnu: Add python2-jsonrpclib

[Ben Woodcroft]

On 10/06/16 10:14, Daniel Pimentel wrote:
> Hi guix,
>
> Add python2-jsonrpclib package for Guix in attach.
>
> Thanks,

Thank you.

I had a brief look over it. Can you add a comment as to why the tests 
were not run please?

I also note that this is a python2 library according to the package 
name, but it appears to build with the default python (3). Does it work 
on python 2 and 3?

Thanks,
ben

Re: [PATCH] gnu: Add python2-jsonrpclib

[d4n1]

[-- Attachment #1: Type: text/html, Size: 1348 bytes --]

Re: [PATCH] gnu: Update python2-jsonrpclib

[Daniel Pimentel]

[-- Attachment #1: Type: text/plain, Size: 63 bytes --]

Update patch python2-jsonrpclib

-- 
Daniel Pimentel (aka d4n1)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0005-gnu-Update-python2-jsonrpclib.patch --]
[-- Type: text/x-diff; name=0005-gnu-Update-python2-jsonrpclib.patch, Size: 1041 bytes --]

From 4abd2effdb7b75ef57109c53b9983186c214b0dd Mon Sep 17 00:00:00 2001
From: Daniel Pimentel <d4n1@d4n1.org>
Date: Tue, 14 Jun 2016 16:51:00 -0300
Subject: [PATCH 5/5] gnu: Update python2-jsonrpclib

---
 gnu/packages/python.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index e054c63..33bc932 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -9025,8 +9025,10 @@ focus on event-based network programming and multiprotocol integration.")
                 "02vgirw2bcgvpcxhv5hf3yvvb4h5wzd1lpjx8na5psdmaffj6l3z"))))
     (build-system python-build-system)
     (inputs
-     `(("python-setuptools" ,python-setuptools)))
-    (arguments `(#:tests? #f))
+     `(("python2-setuptools" ,python2-setuptools)))
+    (arguments
+     `(#:tests? #f
+                #:python ,python-2))
     (home-page "https://github.com/joshmarshall/jsonrpclib/")
     (synopsis "Implementation of JSON-RPC specification for Python")
     (description
-- 
2.7.4

Re: [PATCH] gnu: Update python2-jsonrpclib (refactor)

[Daniel Pimentel]

[-- Attachment #1: Type: text/plain, Size: 55 bytes --]

Add python2-jsonrpclib.

-- 
Daniel Pimentel (aka d4n1)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-python2-jsonrpclib.patch --]
[-- Type: text/x-diff; name=0001-gnu-Add-python2-jsonrpclib.patch, Size: 2038 bytes --]

From 9e8a67f7ad8c25ba8c45b52cf800d28a5322c362 Mon Sep 17 00:00:00 2001
From: Daniel Pimentel <d4n1@d4n1.org>
Date: Thu, 16 Jun 2016 09:08:24 -0300
Subject: [PATCH] gnu: Add python2-jsonrpclib

---
 gnu/packages/python.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 4f18680..6dece06 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -20,6 +20,7 @@
 ;;; Copyright © 2016 Danny Milosavljevic <dannym+a@scratchpost.org>
 ;;; Copyright © 2016 Lukas Gradl <lgradl@openmailbox.org>
 ;;; Copyright © 2016 Hartmut Goebel <h.goebel@crazy-compilers.com>
+;;; Copyright © 2016 Daniel Pimentel <d4n1@d4n1.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -9216,3 +9217,30 @@ specified in POSIX.1-2001 and POSIX.1-2008.")
     (inherit (package-with-python2
               (strip-python2-variant python-wcwidth)))
     (native-inputs `(("python2-setuptools" ,python2-setuptools)))))
+
+(define-public python2-jsonrpclib
+  (package
+    (name "python2-jsonrpclib")
+    (version "0.1.7")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://pypi.python.org/packages/source/j/jsonrpclib/jsonrpclib-"
+                    version ".tar.gz"))
+              (sha256
+               (base32
+                "02vgirw2bcgvpcxhv5hf3yvvb4h5wzd1lpjx8na5psdmaffj6l3z"))))
+    (build-system python-build-system)
+    (inputs
+     `(("python2-setuptools" ,python2-setuptools)))
+    (arguments
+     `(#:tests? #f
+                #:python ,python-2))
+    (home-page "https://github.com/joshmarshall/jsonrpclib/")
+    (synopsis "Implementation of JSON-RPC specification for Python")
+    (description
+     "This library is an implementation of the JSON-RPC specification. 
+It supports both the original 1.0 specification, as well as the 
+new (proposed) 2.0 spec, which includes batch submission, keyword arguments,
+ etc.")
+    (license license:expat)))
-- 
2.7.4

Re: [PATCH] gnu: Update python2-jsonrpclib (refactor)

[Leo Famulari]

On Thu, Jun 16, 2016 at 09:10:09AM -0300, Daniel Pimentel wrote:
> Subject: [PATCH] gnu: Add python2-jsonrpclib

Thanks! Applied as 0de78c95 with the following minor changes:

> +              (uri (string-append
> +                    "https://pypi.python.org/packages/source/j/jsonrpclib/jsonrpclib-"
> +                    version ".tar.gz"))

I re-wrapped the URL to keep it under 80 characters.

> +    (inputs
> +     `(("python2-setuptools" ,python2-setuptools)))

I made setuptools a native-input, since it doesn't appear to be used at
run-time.

> +    (arguments
> +     `(#:tests? #f
> +                #:python ,python-2))

I shifted the indentation left to match the previous line.

> +    (license license:expat)))

I changed this to asl2.0, the Apache License 2.0, since that's what in
LICENSE.txt.

[PATCH 1/1] gnu: Update python2-jsonrpclib

[Daniel Pimentel]

[-- Attachment #1: Type: text/plain, Size: 135 bytes --]

> Thanks! Applied as 0de78c95 with the following minor changes:

thanks

I sent in attach this changes.

-- 
Daniel Pimentel (aka d4n1)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0006-add-python2-jsonrpclib.patch --]
[-- Type: text/x-diff; name=0006-add-python2-jsonrpclib.patch, Size: 1705 bytes --]

From 1bd39dbf752316f4b3e513645245409646e7f6f0 Mon Sep 17 00:00:00 2001
From: Daniel Pimentel <d4n1@d4n1.org>
Date: Fri, 17 Jun 2016 21:34:55 -0300
Subject: [PATCH 6/7] add python2-jsonrpclib * gnu/packages/python.py: add
 pypi-uri, change license.

---
 gnu/packages/python.scm | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 21cb0c7..5dd27b4 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -9224,18 +9224,16 @@ specified in POSIX.1-2001 and POSIX.1-2008.")
     (version "0.1.7")
     (source (origin
               (method url-fetch)
-              (uri (string-append
-                    "https://pypi.python.org/packages/source/j/jsonrpclib/jsonrpclib-"
-                    version ".tar.gz"))
+              (uri (pypi-uri "jsonrpclib" version))
               (sha256
                (base32
                 "02vgirw2bcgvpcxhv5hf3yvvb4h5wzd1lpjx8na5psdmaffj6l3z"))))
     (build-system python-build-system)
-    (inputs
+    (native-inputs
      `(("python2-setuptools" ,python2-setuptools)))
     (arguments
      `(#:tests? #f
-                #:python ,python-2))
+       #:python ,python-2))
     (home-page "https://github.com/joshmarshall/jsonrpclib/")
     (synopsis "Implementation of JSON-RPC specification for Python")
     (description
@@ -9243,7 +9241,7 @@ specified in POSIX.1-2001 and POSIX.1-2008.")
 It supports both the original 1.0 specification, as well as the 
 new (proposed) 2.0 spec, which includes batch submission, keyword arguments,
  etc.")
-    (license license:expat)))
+    (license license:asl2.0)))
 
 (define-public python2-pbkdf2
   (package
-- 
2.7.4


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: 0007-add-python2-jsonrpclib.patch --]
[-- Type: text/x-diff; name=0007-add-python2-jsonrpclib.patch, Size: 805 bytes --]

From 39a3dc3435e95c7d5c67361aeba2429eb6518b07 Mon Sep 17 00:00:00 2001
From: Daniel Pimentel <d4n1@d4n1.org>
Date: Fri, 17 Jun 2016 21:39:23 -0300
Subject: [PATCH 7/7] add python2-jsonrpclib * gnu/packages/python.py: change
 license.

---
 gnu/packages/python.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 5dd27b4..0959ecb 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -9241,7 +9241,7 @@ specified in POSIX.1-2001 and POSIX.1-2008.")
 It supports both the original 1.0 specification, as well as the 
 new (proposed) 2.0 spec, which includes batch submission, keyword arguments,
  etc.")
-    (license license:asl2.0)))
+    (license asl2.0)))
 
 (define-public python2-pbkdf2
   (package
-- 
2.7.4