From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [Patch] Tmux Themepack Date: Fri, 17 Jun 2016 20:00:30 -0400 Message-ID: <20160618000030.GA19441@jasmine> References: <871t46gtte.fsf@mailerver.i-did-not-set--mail-host-address--so-tickle-me> <8737ok6ue5.fsf@mdc-berlin.de> <87ziqqfa6y.fsf@mailerver.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="LQksG6bCIzRHxTLp" Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40005) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bE3gs-0000da-BK for guix-devel@gnu.org; Fri, 17 Jun 2016 20:00:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bE3go-00007B-95 for guix-devel@gnu.org; Fri, 17 Jun 2016 20:00:45 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:47984) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bE3gm-00005h-UN for guix-devel@gnu.org; Fri, 17 Jun 2016 20:00:42 -0400 Content-Disposition: inline In-Reply-To: <87ziqqfa6y.fsf@mailerver.i-did-not-set--mail-host-address--so-tickle-me> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Matthew Jordan Cc: guix-devel --LQksG6bCIzRHxTLp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Jun 12, 2016 at 04:01:41PM -0400, Matthew Jordan wrote: > Good Day, > > The package has been updated inline with suggested changes. Thanks! Can you test the attached revision on your patch? Here are the changes: > +(define-public tmux-themepack > + (let ((commit "03a372866f7677f7fe63bcee140b48b9fd372c48")) > + (package > + (name "tmux-themepack") > + (version (string-append "1.0.0." (string-take commit 7))) ;; No version tags I think we need to improve 7.6.3 Version Numbers in the manual. *Nobody* gets it right the first time :) With no upstream revision, we use 0.0.0 as the version (this should be documented). We also include a Guix package revision number, which seems to begin at 1. It ends up looking like this: (define-public tmux-themepack (let ((commit "03a372866f7677f7fe63bcee140b48b9fd372c48") (revision "1")) (package (name "tmux-themepack") (version (string-append "0.0.0-" revision "." (string-take commit 7))) ;; No version tags > + `(#:tests? #f I added the comment "no test suite". > + (replace 'install > + (lambda* (#:key inputs outputs #:allow-other-keys) Since no inputs were referred to, I remove 'inputs'. > + (let* ((out (string-append > + (assoc-ref outputs "out") > + "/share/" ,name "-" ,version))) > + (mkdir-p out) This (mkdir-p) does not appear to be needed, so I removed it. --LQksG6bCIzRHxTLp Content-Type: text/x-diff; charset=iso-8859-1 Content-Disposition: attachment; filename="0001-gnu-Add-Tmux-Themepack.patch" Content-Transfer-Encoding: 8bit >From f3ee545ac6734d2e20b02dffc7fa808973dae8dc Mon Sep 17 00:00:00 2001 From: Matthew Jordan Date: Sun, 12 Jun 2016 16:01:41 -0400 Subject: [PATCH] gnu: Add Tmux Themepack. * gnu/packages/tmux.scm (tmux-themepack): New variable. --- gnu/packages/tmux.scm | 42 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/gnu/packages/tmux.scm b/gnu/packages/tmux.scm index d89fc16..c15d683 100644 --- a/gnu/packages/tmux.scm +++ b/gnu/packages/tmux.scm @@ -1,6 +1,7 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2013 Cyril Roelandt ;;; Copyright © 2016 Efraim Flashner +;;; Copyright © 2016 Matthew Jordan ;;; ;;; This file is part of GNU Guix. ;;; @@ -21,11 +22,16 @@ #:use-module (guix licenses) #:use-module (guix packages) #:use-module (guix download) + #:use-module (guix git-download) + #:use-module (guix utils) + #:use-module (guix build utils) #:use-module (guix build-system gnu) #:use-module (gnu packages) + #:use-module (gnu packages base) #:use-module (gnu packages libevent) #:use-module (gnu packages ncurses)) + (define-public tmux (package (name "tmux") @@ -50,3 +56,39 @@ windows), each running a separate program, to be created, accessed, and controlled from a single screen. tmux may be detached from a screen and continue running in the background, then later reattached.") (license isc))) + +(define-public tmux-themepack + (let ((commit "03a372866f7677f7fe63bcee140b48b9fd372c48") + (revision "1")) + (package + (name "tmux-themepack") + (version (string-append "0.0.0-" + revision "." + (string-take commit 7))) ;; No version tags + (source (origin + (method git-fetch) + (uri (git-reference + (url + (string-append "https://github.com/jimeh/" name ".git")) + (commit commit))) + (sha256 + (base32 + "1d3k87mq5lca042jbap5kxskjy3kg79wjhhpnm6jacbn3anc67zl")) + (file-name (string-append name "-" version "-checkout")))) + (build-system gnu-build-system) + (arguments + `(#:tests? #f ; no test suite + #:phases (modify-phases %standard-phases + (delete 'configure) + (delete 'build) + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out (string-append + (assoc-ref outputs "out") + "/share/" ,name "-" ,version))) + (copy-recursively "." out))))))) + (home-page "https://github.com/jimeh/tmux-themepack") + (synopsis "Collection of themes for Tmux") + (description "A collection of various themes for Tmux.") + (license + (non-copyleft "http://www.wtfpl.net/txt/copying/"))))) -- 2.9.0 --LQksG6bCIzRHxTLp--