From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] gnu: Add rottlog.
Date: Fri, 17 Jun 2016 14:39:36 -0400
Message-ID: <20160617183936.GA11491@jasmine>
References: <87lh23andj.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36076)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bDygL-0006yi-MA
	for guix-devel@gnu.org; Fri, 17 Jun 2016 14:39:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bDygI-0006rb-Gh
	for guix-devel@gnu.org; Fri, 17 Jun 2016 14:39:53 -0400
Content-Disposition: inline
In-Reply-To: <87lh23andj.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Jan Nieuwenhuizen <janneke@gnu.org>
Cc: guix-devel@gnu.org

On Fri, Jun 17, 2016 at 04:41:44PM +0200, Jan Nieuwenhuizen wrote:
> It `builds' and installs...now to figure out how to configure and hook
> it up with mcron and how to run mcron.

Ludovic sent a WIP mcron service to guix-devel recently; you might take
a look at that. Alternatively, I run mcron for my user only and it works
as expected.

> * gnu/packages/logging.scm (rottlog): New variable.

> +    (inputs `(("util-linux" ,util-linux) ; cal
> +              ("texinfo" ,texinfo)))
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "mirror://gnu/rottlog/rottlog-" version
> +                                  ".tar.gz"))
> +              (sha256
> +               (base32
> +                "0751mb9l2f0jrk3vj6q8ilanifd121dliwk0c34g8k0dlzsv3kd7"))
> +              (patches (search-patches "rottlog.patch"))))

That patch is missing from this patch ;)

> +    (arguments
> +     '(#:configure-flags
> +       (list (string-append "ROTT_ETCDIR=" %output "/etc/rottlog"))))
> +    (build-system gnu-build-system)

Nit-picky, but I think the order should be: source, build-system,
arguments, inputs. At least, source should be first.

> +    (description
> +     "GNU Rot[t]log is designed to simplify administration of systems that

I think the description should contain the string "Rottlog" or
"rottlog", to make searching easier.