Re: [PATCH] gnu: Add rottlog.

[Leo Famulari <leo@famulari.name>]

On Fri, Jun 17, 2016 at 04:41:44PM +0200, Jan Nieuwenhuizen wrote:
> It `builds' and installs...now to figure out how to configure and hook
> it up with mcron and how to run mcron.

Ludovic sent a WIP mcron service to guix-devel recently; you might take
a look at that. Alternatively, I run mcron for my user only and it works
as expected.

> * gnu/packages/logging.scm (rottlog): New variable.

> +    (inputs `(("util-linux" ,util-linux) ; cal
> +              ("texinfo" ,texinfo)))
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "mirror://gnu/rottlog/rottlog-" version
> +                                  ".tar.gz"))
> +              (sha256
> +               (base32
> +                "0751mb9l2f0jrk3vj6q8ilanifd121dliwk0c34g8k0dlzsv3kd7"))
> +              (patches (search-patches "rottlog.patch"))))

That patch is missing from this patch ;)

> +    (arguments
> +     '(#:configure-flags
> +       (list (string-append "ROTT_ETCDIR=" %output "/etc/rottlog"))))
> +    (build-system gnu-build-system)

Nit-picky, but I think the order should be: source, build-system,
arguments, inputs. At least, source should be first.

> +    (description
> +     "GNU Rot[t]log is designed to simplify administration of systems that

I think the description should contain the string "Rottlog" or
"rottlog", to make searching easier.