From mboxrd@z Thu Jan 1 00:00:00 1970 From: ng0 Subject: Re: syntax check before commit and patch: net-perl-psyc Date: Tue, 14 Jun 2016 12:39:11 +0000 Message-ID: <20160614123911.GC3999@khazad-dum> References: <20160613140750.GA11984@khazad-dum> <877fdshyiq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Fig2xvG2VGoz8o/s" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40738) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCncp-0007KH-Rj for guix-devel@gnu.org; Tue, 14 Jun 2016 08:39:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCnck-0008PA-FR for guix-devel@gnu.org; Tue, 14 Jun 2016 08:39:22 -0400 Received: from 93-95-228-168.1984.is ([93.95.228.168]:45804 helo=beleriand.n0.is) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCnck-0008OH-2X for guix-devel@gnu.org; Tue, 14 Jun 2016 08:39:18 -0400 Received: by beleriand.n0.is (OpenSMTPD) with ESMTPSA id a565f93b TLS version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO for ; Tue, 14 Jun 2016 12:39:13 +0000 (UTC) Content-Disposition: inline In-Reply-To: <877fdshyiq.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org --Fig2xvG2VGoz8o/s Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2016-06-14(12:10:05+0200), Ludovic Court=C3=A8s wrote: > Hello! > > ng0 skribis: > > > the following is an insert minus the header etc of > > net-perl-psyc. Before I commit and send in a patch, I'd > > like to check if there's anything I can improve. > > Overall it looks good! > > > (replace > > 'install > > (lambda* (#:key outputs #:allow-other-keys) > > (let* ((out (assoc-ref outputs "out")) > > (doc (string-append out "/share/doc/perl-net-psyc"= )) > > (libpsyc (string-append out "/lib/psyc/ion")) > > (libperl (string-append out "/lib/perl5/site_perl/" > > ,(package-version perl))) > > (bin (string-append out "/bin"))) > > (copy-recursively "lib/perl5" libperl) > > (copy-recursively "lib/psycion" libpsyc) > > (copy-recursively "bin" bin) > > (install-file "cgi/psycpager" (string-append doc "/cgi"= )) > > (copy-recursively "contrib" (string-append doc "/contri= b")) > > (copy-recursively "hooks" (string-append doc "/hooks")) > > (copy-recursively "sdj" (string-append doc "/sdj")) > > (install-file "README.txt" doc) > > (install-file "TODO.txt" doc) > > #t))) > > Doesn=E2=80=99t =E2=80=9C./Build install=E2=80=9D do that? (This is what= =E2=80=98perl-build-system=E2=80=99 > does, see (guix build perl-build-system).) > No, as it's not existing in the perlpsyc repository, and the install above does what our gentoo overlay ebuild of Net-PSYC does, which the author of the software themselves maintains. ~/src/re-src/psyced/perlpsyc/INSTALL.txt: You can simply move the contents of bin and lib into the respective directories of /usr/local and things should work from there. You can also put things into /usr/depot, then add /usr/depot/bin to your PATH. You may want to install a perl interpreter. For a proper integration into your Unix distribution, reach out for your vendor team. > > (add-after 'install 'wrap-programs > > (lambda* (#:key outputs #:allow-other-keys) > > ;; Make sure all executables in "bin" find the = Perl modules > > ;; provided by this package at runtime. > > (let* ((out (assoc-ref outputs "out")) > > (bin (string-append out "/bin/")) > > (path (string-append out "/lib/perl5/sit= e_perl"))) > > (for-each (lambda (file) > > (wrap-program file > > `("PERL5LIB" ":" prefix (,path)= ))) > > (find-files bin "\\.*$")) > > ;; XXX: hooks/dpa2psyc,examples/{recvtest,sen= dtest}, > > ;; cgi/psycpager,contrib/{makenoise,keefchat > > ;; contrib/MovableTypeBlog/plugins/psyc.pl > > #t)))))) > > This reminds me that we should eventually update =E2=80=98perl-build-syst= em=E2=80=99 to > have a =E2=80=98wrap=E2=80=99 phase similar to that of =E2=80=98python-bu= ild-system=E2=80=99. > > Thanks, > Ludo=E2=80=99. > Thanks for taking the time to look into it. Would you know if other than the source of perl-build-system, the section 7= =2E2.6.1 "Locale Data Compatibility Considerations" and the section above (and below= ?) in the manual could serve as an explanation to the authors question of "Why do you wrap such a simple language as perl?" ? I know it becomes more obvious once you look more into details, but maybe y= ou have an explanation which wouldn't take so many turns as mine, or be too si= mple ("look at the source"). thanks, -- =E2=99=A5=E2=92=B6 ng0 For non-prism friendly talk find me on psyced.org / loupsycedyglgamf.onion --Fig2xvG2VGoz8o/s Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iF4EARYKAAYFAldf+u8ACgkQhhoAchyzrCC1AwD7B/Lk8iiYdzQGnwkuj7hXLgR5 0CqsNZOG3L4RpyaUTI0A/iLO/2UZfmVPBkNv5PkK9K1jWNE9zWVCgTi11W3VL3gJ =5/JA -----END PGP SIGNATURE----- --Fig2xvG2VGoz8o/s--