From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] gnu: Add awesome. Date: Mon, 13 Jun 2016 22:12:16 -0400 Message-ID: <20160614021216.GB16928@jasmine> References: <1465776755-16444-1-git-send-email-carlo@zancanaro.id.au> <1465778333-19689-1-git-send-email-carlo@zancanaro.id.au> <20160613154619.GA13902@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33775) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCdqE-0005i4-5z for guix-devel@gnu.org; Mon, 13 Jun 2016 22:12:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCdq8-0005A0-0o for guix-devel@gnu.org; Mon, 13 Jun 2016 22:12:33 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:57824) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCdq6-00059O-KM for guix-devel@gnu.org; Mon, 13 Jun 2016 22:12:27 -0400 Content-Disposition: inline In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Carlo Zancanaro Cc: guix-devel@gnu.org On Tue, Jun 14, 2016 at 10:57:41AM +1000, Carlo Zancanaro wrote: > On 14 June 2016 at 01:46, Leo Famulari wrote: > > > I think that imagemagick is only required while building, so it can be a > > 'native-input'. > > > > You can check what packages the built output refers to: $ guix gc > > --references $(./pre-inst-env guix build awesome) > > > > Imagemagick is not in the list. > > > > Thanks for this! I had assumed that the "guix lint" would tell me about > something like that, given the check "inputs-should-be-native". > > Is it possible for those references to be "wrong"? For there to be > something which is required at runtime, but doesn't show up in a "guix gc > --references" check? My understanding is that `guix gc --references` reports the references that it finds by scanning the store item you give as an argument (I haven't read the code). So, if the packaged software needs to refer to something but does not, you will not be warned by `guix gc --references`. >From ImageMagick, awesome uses the `convert` tool at build time. I skimmed the results of `grep -r convert` and I didn't notice any other uses of the tool, but I might have missed something. Can you double-check? > > I noticed that several of the files have the "or later" text. If they > > are all like that, we could use gpl2+. Did you check if there are any > > files with licenses besides GPL2+? > > > > The lua files (in lib/) don't have a license heading beyond a copyright > year/author in the luadoc tags. Everything which has a license heading > seems to be gpl2+ (I had missed the "or later" text, but I've updated it > now). Okay.