[PATCH] gnu: Add awesome.

[PATCH] gnu: Add awesome.

[Carlo Zancanaro]

* gnu/packages/awesome.scm (awesome): New variable.
---
 gnu/packages/awesome.scm | 93 ++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 93 insertions(+)
 create mode 100644 gnu/packages/awesome.scm

diff --git a/gnu/packages/awesome.scm b/gnu/packages/awesome.scm
new file mode 100644
index 0000000..6aa1f93
--- /dev/null
+++ b/gnu/packages/awesome.scm
@@ -0,0 +1,93 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2016 Carlo Zancanaro <carlo@zancanaro.id.au>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages awesome)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix build-system cmake)
+  #:use-module (guix build-system glib-or-gtk)
+  #:use-module (gnu packages freedesktop)
+  #:use-module (gnu packages glib)
+  #:use-module (gnu packages gperf)
+  #:use-module (gnu packages gtk)
+  #:use-module (gnu packages image)
+  #:use-module (gnu packages imagemagick)
+  #:use-module (gnu packages libevent)
+  #:use-module (gnu packages lua)
+  #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages xdisorg)
+  #:use-module (gnu packages xorg))
+
+(define-public awesome
+  (package
+    (name "awesome")
+    (version "3.4.15")
+    (source
+     (origin (method url-fetch)
+             (uri (string-append "https://awesome.naquadah.org/download/awesome-"
+                                 version ".tar.xz"))
+             (sha256
+              (base32
+               "1m910lr7wkw2dgzmirfvz7dasfswhhccdf65l21iiciv24c3w1bb"))))
+    (build-system cmake-build-system)
+    (native-inputs `(("pkg-config" ,pkg-config)))
+    (inputs `(("cairo" ,cairo)
+              ("dbus" ,dbus)
+              ("gdk-pixbuf" ,gdk-pixbuf)
+              ("glib" ,glib)
+              ("gperf" ,gperf)
+              ("imlib2" ,imlib2)
+              ("libev" ,libev)
+              ("libxcb" ,libxcb)
+              ("libxcursor" ,libxcursor)
+              ("libxdg-basedir" ,libxdg-basedir)
+              ("lua" ,lua-5.1)
+              ("pango" ,pango)
+              ("startup-notification" ,startup-notification)
+              ("xcb-util" ,xcb-util)
+              ("xcb-util-cursor" ,xcb-util-cursor)
+              ("xcb-util-image" ,xcb-util-image)
+              ("xcb-util-keysyms" ,xcb-util-keysyms)
+              ("xcb-util-renderutil" ,xcb-util-renderutil)
+              ("xcb-util-wm" ,xcb-util-wm)
+              ("imagemagick" ,imagemagick)))
+    (arguments `(#:phases (modify-phases %standard-phases
+                            (replace 'check
+                              (lambda* _
+                                (zero? (system* "../build/awesome" "-v")))))))
+    (synopsis "Highly configurable, next generation framework window manager
+for X")
+    (description
+     "awesome is a window manager for X.  It manages windows in different
+layouts, like floating or tiled.  Any layout can be applied dynamically,
+optimizing the environment for the application in use and the task currently
+being performed.
+
+In a tiled layout, windows are managed in a master and stacking area.  The
+master area contains the windows which currently need the most attention,
+whereas the stacking area contains all other windows.  In a floating layout
+windows can be resized and moved freely.  Dialog windows are always managed as
+floating, regardless of the layout currently applied.  The spiral and dwindle
+layouts are special cases of the tiled layout where the stacking area is
+arranged in a spiral for the former or as a rectangular fractal for the later.
+
+Windows are grouped by tags in awesome.  Each window can be tagged with one or
+more tags.  Selecting certain tags displays all windows with these tags.")
+    (license license:gpl2)
+    (home-page "https://awesome.naquadah.org/")))
-- 
2.7.3

Re: [PATCH] gnu: Add awesome.

[Carlo Zancanaro]

[-- Attachment #1: Type: text/plain, Size: 5133 bytes --]

After looking a bit more at patches where new files are added, I now
realise this is incomplete. I'll send through a new patch in a few minutes.

On 13 June 2016 at 10:12, Carlo Zancanaro <carlo@zancanaro.id.au> wrote:

> * gnu/packages/awesome.scm (awesome): New variable.
> ---
>  gnu/packages/awesome.scm | 93
> ++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 93 insertions(+)
>  create mode 100644 gnu/packages/awesome.scm
>
> diff --git a/gnu/packages/awesome.scm b/gnu/packages/awesome.scm
> new file mode 100644
> index 0000000..6aa1f93
> --- /dev/null
> +++ b/gnu/packages/awesome.scm
> @@ -0,0 +1,93 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2016 Carlo Zancanaro <carlo@zancanaro.id.au>
> +;;;
> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify it
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
> +
> +(define-module (gnu packages awesome)
> +  #:use-module ((guix licenses) #:prefix license:)
> +  #:use-module (guix packages)
> +  #:use-module (guix download)
> +  #:use-module (guix build-system cmake)
> +  #:use-module (guix build-system glib-or-gtk)
> +  #:use-module (gnu packages freedesktop)
> +  #:use-module (gnu packages glib)
> +  #:use-module (gnu packages gperf)
> +  #:use-module (gnu packages gtk)
> +  #:use-module (gnu packages image)
> +  #:use-module (gnu packages imagemagick)
> +  #:use-module (gnu packages libevent)
> +  #:use-module (gnu packages lua)
> +  #:use-module (gnu packages pkg-config)
> +  #:use-module (gnu packages xdisorg)
> +  #:use-module (gnu packages xorg))
> +
> +(define-public awesome
> +  (package
> +    (name "awesome")
> +    (version "3.4.15")
> +    (source
> +     (origin (method url-fetch)
> +             (uri (string-append "
> https://awesome.naquadah.org/download/awesome-"
> +                                 version ".tar.xz"))
> +             (sha256
> +              (base32
> +               "1m910lr7wkw2dgzmirfvz7dasfswhhccdf65l21iiciv24c3w1bb"))))
> +    (build-system cmake-build-system)
> +    (native-inputs `(("pkg-config" ,pkg-config)))
> +    (inputs `(("cairo" ,cairo)
> +              ("dbus" ,dbus)
> +              ("gdk-pixbuf" ,gdk-pixbuf)
> +              ("glib" ,glib)
> +              ("gperf" ,gperf)
> +              ("imlib2" ,imlib2)
> +              ("libev" ,libev)
> +              ("libxcb" ,libxcb)
> +              ("libxcursor" ,libxcursor)
> +              ("libxdg-basedir" ,libxdg-basedir)
> +              ("lua" ,lua-5.1)
> +              ("pango" ,pango)
> +              ("startup-notification" ,startup-notification)
> +              ("xcb-util" ,xcb-util)
> +              ("xcb-util-cursor" ,xcb-util-cursor)
> +              ("xcb-util-image" ,xcb-util-image)
> +              ("xcb-util-keysyms" ,xcb-util-keysyms)
> +              ("xcb-util-renderutil" ,xcb-util-renderutil)
> +              ("xcb-util-wm" ,xcb-util-wm)
> +              ("imagemagick" ,imagemagick)))
> +    (arguments `(#:phases (modify-phases %standard-phases
> +                            (replace 'check
> +                              (lambda* _
> +                                (zero? (system* "../build/awesome"
> "-v")))))))
> +    (synopsis "Highly configurable, next generation framework window
> manager
> +for X")
> +    (description
> +     "awesome is a window manager for X.  It manages windows in different
> +layouts, like floating or tiled.  Any layout can be applied dynamically,
> +optimizing the environment for the application in use and the task
> currently
> +being performed.
> +
> +In a tiled layout, windows are managed in a master and stacking area.  The
> +master area contains the windows which currently need the most attention,
> +whereas the stacking area contains all other windows.  In a floating
> layout
> +windows can be resized and moved freely.  Dialog windows are always
> managed as
> +floating, regardless of the layout currently applied.  The spiral and
> dwindle
> +layouts are special cases of the tiled layout where the stacking area is
> +arranged in a spiral for the former or as a rectangular fractal for the
> later.
> +
> +Windows are grouped by tags in awesome.  Each window can be tagged with
> one or
> +more tags.  Selecting certain tags displays all windows with these tags.")
> +    (license license:gpl2)
> +    (home-page "https://awesome.naquadah.org/")))
> --
> 2.7.3
>
>

[-- Attachment #2: Type: text/html, Size: 6571 bytes --]

[PATCH] gnu: Add awesome.

[Carlo Zancanaro]

* gnu/packages/awesome.scm: New file.
* gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
---
 gnu/local.mk             |  1 +
 gnu/packages/awesome.scm | 93 ++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 94 insertions(+)
 create mode 100644 gnu/packages/awesome.scm

diff --git a/gnu/local.mk b/gnu/local.mk
index 73aef0a..0d6e1c4 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -49,6 +49,7 @@ GNU_SYSTEM_MODULES =				\
   %D%/packages/autotools.scm			\
   %D%/packages/avahi.scm			\
   %D%/packages/avr.scm				\
+  %D%/packages/awesome.scm			\
   %D%/packages/backup.scm			\
   %D%/packages/base.scm				\
   %D%/packages/bash.scm				\
diff --git a/gnu/packages/awesome.scm b/gnu/packages/awesome.scm
new file mode 100644
index 0000000..6aa1f93
--- /dev/null
+++ b/gnu/packages/awesome.scm
@@ -0,0 +1,93 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2016 Carlo Zancanaro <carlo@zancanaro.id.au>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages awesome)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix build-system cmake)
+  #:use-module (guix build-system glib-or-gtk)
+  #:use-module (gnu packages freedesktop)
+  #:use-module (gnu packages glib)
+  #:use-module (gnu packages gperf)
+  #:use-module (gnu packages gtk)
+  #:use-module (gnu packages image)
+  #:use-module (gnu packages imagemagick)
+  #:use-module (gnu packages libevent)
+  #:use-module (gnu packages lua)
+  #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages xdisorg)
+  #:use-module (gnu packages xorg))
+
+(define-public awesome
+  (package
+    (name "awesome")
+    (version "3.4.15")
+    (source
+     (origin (method url-fetch)
+             (uri (string-append "https://awesome.naquadah.org/download/awesome-"
+                                 version ".tar.xz"))
+             (sha256
+              (base32
+               "1m910lr7wkw2dgzmirfvz7dasfswhhccdf65l21iiciv24c3w1bb"))))
+    (build-system cmake-build-system)
+    (native-inputs `(("pkg-config" ,pkg-config)))
+    (inputs `(("cairo" ,cairo)
+              ("dbus" ,dbus)
+              ("gdk-pixbuf" ,gdk-pixbuf)
+              ("glib" ,glib)
+              ("gperf" ,gperf)
+              ("imlib2" ,imlib2)
+              ("libev" ,libev)
+              ("libxcb" ,libxcb)
+              ("libxcursor" ,libxcursor)
+              ("libxdg-basedir" ,libxdg-basedir)
+              ("lua" ,lua-5.1)
+              ("pango" ,pango)
+              ("startup-notification" ,startup-notification)
+              ("xcb-util" ,xcb-util)
+              ("xcb-util-cursor" ,xcb-util-cursor)
+              ("xcb-util-image" ,xcb-util-image)
+              ("xcb-util-keysyms" ,xcb-util-keysyms)
+              ("xcb-util-renderutil" ,xcb-util-renderutil)
+              ("xcb-util-wm" ,xcb-util-wm)
+              ("imagemagick" ,imagemagick)))
+    (arguments `(#:phases (modify-phases %standard-phases
+                            (replace 'check
+                              (lambda* _
+                                (zero? (system* "../build/awesome" "-v")))))))
+    (synopsis "Highly configurable, next generation framework window manager
+for X")
+    (description
+     "awesome is a window manager for X.  It manages windows in different
+layouts, like floating or tiled.  Any layout can be applied dynamically,
+optimizing the environment for the application in use and the task currently
+being performed.
+
+In a tiled layout, windows are managed in a master and stacking area.  The
+master area contains the windows which currently need the most attention,
+whereas the stacking area contains all other windows.  In a floating layout
+windows can be resized and moved freely.  Dialog windows are always managed as
+floating, regardless of the layout currently applied.  The spiral and dwindle
+layouts are special cases of the tiled layout where the stacking area is
+arranged in a spiral for the former or as a rectangular fractal for the later.
+
+Windows are grouped by tags in awesome.  Each window can be tagged with one or
+more tags.  Selecting certain tags displays all windows with these tags.")
+    (license license:gpl2)
+    (home-page "https://awesome.naquadah.org/")))
-- 
2.7.3

Re: [PATCH] gnu: Add awesome.

[Danny Milosavljevic]

Hi,

thanks for the patch.

I think it would be better if it went into wm.scm . 

> +    (arguments `(#:phases (modify-phases %standard-phases
> +                            (replace 'check
> +                              (lambda* _
> +                                (zero? (system* "../build/awesome" "-v")))))))

What's up with the tests? Why disable them like this?

Re: [PATCH] gnu: Add awesome.

[ng0]

[-- Attachment #1: Type: text/plain, Size: 5744 bytes --]

On 2016-06-13(10:12:35+1000), Carlo Zancanaro wrote:
> * gnu/packages/awesome.scm (awesome): New variable

Woo! many thanks, I've had a work in progree gathering dust for
a while, thanks for packaging this :)
.
> ---
>  gnu/packages/awesome.scm | 93 ++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 93 insertions(+)
>  create mode 100644 gnu/packages/awesome.scm
>
> diff --git a/gnu/packages/awesome.scm b/gnu/packages/awesome.scm
> new file mode 100644
> index 0000000..6aa1f93
> --- /dev/null
> +++ b/gnu/packages/awesome.scm

I think gnu/packages/wm.scm is a better place, unless the forgotten files
add many awesome-wm related packages, which as well could be in
gnu/packages/lua.scm or other files then.

> @@ -0,0 +1,93 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2016 Carlo Zancanaro <carlo@zancanaro.id.au>
> +;;;
> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify it
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
> +
> +(define-module (gnu packages awesome)
> +  #:use-module ((guix licenses) #:prefix license:)
> +  #:use-module (guix packages)
> +  #:use-module (guix download)
> +  #:use-module (guix build-system cmake)
> +  #:use-module (guix build-system glib-or-gtk)
> +  #:use-module (gnu packages freedesktop)
> +  #:use-module (gnu packages glib)
> +  #:use-module (gnu packages gperf)
> +  #:use-module (gnu packages gtk)
> +  #:use-module (gnu packages image)
> +  #:use-module (gnu packages imagemagick)
> +  #:use-module (gnu packages libevent)
> +  #:use-module (gnu packages lua)
> +  #:use-module (gnu packages pkg-config)
> +  #:use-module (gnu packages xdisorg)
> +  #:use-module (gnu packages xorg))
> +
> +(define-public awesome
> +  (package
> +    (name "awesome")
> +    (version "3.4.15")

Is 3.4.15 the latest? I use 3.5.9 here, and this was what I targeted
with my work in progress.

> +    (source
> +     (origin (method url-fetch)
> +             (uri (string-append "https://awesome.naquadah.org/download/awesome-"
> +                                 version ".tar.xz"))
> +             (sha256
> +              (base32
> +               "1m910lr7wkw2dgzmirfvz7dasfswhhccdf65l21iiciv24c3w1bb"))))
> +    (build-system cmake-build-system)
> +    (native-inputs `(("pkg-config" ,pkg-config)))
> +    (inputs `(("cairo" ,cairo)
> +              ("dbus" ,dbus)
> +              ("gdk-pixbuf" ,gdk-pixbuf)
> +              ("glib" ,glib)
> +              ("gperf" ,gperf)
> +              ("imlib2" ,imlib2)
> +              ("libev" ,libev)
> +              ("libxcb" ,libxcb)
> +              ("libxcursor" ,libxcursor)
> +              ("libxdg-basedir" ,libxdg-basedir)
> +              ("lua" ,lua-5.1)
> +              ("pango" ,pango)
> +              ("startup-notification" ,startup-notification)
> +              ("xcb-util" ,xcb-util)
> +              ("xcb-util-cursor" ,xcb-util-cursor)
> +              ("xcb-util-image" ,xcb-util-image)
> +              ("xcb-util-keysyms" ,xcb-util-keysyms)
> +              ("xcb-util-renderutil" ,xcb-util-renderutil)
> +              ("xcb-util-wm" ,xcb-util-wm)
> +              ("imagemagick" ,imagemagick)))

it requires also lua-lgi, at least with 3.5.9 version. I can give you the wip
of that if it only got in with 3.5.x and you need it.

Building the documentation also requires doxygen and graphviz in case you want
to add a second output for them - I never made it that far and can't tell if the
docs are very big.

> +    (arguments `(#:phases (modify-phases %standard-phases
> +                            (replace 'check
> +                              (lambda* _
> +                                (zero? (system* "../build/awesome" "-v")))))))
> +    (synopsis "Highly configurable, next generation framework window manager
> +for X")
> +    (description
> +     "awesome is a window manager for X.  It manages windows in different
> +layouts, like floating or tiled.  Any layout can be applied dynamically,
> +optimizing the environment for the application in use and the task currently
> +being performed.
> +
> +In a tiled layout, windows are managed in a master and stacking area.  The
> +master area contains the windows which currently need the most attention,
> +whereas the stacking area contains all other windows.  In a floating layout
> +windows can be resized and moved freely.  Dialog windows are always managed as
> +floating, regardless of the layout currently applied.  The spiral and dwindle
> +layouts are special cases of the tiled layout where the stacking area is
> +arranged in a spiral for the former or as a rectangular fractal for the later.
> +
> +Windows are grouped by tags in awesome.  Each window can be tagged with one or
> +more tags.  Selecting certain tags displays all windows with these tags.")
> +    (license license:gpl2)
> +    (home-page "https://awesome.naquadah.org/")))
> --
> 2.7.3
>
>

--
♥Ⓐ ng0
For non-prism friendly talk find me on
psyced.org / loupsycedyglgamf.onion

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: [PATCH] gnu: Add awesome.

[Carlo Zancanaro]

[-- Attachment #1: Type: text/plain, Size: 871 bytes --]

Hi!

On 13 June 2016 at 17:53, Danny Milosavljevic <dannym@scratchpost.org>
wrote:

> I think it would be better if it went into wm.scm .
>

Ah, okay! I looked at ratpoison.scm, because it was the first window
manager that I thought of to look up. It was in its own file, so I followed
that example. I agree awesome fits better into wm.scm.

> +    (arguments `(#:phases (modify-phases %standard-phases
> > +                            (replace 'check
> > +                              (lambda* _
> > +                                (zero? (system* "../build/awesome"
> "-v")))))))
>
> What's up with the tests? Why disable them like this?
>

There actually aren't any tests, so if I leave the "check" phase to do the
default "make test", it fails. This way it at least checks that the awesome
binary was compiled and can be run. I'll put a comment in explaining that.

[-- Attachment #2: Type: text/html, Size: 1601 bytes --]

Re: [PATCH] gnu: Add awesome.

[Carlo Zancanaro]

[-- Attachment #1: Type: text/plain, Size: 1148 bytes --]

Hi!

On 13 June 2016 at 18:05, ng0 <ng0@we.make.ritual.n0.is> wrote:

> Is 3.4.15 the latest? I use 3.5.9 here, and this was what I targeted
> with my work in progress.
>

No, 3.4.15 isn't the latest. 3.5.9 is the latest stable, but I couldn't get
it to compile (at the very least lua-lgi is missing, I don't know if other
things are too). I figured it was better to have something rather than
nothing. I don't need more than 3.4.15, but not having awesome at all
stopped me from using GuixSD for a while.


> it requires also lua-lgi, at least with 3.5.9 version. I can give you the
> wip
> of that if it only got in with 3.5.x and you need it.
>

Apparently lua-lgi only became a dependency for the 3.5.x releases. If you
have a working package definition for it then I'm willing to try to get it
working with awesome. (I don't know anything about packaging lua libraries,
so I gave up on lua-lgi when it didn't work immediately.)


> Building the documentation also requires doxygen and graphviz in case you
> want
> to add a second output for them - I never made it that far and can't tell
> if the
> docs are very big.
>

I'll give this a go.

[-- Attachment #2: Type: text/html, Size: 1869 bytes --]

Re: [PATCH] gnu: Add awesome.

[Ludovic Courtès]

Hello!

Carlo Zancanaro <carlozancanaro@gmail.com> skribis:

> On 13 June 2016 at 17:53, Danny Milosavljevic <dannym@scratchpost.org>
> wrote:

[...]

>> What's up with the tests? Why disable them like this?
>>
>
> There actually aren't any tests, so if I leave the "check" phase to do the
> default "make test", it fails. This way it at least checks that the awesome
> binary was compiled and can be run. I'll put a comment in explaining that.

Fair enough.  In that case, could you simply add a comment with this
explanation around the ‘check’ phase?  That way, future contributors
will immediately see why we’re doing this.

Thank you!

Ludo’.

Re: [PATCH] gnu: Add awesome.

[Leo Famulari]

On Mon, Jun 13, 2016 at 10:38:53AM +1000, Carlo Zancanaro wrote:
> * gnu/packages/awesome.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.

Thanks for this patch!

> +              ("imagemagick" ,imagemagick)))

I think that imagemagick is only required while building, so it can be a
'native-input'.

You can check what packages the built output refers to: $ guix gc
--references $(./pre-inst-env guix build awesome)

Imagemagick is not in the list.

> +    (license license:gpl2)

I noticed that several of the files have the "or later" text. If they
are all like that, we could use gpl2+. Did you check if there are any
files with licenses besides GPL2+?

Re: [PATCH] gnu: Add awesome.

[Carlo Zancanaro]

[-- Attachment #1: Type: text/plain, Size: 1028 bytes --]

On 14 June 2016 at 01:46, Leo Famulari <leo@famulari.name> wrote:

> I think that imagemagick is only required while building, so it can be a
> 'native-input'.
>
> You can check what packages the built output refers to: $ guix gc
> --references $(./pre-inst-env guix build awesome)
>
> Imagemagick is not in the list.
>

Thanks for this! I had assumed that the "guix lint" would tell me about
something like that, given the check "inputs-should-be-native".

Is it possible for those references to be "wrong"? For there to be
something which is required at runtime, but doesn't show up in a "guix gc
--references" check?


> I noticed that several of the files have the "or later" text. If they
> are all like that, we could use gpl2+. Did you check if there are any
> files with licenses besides GPL2+?
>

The lua files (in lib/) don't have a license heading beyond a copyright
year/author in the luadoc tags. Everything which has a license heading
seems to be gpl2+ (I had missed the "or later" text, but I've updated it
now).

[-- Attachment #2: Type: text/html, Size: 1703 bytes --]

Re: [PATCH] gnu: Add awesome.

[Leo Famulari]

On Tue, Jun 14, 2016 at 10:57:41AM +1000, Carlo Zancanaro wrote:
> On 14 June 2016 at 01:46, Leo Famulari <leo@famulari.name> wrote:
> 
> > I think that imagemagick is only required while building, so it can be a
> > 'native-input'.
> >
> > You can check what packages the built output refers to: $ guix gc
> > --references $(./pre-inst-env guix build awesome)
> >
> > Imagemagick is not in the list.
> >
> 
> Thanks for this! I had assumed that the "guix lint" would tell me about
> something like that, given the check "inputs-should-be-native".
> 
> Is it possible for those references to be "wrong"? For there to be
> something which is required at runtime, but doesn't show up in a "guix gc
> --references" check?

My understanding is that `guix gc --references` reports the references
that it finds by scanning the store item you give as an argument (I
haven't read the code). So, if the packaged software needs to refer to
something but does not, you will not be warned by `guix gc --references`.

From ImageMagick, awesome uses the `convert` tool at build time. I
skimmed the results of `grep -r convert` and I didn't notice any other
uses of the tool, but I might have missed something. Can you
double-check?

> > I noticed that several of the files have the "or later" text. If they
> > are all like that, we could use gpl2+. Did you check if there are any
> > files with licenses besides GPL2+?
> >
> 
> The lua files (in lib/) don't have a license heading beyond a copyright
> year/author in the luadoc tags. Everything which has a license heading
> seems to be gpl2+ (I had missed the "or later" text, but I've updated it
> now).

Okay.

Re: [PATCH] gnu: Add awesome.

[Leo Famulari]

On Tue, Jun 14, 2016 at 10:57:41AM +1000, Carlo Zancanaro wrote:
> On 14 June 2016 at 01:46, Leo Famulari <leo@famulari.name> wrote:
> 
> > I think that imagemagick is only required while building, so it can be a
> > 'native-input'.
> >
> > You can check what packages the built output refers to: $ guix gc
> > --references $(./pre-inst-env guix build awesome)
> >
> > Imagemagick is not in the list.
> >
> 
> Thanks for this! I had assumed that the "guix lint" would tell me about
> something like that, given the check "inputs-should-be-native".

It appears that this check currently warns you if pkg-config is an input
type besides native-input. So, it's designed to take a list of software
that is typically only used at build time. But, it can't guess at the
proper operation of the software being packaged ;)

[PATCH] gnu: Add awesome.

[Carlo Zancanaro]

* gnu/packages/wm.scm (awesome): New variable.
---
 gnu/packages/wm.scm | 79 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 79 insertions(+)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index 5f32fc4..7ee517c 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -7,6 +7,7 @@
 ;;; Copyright © 2016 Danny Milosavljevic <dannym@scratchpost.org>
 ;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>
 ;;; Copyright © 2016 Al McElrath <hello@yrns.org>
+;;; Copyright © 2016 Carlo Zancanaro <carlo@zancanaro.id.au>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -28,6 +29,7 @@
   #:use-module (guix packages)
   #:use-module (gnu packages)
   #:use-module (gnu packages linux)
+  #:use-module (guix build-system cmake)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system haskell)
   #:use-module (gnu packages haskell)
@@ -49,6 +51,11 @@
   #:use-module (gnu packages maths)
   #:use-module (gnu packages web)
   #:use-module (gnu packages fontutils)
+  #:use-module (gnu packages freedesktop)
+  #:use-module (gnu packages glib)
+  #:use-module (gnu packages gperf)
+  #:use-module (gnu packages imagemagick)
+  #:use-module (gnu packages lua)
   #:use-module (guix download)
   #:use-module (guix git-download))
 
@@ -370,3 +377,75 @@ and easy to handle yet full of features to make an easy and fast desktop
 experience.")
     (home-page "http://fluxbox.org/")
     (license license:expat)))
+
+(define-public awesome
+  (package
+    (name "awesome")
+    (version "3.4.15")
+    (source
+     (origin (method url-fetch)
+             (uri (string-append "https://awesome.naquadah.org/download/awesome-"
+                                 version ".tar.xz"))
+             (sha256
+              (base32
+               "1m910lr7wkw2dgzmirfvz7dasfswhhccdf65l21iiciv24c3w1bb"))))
+    (build-system cmake-build-system)
+    (native-inputs `(("asciidoc" ,asciidoc)
+                     ("docbook-xsl" ,docbook-xsl)
+                     ("doxygen" ,doxygen)
+                     ("gperf" ,gperf)
+                     ("imagemagick" ,imagemagick)
+                     ("libxml2" ,libxml2) ; for XML_CATALOG_FILES
+                     ("pkg-config" ,pkg-config)
+                     ("xmlto" ,xmlto)))
+    (inputs `(("cairo" ,cairo)
+              ("dbus" ,dbus)
+              ("gdk-pixbuf" ,gdk-pixbuf)
+              ("glib" ,glib)
+              ("imlib2" ,imlib2)
+              ("libev" ,libev)
+              ("libxcb" ,libxcb)
+              ("libxcursor" ,libxcursor)
+              ("libxdg-basedir" ,libxdg-basedir)
+              ("lua" ,lua-5.1)
+              ("pango" ,pango)
+              ("startup-notification" ,startup-notification)
+              ("xcb-util" ,xcb-util)
+              ("xcb-util-cursor" ,xcb-util-cursor)
+              ("xcb-util-image" ,xcb-util-image)
+              ("xcb-util-keysyms" ,xcb-util-keysyms)
+              ("xcb-util-renderutil" ,xcb-util-renderutil)
+              ("xcb-util-wm" ,xcb-util-wm)))
+    (arguments `(#:phases (modify-phases %standard-phases
+                            (add-before 'build 'xmlto-skip-validation
+                              (lambda _
+                                ;; we can't download the necessary schema, so
+                                ;; so skip validation and assume they're valid
+                                (substitute* "../build/CMakeFiles/man.dir/build.make"
+                                  (("/xmlto") (string-append "/xmlto --skip-validation")))
+                                #t))
+                            (replace 'check
+                              (lambda _
+                                ;; there aren't any tests, so just make sure the
+                                ;; binary gets built and can be run successfully
+                                (zero? (system* "../build/awesome" "-v")))))))
+    (synopsis "Highly configurable, next generation framework window manager
+for X")
+    (description
+     "awesome is a window manager for X.  It manages windows in different
+layouts, like floating or tiled.  Any layout can be applied dynamically,
+optimizing the environment for the application in use and the task currently
+being performed.
+
+In a tiled layout, windows are managed in a master and stacking area.  The
+master area contains the windows which currently need the most attention,
+whereas the stacking area contains all other windows.  In a floating layout
+windows can be resized and moved freely.  Dialog windows are always managed as
+floating, regardless of the layout currently applied.  The spiral and dwindle
+layouts are special cases of the tiled layout where the stacking area is
+arranged in a spiral for the former or as a rectangular fractal for the later.
+
+Windows are grouped by tags in awesome.  Each window can be tagged with one or
+more tags.  Selecting certain tags displays all windows with these tags.")
+    (license license:gpl2+)
+    (home-page "https://awesome.naquadah.org/")))
-- 
2.7.3

Re: [PATCH] gnu: Add awesome.

[Ludovic Courtès]

Carlo Zancanaro <carlo@zancanaro.id.au> skribis:

> * gnu/packages/wm.scm (awesome): New variable.

Pushed as 3d1240aa2561792895795315c7783a28bf4412af with a few changes.

Primarily, I built it with --rounds=2 as per
<https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html>
and noticed that the ‘awesome’ binary, some PNGs, and the gzipped man
pages were not bit-reproducible (they included timestamps), so I
addressed these issues.  Now it is fully reproducible.

I also shrunk the description a bit, as per
<https://www.gnu.org/software/guix/manual/html_node/Synopses-and-Descriptions.html>,
and probably reindented a couple of things.

Thanks for the patch!

Ludo’.

Re: [PATCH] gnu: Add awesome.

[Carlo Zancanaro]

[-- Attachment #1: Type: text/plain, Size: 600 bytes --]

On 16 June 2016 at 22:38, Ludovic Courtès <ludo@gnu.org> wrote:

> Primarily, I built it with --rounds=2 as per
> <
> https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html>
> ...
>

I tried to build with --rounds=2, but always after I had built normally
(because I cared first about whether it compiled, then later about whether
it was deterministic). The --rounds=2 build never seemed to do anything. Is
there something I have to do to make that work? (I tried adding the --check
flag too, but it also seemed to not do anything, either with or without
--rounds.)

[-- Attachment #2: Type: text/html, Size: 1022 bytes --]

Re: [PATCH] gnu: Add awesome.

[Leo Famulari]

On Fri, Jun 17, 2016 at 09:31:59AM +1000, Carlo Zancanaro wrote:
> On 16 June 2016 at 22:38, Ludovic Courtès <ludo@gnu.org> wrote:
> 
> > Primarily, I built it with --rounds=2 as per
> > <
> > https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html>
> > ...
> >
> 
> I tried to build with --rounds=2, but always after I had built normally
> (because I cared first about whether it compiled, then later about whether
> it was deterministic). The --rounds=2 build never seemed to do anything. Is
> there something I have to do to make that work? (I tried adding the --check
> flag too, but it also seemed to not do anything, either with or without
> --rounds.)

Once you have built the package and it is in /gnu/store, you need to use
--check.

In that case, I'm not sure how it interacts with --rounds.

It would be good to get a reproducer if there's a bug here.

Re: [PATCH] gnu: Add awesome.

[ng0]

Leo Famulari <leo@famulari.name> writes:

> On Fri, Jun 17, 2016 at 09:31:59AM +1000, Carlo Zancanaro wrote:
>> On 16 June 2016 at 22:38, Ludovic Courtès <ludo@gnu.org> wrote:
>> 
>> > Primarily, I built it with --rounds=2 as per
>> > <
>> > https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html>
>> > ...
>> >
>> 
>> I tried to build with --rounds=2, but always after I had built normally
>> (because I cared first about whether it compiled, then later about whether
>> it was deterministic). The --rounds=2 build never seemed to do anything. Is
>> there something I have to do to make that work? (I tried adding the --check
>> flag too, but it also seemed to not do anything, either with or without
>> --rounds.)
>
> Once you have built the package and it is in /gnu/store, you need to use
> --check.
>
> In that case, I'm not sure how it interacts with --rounds.
>
> It would be good to get a reproducer if there's a bug here.
>

What is the exact problem here? these are my builts:

ng0@shadowwalker ~$ guix build --rounds=2 awesome
substitute: updating list of substitutes from
'https://mirror.hydra.gnu.org'... 100.0%
substitute: updating list of substitutes from
'https://mirror.hydra.gnu.org'... 100.0%
substitute: updating list of substitutes from
'https://mirror.hydra.gnu.org'... 100.0%
The following derivation will be built:
   /gnu/store/3g3l3i3j6d1zn9m0xjz8dgxnfphchjgp-awesome-3.4.15.drv
   The following files will be downloaded:
      /gnu/store/dplmx20hzggiin25pqrkx9z9irz9l7cn-awesome-3.4.15
         /gnu/store/kqkznj38c8z6jppl620q8fvz7ij9j6dp-libev-4.20
            /gnu/store/zvggrli42q119zpqjd8ydxygvfj840bp-libxdg-basedir-1.2.0
            @ substituter-started
            /gnu/store/kqkznj38c8z6jppl620q8fvz7ij9j6dp-libev-4.20
            /gnu/store/04q37mcyxybzbc46j9c6pa3g8553sbgz-guix-0.10.0-0.97c8/libexec/guix/substitute

Found valid signature for
/gnu/store/kqkznj38c8z6jppl620q8fvz7ij9j6dp-libev-4.20
From
https://mirror.hydra.gnu.org/nar/kqkznj38c8z6jppl620q8fvz7ij9j6dp-libev-4.20
Downloading kqkznj…-libev-4.20 (279KiB installed)...
 libev-4.20
 931KiB/s 00:00 | 144KiB transferred
 @ substituter-succeeded
 /gnu/store/kqkznj38c8z6jppl620q8fvz7ij9j6dp-libev-4.20
 @ substituter-started
 /gnu/store/zvggrli42q119zpqjd8ydxygvfj840bp-libxdg-basedir-1.2.0
 /gnu/store/04q37mcyxybzbc46j9c6pa3g8553sbgz-guix-0.10.0-0.97c8/libexec/guix/substitute

Found valid signature for
/gnu/store/zvggrli42q119zpqjd8ydxygvfj840bp-libxdg-basedir-1.2.0
From
https://mirror.hydra.gnu.org/nar/zvggrli42q119zpqjd8ydxygvfj840bp-libxdg-basedir-1.2.0
Downloading zvggrl…-libxdg-basedir-1.2.0 (42KiB installed)...
 libxdg-basedir-1.2.0
 4.1MiB/s 00:00 | 13KiB transferred
 @ substituter-succeeded
 /gnu/store/zvggrli42q119zpqjd8ydxygvfj840bp-libxdg-basedir-1.2.0
 @ substituter-started
 /gnu/store/dplmx20hzggiin25pqrkx9z9irz9l7cn-awesome-3.4.15
 /gnu/store/04q37mcyxybzbc46j9c6pa3g8553sbgz-guix-0.10.0-0.97c8/libexec/guix/substitute

Found valid signature for
/gnu/store/dplmx20hzggiin25pqrkx9z9irz9l7cn-awesome-3.4.15
From
https://mirror.hydra.gnu.org/nar/dplmx20hzggiin25pqrkx9z9irz9l7cn-awesome-3.4.15
Downloading dplmx2…-awesome-3.4.15 (1.4MiB installed)...
 awesome-3.4.15
 264KiB/s 00:03 | 818KiB transferred
 @ substituter-succeeded
 /gnu/store/dplmx20hzggiin25pqrkx9z9irz9l7cn-awesome-3.4.15
 @ build-started
 /gnu/store/3g3l3i3j6d1zn9m0xjz8dgxnfphchjgp-awesome-3.4.15.drv -
 x86_64-linux
 /var/log/guix/drvs/3g//3l3i3j6d1zn9m0xjz8dgxnfphchjgp-awesome-3.4.15.drv.bz2
 grafting '/gnu/store/dplmx20hzggiin25pqrkx9z9irz9l7cn-awesome-3.4.15'
 -> '/gnu/store/hvnlf55aj3rkgkllp567k7jr8q04fyqb-awesome-3.4.15'...
 @ build-started
 /gnu/store/3g3l3i3j6d1zn9m0xjz8dgxnfphchjgp-awesome-3.4.15.drv -
 x86_64-linux
 /var/log/guix/drvs/3g//3l3i3j6d1zn9m0xjz8dgxnfphchjgp-awesome-3.4.15.drv.bz2
 grafting '/gnu/store/dplmx20hzggiin25pqrkx9z9irz9l7cn-awesome-3.4.15'
 -> '/gnu/store/hvnlf55aj3rkgkllp567k7jr8q04fyqb-awesome-3.4.15'...
 @ build-succeeded
 /gnu/store/3g3l3i3j6d1zn9m0xjz8dgxnfphchjgp-awesome-3.4.15.drv -
 /gnu/store/hvnlf55aj3rkgkllp567k7jr8q04fyqb-awesome-3.4.15
 ng0@shadowwalker ~$ guix build --check --rounds=2 awesome
 @ build-started
 /gnu/store/3g3l3i3j6d1zn9m0xjz8dgxnfphchjgp-awesome-3.4.15.drv -
 x86_64-linux
 /var/log/guix/drvs/3g//3l3i3j6d1zn9m0xjz8dgxnfphchjgp-awesome-3.4.15.drv.bz2
 grafting '/gnu/store/dplmx20hzggiin25pqrkx9z9irz9l7cn-awesome-3.4.15'
 -> '/gnu/store/hvnlf55aj3rkgkllp567k7jr8q04fyqb-awesome-3.4.15'...
 /gnu/store/hvnlf55aj3rkgkllp567k7jr8q04fyqb-awesome-3.4.15
 

-- 
♥Ⓐ  ng0
Current Keys: https://we.make.ritual.n0.is/ng0.txt
For non-prism friendly talk find me on http://www.psyced.org

Re: [PATCH] gnu: Add awesome.

[Leo Famulari]

On Sun, Jul 31, 2016 at 09:45:29PM +0000, ng0 wrote:
> Leo Famulari <leo@famulari.name> writes:
> 
> > On Fri, Jun 17, 2016 at 09:31:59AM +1000, Carlo Zancanaro wrote:
> >> On 16 June 2016 at 22:38, Ludovic Courtès <ludo@gnu.org> wrote:
> >> 
> >> > Primarily, I built it with --rounds=2 as per
> >> > <
> >> > https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html>
> >> > ...
> >> >
> >> 
> >> I tried to build with --rounds=2, but always after I had built normally
> >> (because I cared first about whether it compiled, then later about whether
> >> it was deterministic). The --rounds=2 build never seemed to do anything. Is
> >> there something I have to do to make that work? (I tried adding the --check
> >> flag too, but it also seemed to not do anything, either with or without
> >> --rounds.)
> >
> > Once you have built the package and it is in /gnu/store, you need to use
> > --check.

Reading back, I realize that we didn't talk about grafting. --check
might not appear to have any effect if the package is grafted; in that
case, you'd need to add --no-grafts.