From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Pirotte Subject: Re: [PATCH] gnu: Add guile-gnome Date: Sat, 11 Jun 2016 18:54:13 -0300 Message-ID: <20160611185413.6ddfb50e@capac> References: <1464375363-31718-1-git-send-email-patrick.hetu@auf.org> <87y46ui2uk.fsf@gnu.org> <87ziqwkhkw.fsf@auf.org> <87vb1jhl7w.fsf@gnu.org> <87y46fk2k7.fsf@auf.org> <20160608173726.3f5597e4@capac> <20160609063753.GA513@debian-netbook> <20160609164552.6097b2b6@capac> <871t458mca.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/j4_0AIhh/YvFM41uttWJayS"; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44125) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBqrz-0006VQ-LL for guix-devel@gnu.org; Sat, 11 Jun 2016 17:55:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bBqrv-0003b2-H9 for guix-devel@gnu.org; Sat, 11 Jun 2016 17:55:06 -0400 Received: from maximusconfessor.all2all.org ([79.99.200.102]:56056) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBqrv-0003Zg-7i for guix-devel@gnu.org; Sat, 11 Jun 2016 17:55:03 -0400 In-Reply-To: <871t458mca.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Alex Kost Cc: Patrick Hetu , guix-devel@gnu.org --Sig_/j4_0AIhh/YvFM41uttWJayS Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Alex, > >> > > ... > >> > > + (modify-phases %standard-phases > >> > > + (add-before 'configure 'pre-configure > >> > > + (lambda* (#:key outputs #:allow-other-keys) > >> > > + (let ((out (assoc-ref outputs "out"))) > >> > > + (substitute* (find-files "." "^Makefile.in$") > >> > > + (("guilemoduledir =3D.*guile/site" all) > >> > > + (string-append all "/2.0"))) > >> > > + #t)))))) > >> > > ... =20 > >> > Just curious: why do you (string-append all "/2.0")? Is this a guix = guideline > >> > maybe? =20 > >> > IMO, G-wrap, Guile-Cairo and Guile-Gnome should all be installed in > >> > the directory returned by (%global-site-dir) =20 > >> `guilemoduledir =3D.*guile/site' is saved in the variable `all' and th= en > >> used in the second half of the substitute*. I have a similar one I > >> wrote for aria2 in bittorrent.scm =20 > > ok, but why "/2.0" is appended to it? =20 > I think the version is not needed, but Ludovic had another opinion. I > don't remember details but there was some discussion about it: > Thanks for the pointer. FWIW, I agree with Mark (a) (%global-site-dir) as always been part of gule's search paths for modules, and that should not be 'altered' for guix, imo; (b) it seems to me there has been a confuson, in this thread, in between those of you talking about packages that also need to install things in $prefix/bin and 'natively' do not distingish themselve from other version(= s) [1] and those of you talking packages that are compatible with several version of guile [the one listed in their configure.ac file] and these should be installed in (%global-site-dir), imo. But then maybe I'm missing something. Cheers, David [1] the thread sites qt 4 and 5, but guile does that too by the way, even if you specify --program-suffix, it installs itself and its scripts, in $prefix/bin, without the suffix --Sig_/j4_0AIhh/YvFM41uttWJayS Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXXIiFAAoJEPN0/ZOjBXrXwToIAKj5HqbhKi7zRBETbl4CTEM9 I3lFm/VUE+VpuvcARxk+mPeuVzpDUGcxp/afKlNejQjv6m5q4P54lTjBGPAXYKLW 0FHJw9yI+FcqcFwXpgjvFOj4k4Gmwamv2vItybLMg+1hZvnGF3W/svUTqTvNdXuH cVP9tWPROxFOucy41niTJH8hCsS9v64QpkJS0QOkMj8XLZZsxG0BSP3wfQIbnG9H RQCBDu9BAWIGVsdzPsqXRDlEw55RhEe0u7AtVEwMu8/AiWt7CrSlz8fMAOocXbwF VKOvHcuCIdAQy74GuNfNPbqzzkwm/7hg9VJJgYy5/yeuTadVZ4W2XdsHi2ba9gM= =ET3w -----END PGP SIGNATURE----- --Sig_/j4_0AIhh/YvFM41uttWJayS--