From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: [PATCH] gnu: Add higan. Date: Tue, 7 Jun 2016 21:29:38 +0300 Message-ID: <20160607182938.GD5795@debian-netbook> References: <87fustalcn.fsf@T420.taylan> <878tyh81c4.fsf@T420.taylan> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="8nsIa27JVQLqB7/C" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38438) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bALlC-0007vL-9p for guix-devel@gnu.org; Tue, 07 Jun 2016 14:29:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bALl7-00029o-WA for guix-devel@gnu.org; Tue, 07 Jun 2016 14:29:53 -0400 Received: from flashner.co.il ([178.62.234.194]:47622) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bALl7-000292-KL for guix-devel@gnu.org; Tue, 07 Jun 2016 14:29:49 -0400 Content-Disposition: inline In-Reply-To: <878tyh81c4.fsf@T420.taylan> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Taylan Ulrich =?utf-8?B?QmF5xLFybMSxL0thbW1lcg==?= Cc: guix-devel@gnu.org --8nsIa27JVQLqB7/C Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 07, 2016 at 06:28:59PM +0300, Taylan Ulrich Bay=C4=B1rl=C4=B1/K= ammer wrote: > If there are no comments, I'll just push this soon, and issues can be > fixed later; at least it builds and runs fine. :-) >=20 > Taylan >=20 >=20 > taylanbayirli@gmail.com (Taylan Ulrich "Bay=C4=B1rl=C4=B1/Kammer") writes: >=20 > > Some things to note about this package & questions: > > > > - There's no official VCS repo and the author doesn't want automated > > tools to download files from his homepage; there's an unofficial git > > repo at GitLab but I found it unsuitable so I'm hosting the sources > > specifically for Guix at GitHub now: > > it does list http://download.byuu.org/higan_v098-source.7z and it lists the git repo at https://gitlab.com/higan/higan , which only there says its the unofficial one. > > https://github.com/TaylanUB/higan > > > > Is this OK, or is there a place we can upload the original source > > bundle for Guix to download from? > > > > - I forgot if there's a guideline for this: the release versions are > > called 'v097', 'v098' etc. with always a 'v' in front. Should that > > 'v' appear in the version field of the package or should it be > > stripped? This one I have some insight for. Vapoursynth numbers all their versions R28, R29, etc. Its version is 29, with the download as `... name "-R" version ...' > > > > - As seems to be tradition among emulator developers, the build system > > and the program's handling of the file system are a big pile of poo, > > so: > > > > * Is it principally OK to reuse the standard `build' and `install' > > phase procedures a second time, just with the CWD changed, as I do > > here? that should be ok > > > > * The program insists on looking in ~/.local/share for some data files > > that are actually installed in $prefix/share; does my strategy here > > look OK, in that I wrap the executable to copy the data files into > > ~/.local/share every time the program is run? > > > > Thank you! > > > > Taylan > > > > > > From 707e8fc3c2ba1293693168b1d7a34e6000671158 Mon Sep 17 00:00:00 2001 > > From: =3D?UTF-8?q?Taylan=3D20Ulrich=3D20Bay=3DC4=3DB1rl=3DC4=3DB1/Kamme= r?=3D > > > > Date: Sun, 1 Nov 2015 20:45:09 +0100 > > Subject: [PATCH] gnu: Add higan. > > > > * gnu/packages/games.scm (higan): New variable. > > --- > > gnu/packages/games.scm | 92 ++++++++++++++++++++++++++++++++++++++++++= ++++++++ > > 1 file changed, 92 insertions(+) > > > > diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm > > index e552d09..57f8907 100644 > > --- a/gnu/packages/games.scm > > +++ b/gnu/packages/games.scm > > @@ -2243,3 +2243,95 @@ Red Eclipse provides fast paced and accessible g= ameplay.") > > license:cc-by-sa3.0 > > license:cc-by3.0 > > license:cc0))))) > > + > > +(define-public higan > > + (package > > + (name "higan") > > + (version "v098") > > + (source > > + (origin > > + (method url-fetch) > > + (uri (string-append > > + "https://github.com/TaylanUB/higan/archive/" version ".ta= r.gz")) > > + (file-name (string-append name "-" version ".tar.gz")) > > + (sha256 > > + (base32 "12snxrk8wa94x3l69qcimgm0xc22zjgf7vzhckp2lzyfbf27950v"= )))) > > + (build-system gnu-build-system) > > + (native-inputs > > + `(("pkg-config" ,pkg-config))) > > + (inputs > > + `(("alsa-lib" ,alsa-lib) > > + ("ao" ,ao) > > + ("eudev" ,eudev) > > + ("gtk+" ,gtk+-2) > > + ("gtksourceview-2" ,gtksourceview-2) > > + ("libxv" ,libxv) > > + ("mesa" ,mesa) > > + ("openal" ,openal) > > + ("pulseaudio" ,pulseaudio) > > + ("sdl" ,sdl))) > > + (arguments > > + '(#:phases > > + (let ((build-phase (assoc-ref %standard-phases 'build)) > > + (install-phase (assoc-ref %standard-phases 'install))) > > + (modify-phases %standard-phases > > + ;; The higan build system has no configure phase. > > + (delete 'configure) > > + (add-before 'build 'chdir-to-higan > > + (lambda _ > > + (chdir "higan"))) > > + (add-before 'install 'create-/share/applications > > + (lambda* (#:key outputs #:allow-other-keys) > > + (let ((out (assoc-ref outputs "out"))) > > + ;; It seems the author forgot to do this in the Makef= ile. > > + (mkdir-p (string-append out "/share/applications"))))) > > + (add-after 'install 'chdir-to-icarus > > + (lambda _ > > + (chdir "../icarus"))) > > + (add-after 'chdir-to-icarus 'build-icarus build-phase) > > + (add-after 'build-icarus 'install-icarus install-phase) > > + (add-after 'install-icarus 'wrap-higan-executable > > + (lambda* (#:key inputs outputs #:allow-other-keys) > > + (let* ((out (assoc-ref outputs "out")) > > + (bin (string-append out "/bin")) > > + (higan (string-append bin "/higan")) > > + (higan-original (string-append higan "-original"= )) > > + (bash (string-append (assoc-ref inputs "bash") > > + "/bin/bash")) > > + (coreutils (assoc-ref inputs "coreutils")) > > + (mkdir (string-append coreutils "/bin/mkdir")) > > + (cp (string-append coreutils "/bin/cp"))) > > + ;; First, have the executable make sure ~/.local/shar= e/higan > > + ;; contains up to date files. Higan insists on looki= ng there > > + ;; for these data files. > > + (rename-file higan higan-original) > > + (with-output-to-file higan > > + (lambda () > > + (display > > + (string-append > > + "#!" bash "\n" > > + ;; higan doesn't respect $XDG_DATA_HOME > > + mkdir " -p ~/.local/share\n" > > + cp " -r " out "/share/higan ~/.local/share\n" > > + "exec " higan-original)))) > > + (chmod higan #o555) > > + ;; Second, make sure higan will find icarus in PATH. > > + (wrap-program higan > > + `("PATH" ":" prefix (,bin)))))))) > > + #:make-flags > > + (list "compiler=3Dg++" > > + (string-append "prefix=3D" (assoc-ref %outputs "out"))) > > + ;; There is no test suite. > > + #:tests? #f)) > > + (home-page "http://byuu.org/emulation/higan/") > > + (synopsis "Nintendo multi-system emulator") > > + (description > > + "higan (formerly bsnes) is an emulator for multiple Nintendo vide= o game > > +consoles, including the Nintendo Entertainment System (NES/Famicom), S= uper > > +Nintendo Entertainment System (SNES/Super Famicom), Game Boy, Game Boy > > +Color (GBC), and Game Boy Advance (GBA). It also supports the subsyst= ems > > +Super Game Boy, BS-X Satellaview, and Sufami Turbo.") > > + ;; As noted in these files among more: > > + ;; - icarus/icarus.cpp > > + ;; - higan/emulator/emulator.hpp > > + (license license:gpl3))) >=20 --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --8nsIa27JVQLqB7/C Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJXVxKNAAoJEPTB05F+rO6TWAwP/3j1YZjSEbuFnfMfScGyd/Ei UwmBiL5OAJz26iG64LHBlv1OZZGYGUdkktVTUdd6a8zlVLns+GvPsm/zblWLLhJ7 ltjch5HbsLJ80B5uE0h//atmLi5FQcX7UJTdqtnZ9Ncst4KNejYUrl1BT6MCBp6w xWsTXRfdwIgFsSTg+6rXHDrE+d5aI5cgMUCCBQSQKRPOMxdnlaTovvv4x0/YaZ2t ko/Sl1mXY5KVxIhDqCmqUQ0Rfg+njhCgOoqxlMSjG2UCkl5LV7D6eSkIXM6n64Tf 5mX8c9EJB7JGk8wLFNH2OraOubvQS9Ooi7vPt/n6uOt0jrY7nIJJ3ViKkYLOlOyf jUmj5yBb/IOnXT0tK0FOFmYLTCCOaeRUKxlX9Ou3X3aonF2DpLzWKGYq1XNokTIf 59DGnRiMfCQh/E+gr54odvHAG4sdZo8qiznSn8kmNc6aUlfY0qon9/+yILcLuEP+ HpI/EqLYsoFCzczKMdtQJ6x56B8vY/aCRwkkGHBL7VJjl/Zx9Abef1SgqhVRRFkA yfct0lh+EGR/sdAHkBlN+rzpIl39gK9YkHRtQpr7RgL/rt0kOq6HNDXj6khXHr/f OCV8ISYV8rexAgNPafRBAgCskq1lpPuE5gigrwW+kSAuhUYWA01YH402+8caYMcS wnvMMBa0W+9IXGjeWS7D =LRIc -----END PGP SIGNATURE----- --8nsIa27JVQLqB7/C--