From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] gnu: Add python-ply and python2-ply.
Date: Mon, 6 Jun 2016 22:26:25 -0400
Message-ID: <20160607022625.GA29348@jasmine>
References: <20160607010110.52922ed9@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37570)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bA6j3-0007oI-QG
	for guix-devel@gnu.org; Mon, 06 Jun 2016 22:26:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bA6iz-0006pe-Iz
	for guix-devel@gnu.org; Mon, 06 Jun 2016 22:26:40 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:38541)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bA6iy-0006pO-9j
	for guix-devel@gnu.org; Mon, 06 Jun 2016 22:26:37 -0400
Content-Disposition: inline
In-Reply-To: <20160607010110.52922ed9@scratchpost.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Danny Milosavljevic <dannym+a@scratchpost.org>
Cc: guix-devel@gnu.org

On Tue, Jun 07, 2016 at 01:01:10AM +0200, Danny Milosavljevic wrote:

Thanks for the patch!

> * gnu/packages/python.scm (python-ply, python2-ply): New variables.

> +        (uri (string-append
> +               "https://pypi.python.org/packages/96/e0/"
> +               "430fcdb6b3ef1ae534d231397bee7e9304be14a47a267e82ebcb3323d0b5/ply-"
> +               version
> +               ".tar.gz"))

We should adapt pypi-uri to handle the new scheme, but in the meantime,
can you put the hash on its own line, to reduce noise in the commit log
for future updates? This would be the whole thing:

                  "96/e0/430fcdb6b3ef1ae534d231397bee7e9304be14a47a267e82ebcb3323d0b5/"

> +    (inputs
> +      `(("python-setuptools" ,python-setuptools)))

Does it use setuptools at run-time or just at build time? If the former,
then it can be a native-input. Also, if it's only required for the
python-2 version, can you use the python2-variant system as shown in the
package definition of python2-pyicu?

> +    (description "ply is an lex/yacc implemented purely in Python.  It uses
> +LR parsing and does extensive error checking.")

`guix lint` prefers to begin the description with a capital 'P'.

Also, it's nice to wrap 'lex' and 'yacc' in Texinfo markup like this:
@code{lex}. Then, the word 'lex' will be rendered specially. I'm not
sure if we have a policy on this but I think it's useful when referring
to other packages.