From: Leo Famulari <leo@famulari.name>
To: Lukas Gradl <lgradl@openmailbox.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] Add googletest
Date: Wed, 1 Jun 2016 21:49:44 -0400 [thread overview]
Message-ID: <20160602014944.GB31306@jasmine> (raw)
In-Reply-To: <87twhdez33.fsf@openmailbox.org>
On Wed, Jun 01, 2016 at 09:57:53AM -0500, Lukas Gradl wrote:
> Leo Famulari <leo@famulari.name> writes:
> > I noticed in the README.md that upstream suggests use of GNU Make unless
> > building from a Git checkout. Did you try that?
>
> I have not tried that. Their README.md left me under the impression
> that tests are not supported useing GNU Make, but I just looked at their
> Makefile and there are test targets, so I can try using the
> gnu-build-system, if that is preferred?
All else being equal, my personal preference is to use GNU tools. But
otherwise, we should use the build system that upstream supports most
fully. Especially, we should use the one that runs the tests.
> It seems they generate c++ header files using pump.py. I will look into
> that more. Python is also needed for tests.
Thanks for looking into that. If the header files are generated by other
code, then we prefer to build them ourselves rather than use the
"pre-compiled" headers.
next prev parent reply other threads:[~2016-06-02 1:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 20:44 [PATCH] Add googletest Lukas Gradl
2016-05-31 13:53 ` Lukas Gradl
2016-05-31 21:44 ` Leo Famulari
2016-06-01 4:48 ` Efraim Flashner
2016-06-02 13:51 ` Lukas Gradl
2016-06-01 7:47 ` Ludovic Courtès
2016-06-01 14:57 ` Lukas Gradl
2016-06-02 1:49 ` Leo Famulari [this message]
2016-06-02 15:44 ` Lukas Gradl
2016-06-05 13:12 ` Efraim Flashner
2016-06-05 21:09 ` Lukas Gradl
2016-06-09 18:40 ` Efraim Flashner
2016-06-09 22:17 ` Lukas Gradl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160602014944.GB31306@jasmine \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=lgradl@openmailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.