From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] Add libiax Date: Wed, 1 Jun 2016 21:44:49 -0400 Message-ID: <20160602014449.GA31306@jasmine> References: <87shx17pbq.fsf@openmailbox.org> <20160529004847.GA9375@jasmine> <87fuszwcno.fsf@openmailbox.org> <20160531190221.GA21454@solar> <20160531210242.GC19631@jasmine> <87pos1eyyw.fsf@openmailbox.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59572) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8HhN-0005IP-OF for guix-devel@gnu.org; Wed, 01 Jun 2016 21:45:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b8HhH-0002Hu-PL for guix-devel@gnu.org; Wed, 01 Jun 2016 21:45:24 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:49117) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8Hgy-0002Cv-Nn for guix-devel@gnu.org; Wed, 01 Jun 2016 21:45:19 -0400 Content-Disposition: inline In-Reply-To: <87pos1eyyw.fsf@openmailbox.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Lukas Gradl Cc: guix-devel@gnu.org On Wed, Jun 01, 2016 at 09:40:36AM -0500, Lukas Gradl wrote: > OK, I changed the name to libiax2 and added the license field + comment > from your patch. Thanks! Pushed as 4ff2060524. I noticed in my final review that the commit title was like this: gnu: telephony: Add libiax2. Our convention is mention the new package, but not the package's module, so I changed it to this: gnu: Add libiax2. > A big Thank you to everyone for their input! I still feel fairly unsure > about what I am doing, so I really appreciate that! Thanks for working on Ring!