From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] Add opendht.
Date: Tue, 31 May 2016 18:04:15 -0400
Message-ID: <20160531220415.GA31130@jasmine>
References: <87h9de2txi.fsf@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41809)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1b7rm3-0001Vy-6t
	for guix-devel@gnu.org; Tue, 31 May 2016 18:04:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1b7rly-0007qP-Nf
	for guix-devel@gnu.org; Tue, 31 May 2016 18:04:30 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:44969)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1b7rlw-0007pq-EH
	for guix-devel@gnu.org; Tue, 31 May 2016 18:04:26 -0400
Content-Disposition: inline
In-Reply-To: <87h9de2txi.fsf@openmailbox.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Lukas Gradl <lgradl@openmailbox.org>
Cc: guix-devel@gnu.org

On Tue, May 31, 2016 at 09:17:29AM -0500, Lukas Gradl wrote:
> * gnu/packages/telephony.scm (opendht): New variable.

I wonder if there is a better module? Distributed hash tables aren't
specific to telephony.

> +(define-public opendht
> +  (let ((commit "13f8c13ac4ebb3b43474d91ca48b42a1019083f4"))
> +    ;; This is the commit used by the Ring Project.

If Ring works with the latest tagged release, then I think we should use
that instead of the Git commit. They released only 3 days ago, so it's
unlikely that Ring needs some feature that's not in the tarball.

> +      (inputs
> +       `(("gnutls" ,gnutls)
> +         ("nettle" ,nettle)
> +         ("msgpack" ,msgpack)
> +         ("readline" ,readline)))

I noticed they bundle Argon2, which is a password hashing library:
https://github.com/savoirfairelinux/opendht/tree/master/src/argon2

I think we should delete the bundled library in an origin snippet and
make opendht use an external package.

> +      (native-inputs
> +       `(("autoconf" ,autoconf)
> +         ("pkg-config" ,pkg-config)
> +         ("automake" ,automake)
> +         ("libtool" ,libtool)))
> +      (arguments
> +       `(#:configure-flags '("--disable-tools" "--disable-python")
> +         #:phases (modify-phases %standard-phases
> +                    (add-before 'configure 'autoconf
> +                      (lambda _
> +                        (zero? (system* "autoreconf" "-vfi")))))))

If we package a tagged release, it's possible that we won't need to
bootstrap.

> +      (license gpl3))))

I skimmed the source files, and most of them said "either version 3 of
the License, or (at your option) any later version.", so we should use
gpl3+.