From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] Add libiax Date: Sat, 28 May 2016 20:48:47 -0400 Message-ID: <20160529004847.GA9375@jasmine> References: <87shx17pbq.fsf@openmailbox.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36411) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6oug-0000Jr-TR for guix-devel@gnu.org; Sat, 28 May 2016 20:49:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b6oub-0003s2-09 for guix-devel@gnu.org; Sat, 28 May 2016 20:49:05 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:52662) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6ouY-0003rm-Mv for guix-devel@gnu.org; Sat, 28 May 2016 20:49:00 -0400 Content-Disposition: inline In-Reply-To: <87shx17pbq.fsf@openmailbox.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Lukas Gradl Cc: guix-devel@gnu.org On Sat, May 28, 2016 at 06:08:57PM -0500, Lukas Gradl wrote: > > Hi Guix, > > Attached is a patch for LibIAX, a library that is used by the Ring > (formerly SFLphone). Cool! > Upstream seems to use no version numbers. I used the git commit ID that > is also refered to in the version that is bundeled with Ring. This is > also the latest commit to libiax. Since there are no upstream versions, I think the version string should use 0.0.0 to refer to the upstream version, then the Guix package revision number, and then the 7 characters of the commit. So, it would end up like this: 0.0.0-1.cabba9e See here: https://www.gnu.org/software/guix/manual/html_node/Version-Numbers.html#Version-Numbers > + (package > + (name "libiax") > + (version (string-append "2-" (string-take commit 7))) By the way, what does the "2-" refer to?