Fw: bug#23094: [PATCHv2] Re: bug#23094: icecat is missing a desktop file

[Danny Milosavljevic <dannym@scratchpost.org>]

Begin forwarded message:

Date: Sat, 16 Apr 2016 20:15:16 +0200
From: Danny Milosavljevic <dannym@scratchpost.org>
To: 23094@debbugs.gnu.org
Subject: bug#23094: [PATCHv2] Re: bug#23094: icecat is missing a desktop file


Any news on this? I just got a merge conflict so I was reminded of it again...

The current version of the patch that I'm successfully using is below - although I still can't get the version number into the installation lambda.

diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index 1ae97b2..96d32a1 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -501,7 +501,46 @@ standards.")
               (format #t "configure flags: ~s~%" flags)
               (zero? (apply system* bash
                             (string-append srcdir "/configure")
-                            flags))))))))
+                            flags)))))
+         (add-after
+          'install
+          'install-desktop-entry
+          (lambda* (#:key outputs #:allow-other-keys)
+            (let* ((out (assoc-ref outputs "out"))
+                   (applications (string-append out "/share/applications")))
+              (mkdir-p applications)
+              (call-with-output-file (string-append applications "/icecat.desktop")
+                (lambda (port)
+                  (format port "~
+[Desktop Entry]~@
+Version=1.0~@
+Name=GNU IceCat~@
+GenericName=Web Browser~@
+Comment=Browse the World Wide Web~@
+Keywords=Internet;WWW;Browser;Web~@
+Exec=~a/bin/icecat %u~@
+Terminal=false~@
+X-MultipleArgs=false~@
+Type=Application~@
+Icon=~a/lib/icecat-~a/browser/icons/mozicon128.png~@
+Categories=GNOME;GTK;Network;WebBrowser;~@
+MimeType=text/html;text/xml;application/xhtml+xml;application/xml;application/rss+xml;application/rdf+xml;image/gif;image/jpeg;image/png;x-scheme-handler/http;x-scheme-handler/https;x-scheme-handler/ftp;x-scheme-handler/chrome;video/webm;application/x-xpinstall;~@
+StartupNotify=true~@
+Actions=NewWindow;NewPrivateWindow~@
+~@
+[Desktop Action NewWindow]~@
+Name=Open a New Window~@
+Exec=~a/bin/icecat --new-window~@
+~@
+[Desktop Action NewPrivateWindow]~@
+Name=Open a New Private Window~@
+Exec=~a/bin/icecat -private-window~@
+"
+                          out
+                          out
+                          (string-drop-right "38.7.1-gnu1" (string-length "-gnu1")) ; FIXME do not hardcode
+                          out
+                          out)))))))))
     (home-page "http://www.gnu.org/software/gnuzilla/")
     (synopsis "Entirely free browser derived from Mozilla Firefox")
     (description