From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] gnu: Add rofi.
Date: Tue, 24 May 2016 23:38:00 -0400
Message-ID: <20160525033800.GA26173@jasmine>
References: <20160520062952.314ba37f@scratchpost.org>
	<20160523042826.GA20265@jasmine>
	<20160524085502.2f095f2f@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45574)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1b5PeA-0002dK-Kk
	for guix-devel@gnu.org; Tue, 24 May 2016 23:38:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1b5Pe6-0004DS-Fv
	for guix-devel@gnu.org; Tue, 24 May 2016 23:38:13 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:60787)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1b5Pe5-0004Cl-9V
	for guix-devel@gnu.org; Tue, 24 May 2016 23:38:10 -0400
Content-Disposition: inline
In-Reply-To: <20160524085502.2f095f2f@scratchpost.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org, Danny Milosavljevic <dannym+a@scratchpost.org>

On Tue, May 24, 2016 at 08:55:02AM +0200, Danny Milosavljevic wrote:
> On Mon, 23 May 2016 00:28:26 -0400
> Leo Famulari <leo@famulari.name> wrote:
> 
> > The failing test (helper_expand) seems to fail when it can't find
> > `which`. 
> 
> The failing test is test/helper-expand.c and it tries to do this:
>
>     str = rofi_expand_path ( "~/" ); <----- oh oh
[...]
>     str = rofi_expand_path ( "~root/" );   <--- oh oh
[...]
>             str[i] = g_strdup ( g_get_home_dir () ); <----------- oh oh
[...]
>             struct passwd *p = getpwnam ( &( str[i][1] ) ); <---------- oh oh

> What should we do about it?

How about disabling that test only? You can comment it out of wherever
it's invoked, or make it return true immediately. I'm not sure if we
have a canonical method... I think it depends on the language and
implementation.