[PATCH 0/1] GRUB: Use Parted in tests

[PATCH 0/1] GRUB: Use Parted in tests

[Leo Famulari]

I noticed that we disable a test in GRUB's test suite because it
required Parted and (presumably) had not packaged it yet.

I added it to native-inputs and successfully built GRUB on x86_64 and
i686.

Leo Famulari (1):
  gnu: grub: Re-enable test.

 gnu/packages/grub.scm | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

-- 
2.8.2

[PATCH 1/1] gnu: grub: Re-enable test.

[Leo Famulari]

* gnu/packages/grub.scm (grub)[arguments]: Re-enable test.
---
 gnu/packages/grub.scm | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/grub.scm b/gnu/packages/grub.scm
index ec2feeb..31b270c 100644
--- a/gnu/packages/grub.scm
+++ b/gnu/packages/grub.scm
@@ -25,6 +25,7 @@
   #:use-module (guix build-system gnu)
   #:use-module (gnu packages)
   #:use-module (gnu packages flex)
+  #:use-module (gnu packages disk)
   #:use-module (gnu packages bison)
   #:use-module (gnu packages gettext)
   #:use-module (gnu packages fontutils)
@@ -99,11 +100,6 @@
                      ;; Make the font visible.
                      (copy-file (assoc-ref inputs "unifont") "unifont.bdf.gz")
                      (system* "gunzip" "unifont.bdf.gz")
-
-                     ;; TODO: Re-enable this test when we have Parted.
-                     (substitute* "tests/partmap_test.in"
-                       (("set -e") "exit 77"))
-
                      #t)))))
     (inputs
      `(;; ("lvm2" ,lvm2)
@@ -121,6 +117,7 @@
 
        ;; Dependencies for the test suite.  The "real" QEMU is needed here,
        ;; because several targets are used.
+       ("parted" ,parted)
        ("qemu" ,qemu-for-tests)
        ("xorriso" ,xorriso)))
     (home-page "http://www.gnu.org/software/grub/")
-- 
2.8.2

Re: [PATCH 0/1] GRUB: Use Parted in tests

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 689 bytes --]

On Sun, May 22, 2016 at 07:28:36PM -0400, Leo Famulari wrote:
> I noticed that we disable a test in GRUB's test suite because it
> required Parted and (presumably) had not packaged it yet.
> 
> I added it to native-inputs and successfully built GRUB on x86_64 and
> i686.
> 
> Leo Famulari (1):
>   gnu: grub: Re-enable test.
> 
>  gnu/packages/grub.scm | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> -- 
> 2.8.2
> 

It looks good to me

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 0/1] GRUB: Use Parted in tests

[Ludovic Courtès]

Efraim Flashner <efraim@flashner.co.il> skribis:

> On Sun, May 22, 2016 at 07:28:36PM -0400, Leo Famulari wrote:
>> I noticed that we disable a test in GRUB's test suite because it
>> required Parted and (presumably) had not packaged it yet.
>> 
>> I added it to native-inputs and successfully built GRUB on x86_64 and
>> i686.
>> 
>> Leo Famulari (1):
>>   gnu: grub: Re-enable test.
>> 
>>  gnu/packages/grub.scm | 7 ++-----
>>  1 file changed, 2 insertions(+), 5 deletions(-)
>> 
>> -- 
>> 2.8.2
>> 
>
> It looks good to me

+1

Thanks!

Ludo’.

Re: [PATCH 0/1] GRUB: Use Parted in tests

[Leo Famulari]

On Mon, May 23, 2016 at 11:29:00PM +0200, Ludovic Courtès wrote:
> Efraim Flashner <efraim@flashner.co.il> skribis:
> 
> > On Sun, May 22, 2016 at 07:28:36PM -0400, Leo Famulari wrote:
> >> Leo Famulari (1):
> >>   gnu: grub: Re-enable test.
> >> 
> >>  gnu/packages/grub.scm | 7 ++-----
> >>  1 file changed, 2 insertions(+), 5 deletions(-)
> >
> > It looks good to me
> 
> +1

Thanks for the reviews. Pushed as 7febe3a28.