From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] gnu: Add rofi.
Date: Mon, 23 May 2016 00:28:26 -0400
Message-ID: <20160523042826.GA20265@jasmine>
References: <20160520062952.314ba37f@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38271)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1b4hTs-0003M1-RR
	for guix-devel@gnu.org; Mon, 23 May 2016 00:28:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1b4hTo-0001uU-Ih
	for guix-devel@gnu.org; Mon, 23 May 2016 00:28:39 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:44231)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1b4hTn-0001tU-C0
	for guix-devel@gnu.org; Mon, 23 May 2016 00:28:36 -0400
Content-Disposition: inline
In-Reply-To: <20160520062952.314ba37f@scratchpost.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Danny Milosavljevic <dannym+a@scratchpost.org>
Cc: guix-devel@gnu.org

On Fri, May 20, 2016 at 06:29:52AM +0200, Danny Milosavljevic wrote:
> * gnu/packages/xdisorg.scm (rofi): New variable.

Thanks for the patch! I'd never heard of this program but as someone who
uses dmenu a lot, I'd like to try it out.

> +(define-public rofi

> +              (uri (string-append "https://github.com/DaveDavenport/rofi/releases/download/" version "/rofi-" version ".tar.xz"))

Lines should be shorter than 80 characters whenever possible. `guix lint
rofi` should warn about this :)

> +    (arguments
> +     `(#:tests? #f))

The failing test (helper_expand) seems to fail when it can't find
`which`. There are examples of how to patch scripts with the path to our
`which` in gnu/packages. Can you try it out?

> +    (synopsis "Application Launcher")
> +    (description "Rofi is a minimalist Application Launcher.  It memorizes which applications you regularily use and also allows you to search for an application by name.")

I think that "Launcher" should not start with a capital letter.