all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Danny Milosavljevic <dannym+a@scratchpost.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add rofi.
Date: Mon, 23 May 2016 00:28:26 -0400	[thread overview]
Message-ID: <20160523042826.GA20265@jasmine> (raw)
In-Reply-To: <20160520062952.314ba37f@scratchpost.org>

On Fri, May 20, 2016 at 06:29:52AM +0200, Danny Milosavljevic wrote:
> * gnu/packages/xdisorg.scm (rofi): New variable.

Thanks for the patch! I'd never heard of this program but as someone who
uses dmenu a lot, I'd like to try it out.

> +(define-public rofi

> +              (uri (string-append "https://github.com/DaveDavenport/rofi/releases/download/" version "/rofi-" version ".tar.xz"))

Lines should be shorter than 80 characters whenever possible. `guix lint
rofi` should warn about this :)

> +    (arguments
> +     `(#:tests? #f))

The failing test (helper_expand) seems to fail when it can't find
`which`. There are examples of how to patch scripts with the path to our
`which` in gnu/packages. Can you try it out?

> +    (synopsis "Application Launcher")
> +    (description "Rofi is a minimalist Application Launcher.  It memorizes which applications you regularily use and also allows you to search for an application by name.")

I think that "Launcher" should not start with a capital letter.

  reply	other threads:[~2016-05-23  4:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-20  4:29 [PATCH] gnu: Add rofi Danny Milosavljevic
2016-05-23  4:28 ` Leo Famulari [this message]
2016-05-24  6:55   ` Danny Milosavljevic
2016-05-25  3:38     ` Leo Famulari
2016-05-26  0:56       ` [PATCH v2] * gnu/packages/xdisorg.scm (rofi): New variable Danny Milosavljevic
2016-05-27 17:41         ` Leo Famulari
2016-05-27 18:23           ` [PATCH v3] gnu: Add rofi Danny Milosavljevic
2016-05-27 18:35             ` Leo Famulari
2016-05-27 18:54               ` Danny Milosavljevic
2016-05-31 21:25                 ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160523042826.GA20265@jasmine \
    --to=leo@famulari.name \
    --cc=dannym+a@scratchpost.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.