all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 0/1] libarchive: Fix CVE-2016-1541
Date: Wed, 11 May 2016 21:55:57 -0400	[thread overview]
Message-ID: <20160512015557.GA28558@jasmine> (raw)
In-Reply-To: <87r3d8wvxg.fsf@gnu.org>

On Wed, May 11, 2016 at 03:44:59PM +0200, Ludovic Courtès wrote:
> Leo Famulari <leo@famulari.name> skribis:
> > This patch applies the upstream patch [1].
> 
> LGTM.

Done as e7806e6ca.

> > I will follow this commit with an "ungrafting" commit on core-updates.
> 
> Cool!

There are conflicts in cross gnu/packages/cross-base.scm when merging
master (e7806e6ca) into core-updates (f10e7ef47).

These are the commits that are conflicting:

Core-updates: 55de892b4 (gnu: glibc: Rename linux-headers input to
kernel-headers).

Master: efc4eb147 (gnu: cross: Use CROSS_*_INCLUDE_PATH for system
headers) and maybe the follow-up typo fix in 0a0884c9 (gnu: cross: Fix
typo).

I could try to resolve the conflict myself, but I think it's better if
Jan and Manolis work together, or at least give me some instructions.

Here are the specific conflicts I'm not sure how to resolve:

182 <<<<<<< HEAD
183                           (string-prefix? kernel x)))
184 
185                     (setenv "CROSS_CPATH"
186                             (string-append libc "/include:"
187                                            kernel "/include"))
188 =======
189                           (string-prefix? linux x)))
190                     (let ((cpath (string-append
191                                   libc "/include"
192                                   ":" linux "/include")))
193                       (for-each (cut setenv <> cpath)
194                                 '("CROSS_C_INCLUDE_PATH"
195                                   "CROSS_CPLUS_INCLUDE_PATH"
196                                   "CROSS_OBJC_INCLUDE_PATH"
197                                   "CROSS_OBJCPLUS_INCLUDE_PATH")))
198 >>>>>>> master

347 <<<<<<< HEAD
348             (let ((kernel (assoc-ref inputs "kernel-headers")))
349               (setenv "CROSS_CPATH"
350                       (string-append kernel "/include"))
351 =======
352             (let* ((linux (assoc-ref inputs "linux-headers"))
353                    (cpath (string-append linux "/include")))
354               (for-each (cut setenv <> cpath)
355                         '("CROSS_C_INCLUDE_PATH"
356                           "CROSS_CPLUS_INCLUDE_PATH"
357                           "CROSS_OBJC_INCLUDE_PATH"
358                           "CROSS_OBJCPLUS_INCLUDE_PATH"))
359 >>>>>>> master

The other conflicts are just comments that need 's/linux/kernel'.

  reply	other threads:[~2016-05-12  1:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-10 20:29 [PATCH 0/1] libarchive: Fix CVE-2016-1541 Leo Famulari
2016-05-10 20:29 ` [PATCH 1/1] gnu: " Leo Famulari
2016-05-11 13:44 ` [PATCH 0/1] " Ludovic Courtès
2016-05-12  1:55   ` Leo Famulari [this message]
2016-05-12  5:22     ` Jan Nieuwenhuizen
2016-05-13  6:45       ` Leo Famulari
2016-05-13 18:16         ` Jan Nieuwenhuizen
2016-05-14 17:26         ` Manolis Ragkousis
2016-05-12  7:24     ` Manolis Ragkousis
2016-05-15  6:45 ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160512015557.GA28558@jasmine \
    --to=leo@famulari.name \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.