From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH 2/3] gnu: Add ledger. Date: Sun, 8 May 2016 23:39:06 -0400 Message-ID: <20160509033906.GC25977@jasmine> References: <1462646320.1130194.601019473.51C9DD36@webmail.messagingengine.com> <1462648816.1139014.601038209.3A886EEC@webmail.messagingengine.com> <20160507222330.GA16592@jasmine> <1462673448.1215366.601202601.6F8B62D7@webmail.messagingengine.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47868) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azc2R-0002r3-NZ for guix-devel@gnu.org; Sun, 08 May 2016 23:39:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1azc2O-0000US-EV for guix-devel@gnu.org; Sun, 08 May 2016 23:39:19 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:54087) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azc2N-0000TZ-6p for guix-devel@gnu.org; Sun, 08 May 2016 23:39:16 -0400 Content-Disposition: inline In-Reply-To: <1462673448.1215366.601202601.6F8B62D7@webmail.messagingengine.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Alex Griffin Cc: guix-devel@gnu.org On Sat, May 07, 2016 at 09:10:48PM -0500, Alex Griffin wrote: > On Sat, May 7, 2016, at 05:23 PM, Leo Famulari wrote: > > What's the story with the library? Are there any programs that use it? > > Not that I know of, which is why I didn't include it (well, also I > couldn't figure out how to tell cmake that I don't want it to put stuff > in "$out/lib64"). And Python users will probably prefer beancount to the > ledger module. (Beancount is a reimplementation of ledger in Python.) Okay, I think it deserves a "TODO" comment where it is disabled. > > There are some GPL'd files in 'contrib/', 'lisp/', and 'python/res/' > > > > The file 'tools/update_copyright_year' has an Expat license. > > > > And, I think that unless we delete the bundled utfcpp, we are > > distributing it through `guix build --source ledger`, so we should > > mention its Boost license. > > Is the license field for the source tarball or the package that actually > gets installed? Good question. Can anyone answer it? > If it's the former, I have to say that's really > unintuitive. I was aware of these extra licenses, but none of that code > gets installed after you build the package. Note that emacs-ledger-mode > uses the same source tarball and I specified its license as GPL2+. > Instead of changing the license field in this patch, I added a note > about the other files to make it clear that changing the build options > may require the license field to change too. I can change it again if > that's wrong, but it seems to me that the license field should really be > about what gets installed. Good points. My original thought when bringing this up was that we also distribute the source code with `guix package --source`. I don't think we have an idiomatic way to specify a different set of licenses for the source code and the built package. Advice requested!