From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 2/3] gnu: Add ledger.
Date: Sat, 7 May 2016 18:23:30 -0400
Message-ID: <20160507222330.GA16592@jasmine>
References: <1462646320.1130194.601019473.51C9DD36@webmail.messagingengine.com>
	<1462648816.1139014.601038209.3A886EEC@webmail.messagingengine.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46497)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1azAdW-0007Ob-1X
	for guix-devel@gnu.org; Sat, 07 May 2016 18:23:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1azAdS-0004CH-Ns
	for guix-devel@gnu.org; Sat, 07 May 2016 18:23:45 -0400
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:33508)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1azAdQ-0004B9-Dk
	for guix-devel@gnu.org; Sat, 07 May 2016 18:23:42 -0400
Content-Disposition: inline
In-Reply-To: <1462648816.1139014.601038209.3A886EEC@webmail.messagingengine.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Alex Griffin <a@ajgrf.com>
Cc: guix-devel@gnu.org

On Sat, May 07, 2016 at 02:20:16PM -0500, Alex Griffin wrote:
> Here's an updated patch which doesn't delete the ledger-mode docs. I had
> initially removed them from this package thinking they belonged in
> emacs-ledger-mode, then forgot about it before submitting. Turns out
> it's more complicated to build the docs with the emacs-build-system than
> the cmake-build-system.

Thanks for the follow-up!

> * gnu/packages/finance.scm (ledger): New variable.

It works, at least for the basic things I tried against the examples in
'tests/input'. Speaking of which, it would be nice to include an example
in the output, perhaps under 'share/doc/ledger'.

> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://github.com/ledger/ledger/archive/v" version

Will you make this line < 80 characters?

> +    (build-system cmake-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'build 'build-doc
> +           (lambda _ (zero? (system* "make" "doc")))))
> +       #:configure-flags
> +       `("-DBUILD_DOCS:BOOL=ON"
> +         "-DBUILD_LIBRARY:BOOL=OFF"

What's the story with the library? Are there any programs that use it?

> +    (license (list license:bsd-3
> +                   license:asl2.0
> +                   (license:non-copyleft "file://src/wcwidth.cc"
> +                                         "See src/wcwidth.cc in the distribution.")))))

There are some GPL'd files in 'contrib/', 'lisp/', and 'python/res/'

The file 'tools/update_copyright_year' has an Expat license.

And, I think that unless we delete the bundled utfcpp, we are
distributing it through `guix build --source ledger`, so we should
mention its Boost license.